github/socket.io
1
1
Fork 0
mirror of https://github.com/socketio/socket.io.git synced 2026-01-10 07:28:06 -05:00
Code Issues Packages Projects Releases Wiki Activity

fix: remove duplicate pipeline when serving bundle

Browse Source 
Related: https://github.com/socketio/socket.io/issues/4946
This commit is contained in:
Damien Arrachequesne
2024-02-12 18:05:04 +01:00
parent e36062ca2d
commit e426f3e8e1
2 changed files with 15 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
lib/index.ts
View File

@@ -625,7 +625,6 @@ export class Server<
switch (encoding) {
case "br":
res.writeHead(200, { "content-encoding": "br" });
readStream.pipe(createBrotliCompress()).pipe(res);
pipeline(readStream, createBrotliCompress(), res, onError);
break;
case "gzip":

15
test/server-attachment.ts
View File

@@ -70,6 +70,21 @@ describe("server attachment", () => {
});
});
it("should serve client (br)", (done) => {
const srv = createServer();
new Server(srv);
request(srv)
.get("/socket.io/socket.io.js")
.set("accept-encoding", "br")
.buffer(true)
.end((err, res) => {
if (err) return done(err);
expect(res.headers["content-encoding"]).to.be("br");
expect(res.status).to.be(200);
done();
});
});
it("should serve client with necessary CORS headers", (done) => {
const srv = createServer();
new Server(srv, {