Release 1.0.6

Test for duplicate events on manual reconnect

History.md

@@ -1,4 +1,23 @@
 
+1.0.6 / 2014-06-19
+==================
+
+ * package: bump `socket.io-client`
+
+1.0.5 / 2014-06-16
+==================
+
+ * package: bump `engine.io` to fix jsonp `\n` bug and CORS warnings
+ * index: fix typo [yanatan16]
+ * add `removeListener` to blacklisted events
+ * examples: clearer instructions to install chat example
+ * index: fix namespace `connectBuffer` issue
+
+1.0.4 / 2014-06-02
+==================
+
+ * package: bump socket.io-client
+
 1.0.3 / 2014-05-31
 ==================
 

examples/chat/README.md

@@ -6,6 +6,9 @@ A simple chat demo for socket.io
 ## How to use
 
 ```
+$ cd socket.io
+$ npm install
+$ cd examples/chat
 $ npm install
 $ node .
 ```

lib/client.js

@@ -68,7 +68,7 @@ Client.prototype.connect = function(name){
     self.sockets.push(socket);
     self.nsps[nsp.name] = socket;
 
-    if ('/' == nsp.name) {
+    if ('/' == nsp.name && self.connectBuffer) {
       self.connectBuffer.forEach(self.connect, self);
       delete self.connectBuffer;
     }

lib/index.js

@@ -159,7 +159,9 @@ Server.prototype.adapter = function(v){
   if (!arguments.length) return this._adapter;
   this._adapter = v;
   for (var i in this.nsps) {
-    this.nsps[i].initAdapter();
+    if (this.nsps.hasOwnProperty(i)) {
+      this.nsps[i].initAdapter();
+    }
   }
   return this;
 };

lib/socket.js

@@ -25,7 +25,8 @@ exports.events = [
   'error',
   'connect',
   'disconnect',
-  'newListener'
+  'newListener',
+  'removeListener'
 ];
 
 /**

package.json

@@ -1,6 +1,6 @@
 {
   "name": "socket.io",
-  "version": "1.0.3",
+  "version": "1.0.6",
   "description": "node.js realtime framework server",
   "keywords": [
     "realtime",
@@ -19,9 +19,9 @@
     "test": "make test"
   },
   "dependencies": {
-    "engine.io": "1.2.2",
+    "engine.io": "1.3.1",
     "socket.io-parser": "2.2.0",
-    "socket.io-client": "1.0.3",
+    "socket.io-client": "1.0.6",
     "socket.io-adapter": "0.2.0",
     "has-binary-data": "0.1.1",
     "debug": "0.7.4"

test/socket.io.js

@@ -426,6 +426,24 @@ describe('socket.io', function(){
   });
 
   describe('socket', function(){
+
+    it('should not fire events more than once after manually reconnecting', function(done) {
+      var srv = http();
+      var sio = io(srv);
+      srv.listen(function(){
+        var clientSocket = client(srv, { reconnection: false });
+        clientSocket.on('connect', function init() {
+          clientSocket.removeListener('connect', init);
+          clientSocket.io.engine.close();
+
+          clientSocket.connect();
+          clientSocket.on('connect', function() {
+            done();
+          });
+        });
+      });
+    });
+
     it('should receive events', function(done){
       var srv = http();
       var sio = io(srv);
@@ -619,6 +637,30 @@ describe('socket.io', function(){
       });
     });
 
+    it('should receive all events emitted from namespaced client immediately and in order', function(done) {
+      var srv = http();
+      var sio = io(srv);
+      var total = 0;
+      srv.listen(function(){
+        sio.of('/chat', function(s){
+          s.on('hi', function(letter){
+            total++;
+            if (total == 2 && letter == 'b') {
+              done();
+            } else if (total == 1 && letter != 'a') {
+              throw new Error('events out of order');
+            }
+          });
+        });
+
+        var chat = client(srv, '/chat');
+        chat.emit('hi', 'a');
+        setTimeout(function() {
+          chat.emit('hi', 'b');
+        }, 50);
+      });
+    });
+
     it('should emit events with callbacks', function(done){
       var srv = http();
       var sio = io(srv);