chore(release): 4.3.1

Diff: https://github.com/socketio/socket.io/compare/4.3.0...4.3.1

CHANGELOG.md

@@ -1,3 +1,25 @@
+## [4.3.1](https://github.com/socketio/socket.io/compare/4.3.0...4.3.1) (2021-10-16)
+
+
+### Bug Fixes
+
+* fix server attachment ([#4127](https://github.com/socketio/socket.io/issues/4127)) ([0ef2a4d](https://github.com/socketio/socket.io/commit/0ef2a4d02c9350aff163df9cb61aece89c4dac0f))
+
+
+# [4.3.0](https://github.com/socketio/socket.io/compare/4.2.0...4.3.0) (2021-10-14)
+
+
+### Bug Fixes
+
+* **typings:** add name field to cookie option ([#4099](https://github.com/socketio/socket.io/issues/4099)) ([033c5d3](https://github.com/socketio/socket.io/commit/033c5d399a2b985afad32c1e4b0c16d764e248cd))
+* send volatile packets with binary attachments ([dc81fcf](https://github.com/socketio/socket.io/commit/dc81fcf461cfdbb5b34b1a5a96b84373754047d5))
+
+
+### Features
+
+* serve ESM bundle ([60edecb](https://github.com/socketio/socket.io/commit/60edecb3bd33801803cdcba0aefbafa381a2abb3))
+
+
 # [4.2.0](https://github.com/socketio/socket.io/compare/4.1.3...4.2.0) (2021-08-30)
 
 

Readme.md

@@ -22,7 +22,7 @@ Some implementations in other languages are also available:
 - [Swift](https://github.com/socketio/socket.io-client-swift)
 - [Dart](https://github.com/rikulo/socket.io-client-dart)
 - [Python](https://github.com/miguelgrinberg/python-socketio)
-- [.Net](https://github.com/Quobject/SocketIoClientDotNet)
+- [.NET](https://github.com/doghappy/socket.io-client-csharp)
 
 Its main features are:
 

lib/client.ts

@@ -7,6 +7,7 @@ import type { Namespace } from "./namespace";
 import type { EventsMap } from "./typed-events";
 import type { Socket } from "./socket";
 import type { SocketId } from "socket.io-adapter";
+import type { Socket as RawSocket } from "engine.io";
 
 const debug = debugModule("socket.io:client");
 
@@ -22,7 +23,7 @@ export class Client<
   EmitEvents extends EventsMap,
   ServerSideEvents extends EventsMap
 > {
-  public readonly conn;
+  public readonly conn: RawSocket;
 
   private readonly id: string;
   private readonly server: Server<ListenEvents, EmitEvents, ServerSideEvents>;
@@ -209,13 +210,11 @@ export class Client<
     const encodedPackets = opts.preEncoded
       ? (packet as any[]) // previous versions of the adapter incorrectly used socket.packet() instead of writeToEngine()
       : this.encoder.encode(packet as Packet);
-    for (const encodedPacket of encodedPackets) {
-      this.writeToEngine(encodedPacket, opts);
-    }
+    this.writeToEngine(encodedPackets, opts);
   }
 
   private writeToEngine(
-    encodedPacket: String | Buffer,
+    encodedPackets: Array<String | Buffer>,
     opts: WriteOptions
   ): void {
     if (opts.volatile && !this.conn.transport.writable) {
@@ -224,7 +223,12 @@ export class Client<
       );
       return;
     }
-    this.conn.write(encodedPacket, opts);
+    const packets = Array.isArray(encodedPackets)
+      ? encodedPackets
+      : [encodedPackets];
+    for (const encodedPacket of packets) {
+      this.conn.write(encodedPacket, opts);
+    }
   }
 
   /**

lib/index.ts

@@ -4,7 +4,12 @@ import { createDeflate, createGzip, createBrotliCompress } from "zlib";
 import accepts = require("accepts");
 import { pipeline } from "stream";
 import path = require("path");
-import engine = require("engine.io");
+import {
+  attach,
+  Server as Engine,
+  ServerOptions as EngineOptions,
+  AttachOptions,
+} from "engine.io";
 import { Client } from "./client";
 import { EventEmitter } from "events";
 import { ExtendedError, Namespace, ServerReservedEventsMap } from "./namespace";
@@ -14,8 +19,6 @@ import * as parser from "socket.io-parser";
 import type { Encoder } from "socket.io-parser";
 import debugModule from "debug";
 import { Socket } from "./socket";
-import type { CookieSerializeOptions } from "cookie";
-import type { CorsOptions } from "cors";
 import type { BroadcastOperator, RemoteSocket } from "./broadcast-operator";
 import {
   EventsMap,
@@ -30,7 +33,6 @@ const debug = debugModule("socket.io:server");
 const clientVersion = require("../package.json").version;
 const dotMapRegex = /\.map/;
 
-type Transport = "polling" | "websocket";
 type ParentNspNameMatchFn = (
   name: string,
   auth: { [key: string]: any },
@@ -39,107 +41,7 @@ type ParentNspNameMatchFn = (
 
 type AdapterConstructor = typeof Adapter | ((nsp: Namespace) => Adapter);
 
-interface EngineOptions {
-  /**
-   * how many ms without a pong packet to consider the connection closed
-   * @default 20000
-   */
-  pingTimeout: number;
-  /**
-   * how many ms before sending a new ping packet
-   * @default 25000
-   */
-  pingInterval: number;
-  /**
-   * how many ms before an uncompleted transport upgrade is cancelled
-   * @default 10000
-   */
-  upgradeTimeout: number;
-  /**
-   * how many bytes or characters a message can be, before closing the session (to avoid DoS).
-   * @default 1e5 (100 KB)
-   */
-  maxHttpBufferSize: number;
-  /**
-   * A function that receives a given handshake or upgrade request as its first parameter,
-   * and can decide whether to continue or not. The second argument is a function that needs
-   * to be called with the decided information: fn(err, success), where success is a boolean
-   * value where false means that the request is rejected, and err is an error code.
-   */
-  allowRequest: (
-    req: http.IncomingMessage,
-    fn: (err: string | null | undefined, success: boolean) => void
-  ) => void;
-  /**
-   * the low-level transports that are enabled
-   * @default ["polling", "websocket"]
-   */
-  transports: Transport[];
-  /**
-   * whether to allow transport upgrades
-   * @default true
-   */
-  allowUpgrades: boolean;
-  /**
-   * parameters of the WebSocket permessage-deflate extension (see ws module api docs). Set to false to disable.
-   * @default false
-   */
-  perMessageDeflate: boolean | object;
-  /**
-   * parameters of the http compression for the polling transports (see zlib api docs). Set to false to disable.
-   * @default true
-   */
-  httpCompression: boolean | object;
-  /**
-   * what WebSocket server implementation to use. Specified module must
-   * conform to the ws interface (see ws module api docs).
-   * An alternative c++ addon is also available by installing eiows module.
-   *
-   * @default `require("ws").Server`
-   */
-  wsEngine: Function;
-  /**
-   * an optional packet which will be concatenated to the handshake packet emitted by Engine.IO.
-   */
-  initialPacket: any;
-  /**
-   * configuration of the cookie that contains the client sid to send as part of handshake response headers. This cookie
-   * might be used for sticky-session. Defaults to not sending any cookie.
-   * @default false
-   */
-  cookie: CookieSerializeOptions | boolean;
-  /**
-   * the options that will be forwarded to the cors module
-   */
-  cors: CorsOptions;
-  /**
-   * whether to enable compatibility with Socket.IO v2 clients
-   * @default false
-   */
-  allowEIO3: boolean;
-}
-
-interface AttachOptions {
-  /**
-   * name of the path to capture
-   * @default "/engine.io"
-   */
-  path: string;
-  /**
-   * destroy unhandled upgrade requests
-   * @default true
-   */
-  destroyUpgrade: boolean;
-  /**
-   * milliseconds after which unhandled requests are ended
-   * @default 1000
-   */
-  destroyUpgradeTimeout: number;
-}
-
-interface EngineAttachOptions extends EngineOptions, AttachOptions {}
-
-interface ServerOptions extends EngineAttachOptions {
+interface ServerOptions extends EngineOptions, AttachOptions {
   /**
    * name of the path to capture
    * @default "/socket.io"
@@ -210,7 +112,7 @@ export class Server<
   private _adapter?: AdapterConstructor;
   private _serveClient: boolean;
   private opts: Partial<EngineOptions>;
-  private eio;
+  private eio: Engine;
   private _path: string;
   private clientPathRegex: RegExp;
 
@@ -254,7 +156,7 @@ export class Server<
     this.adapter(opts.adapter || Adapter);
     this.sockets = this.of("/");
     this.opts = opts;
-    if (srv) this.attach(srv as http.Server);
+    if (srv || typeof srv == "number") this.attach(srv as http.Server | number);
   }
 
   /**
@@ -334,7 +236,7 @@ export class Server<
     this.clientPathRegex = new RegExp(
       "^" +
         escapedPath +
-        "/socket\\.io(\\.min|\\.msgpack\\.min)?\\.js(\\.map)?(?:\\?|$)"
+        "/socket\\.io(\\.msgpack|\\.esm)?(\\.min)?\\.js(\\.map)?(?:\\?|$)"
     );
     return this;
   }
@@ -441,11 +343,11 @@ export class Server<
    */
   private initEngine(
     srv: http.Server,
-    opts: Partial<EngineAttachOptions>
+    opts: EngineOptions & AttachOptions
   ): void {
     // initialize engine
     debug("creating engine.io instance with opts %j", opts);
-    this.eio = engine.attach(srv, opts);
+    this.eio = attach(srv, opts);
 
     // attach static file serving
     if (this._serveClient) this.attachServe(srv);

package-lock.json

@@ -1,6 +1,6 @@
 {
   "name": "socket.io",
-  "version": "4.2.0",
+  "version": "4.3.1",
   "lockfileVersion": 1,
   "requires": true,
   "dependencies": {
@@ -362,6 +362,12 @@
         "fastq": "^1.6.0"
       }
     },
+    "@socket.io/component-emitter": {
+      "version": "3.0.0",
+      "resolved": "https://registry.npmjs.org/@socket.io/component-emitter/-/component-emitter-3.0.0.tgz",
+      "integrity": "sha512-2pTGuibAXJswAPJjaKisthqS/NOK5ypG4LYT6tEAV0S/mxW0zOIvYvGK0V8w8+SHxAm6vRMSjqSalFXeBAqs+Q==",
+      "dev": true
+    },
     "@tsconfig/node10": {
       "version": "1.0.8",
       "resolved": "https://registry.npmjs.org/@tsconfig/node10/-/node10-1.0.8.tgz",
@@ -882,37 +888,65 @@
       "dev": true
     },
     "engine.io": {
-      "version": "5.2.0",
-      "resolved": "https://registry.npmjs.org/engine.io/-/engine.io-5.2.0.tgz",
-      "integrity": "sha512-d1DexkQx87IFr1FLuV+0f5kAm1Hk1uOVijLOb+D1sDO2QMb7YjE02VHtZtxo7xIXMgcWLb+vl3HRT0rI9tr4jQ==",
+      "version": "6.0.0",
+      "resolved": "https://registry.npmjs.org/engine.io/-/engine.io-6.0.0.tgz",
+      "integrity": "sha512-Ui7yl3JajEIaACg8MOUwWvuuwU7jepZqX3BKs1ho7NQRuP4LhN4XIykXhp8bEy+x/DhA0LBZZXYSCkZDqrwMMg==",
       "requires": {
+        "@types/cookie": "^0.4.1",
+        "@types/cors": "^2.8.12",
+        "@types/node": ">=10.0.0",
         "accepts": "~1.3.4",
         "base64id": "2.0.0",
         "cookie": "~0.4.1",
         "cors": "~2.8.5",
         "debug": "~4.3.1",
-        "engine.io-parser": "~4.0.0",
-        "ws": "~7.4.2"
+        "engine.io-parser": "~5.0.0",
+        "ws": "~8.2.3"
+      },
+      "dependencies": {
+        "base64-arraybuffer": {
+          "version": "1.0.1",
+          "resolved": "https://registry.npmjs.org/base64-arraybuffer/-/base64-arraybuffer-1.0.1.tgz",
+          "integrity": "sha512-vFIUq7FdLtjZMhATwDul5RZWv2jpXQ09Pd6jcVEOvIsqCWTRFD/ONHNfyOS8dA/Ippi5dsIgpyKWKZaAKZltbA=="
+        },
+        "engine.io-parser": {
+          "version": "5.0.0",
+          "resolved": "https://registry.npmjs.org/engine.io-parser/-/engine.io-parser-5.0.0.tgz",
+          "integrity": "sha512-wn6QavHEqXoM+cg+x8uUG7GhxLBCfKEKNEsCNc7V2ugj3gB3lK91l1MuZiy6xFB2V9D1eew0aWkmpiT/aBb/KA==",
+          "requires": {
+            "base64-arraybuffer": "~1.0.1"
+          }
+        },
+        "ws": {
+          "version": "8.2.3",
+          "resolved": "https://registry.npmjs.org/ws/-/ws-8.2.3.tgz",
+          "integrity": "sha512-wBuoj1BDpC6ZQ1B7DWQBYVLphPWkm8i9Y0/3YdHjHKHiohOJ1ws+3OccDWtH+PoC9DZD5WOTrJvNbWvjS6JWaA=="
+        }
       }
     },
     "engine.io-client": {
-      "version": "5.2.0",
-      "resolved": "https://registry.npmjs.org/engine.io-client/-/engine.io-client-5.2.0.tgz",
-      "integrity": "sha512-BcIBXGBkT7wKecwnfrSV79G2X5lSUSgeAGgoo60plXf8UsQEvCQww/KMwXSMhVjb98fFYNq20CC5eo8IOAPqsg==",
+      "version": "6.0.2",
+      "resolved": "https://registry.npmjs.org/engine.io-client/-/engine.io-client-6.0.2.tgz",
+      "integrity": "sha512-cAep9lhZV6Q8jMXx3TNSU5cydMzMed8/O7Tz5uzyqZvpNPtQ3WQXrLYGADxlsuaFmOLN7wZLmT7ImiFhUOku8g==",
       "dev": true,
       "requires": {
-        "base64-arraybuffer": "0.1.4",
-        "component-emitter": "~1.3.0",
+        "@socket.io/component-emitter": "~3.0.0",
         "debug": "~4.3.1",
-        "engine.io-parser": "~4.0.1",
+        "engine.io-parser": "~5.0.0",
         "has-cors": "1.1.0",
         "parseqs": "0.0.6",
         "parseuri": "0.0.6",
-        "ws": "~7.4.2",
+        "ws": "~8.2.3",
         "xmlhttprequest-ssl": "~2.0.0",
         "yeast": "0.1.2"
       },
       "dependencies": {
+        "ws": {
+          "version": "8.2.3",
+          "resolved": "https://registry.npmjs.org/ws/-/ws-8.2.3.tgz",
+          "integrity": "sha512-wBuoj1BDpC6ZQ1B7DWQBYVLphPWkm8i9Y0/3YdHjHKHiohOJ1ws+3OccDWtH+PoC9DZD5WOTrJvNbWvjS6JWaA==",
+          "dev": true
+        },
         "xmlhttprequest-ssl": {
           "version": "2.0.0",
           "resolved": "https://registry.npmjs.org/xmlhttprequest-ssl/-/xmlhttprequest-ssl-2.0.0.tgz",
@@ -922,9 +956,21 @@
       }
     },
     "engine.io-parser": {
-      "version": "4.0.1",
-      "resolved": "https://registry.npmjs.org/engine.io-parser/-/engine.io-parser-4.0.1.tgz",
-      "integrity": "sha512-v5aZK1hlckcJDGmHz3W8xvI3NUHYc9t8QtTbqdR5OaH3S9iJZilPubauOm+vLWOMMWzpE3hiq92l9lTAHamRCg=="
+      "version": "5.0.1",
+      "resolved": "https://registry.npmjs.org/engine.io-parser/-/engine.io-parser-5.0.1.tgz",
+      "integrity": "sha512-j4p3WwJrG2k92VISM0op7wiq60vO92MlF3CRGxhKHy9ywG1/Dkc72g0dXeDQ+//hrcDn8gqQzoEkdO9FN0d9AA==",
+      "dev": true,
+      "requires": {
+        "base64-arraybuffer": "~1.0.1"
+      },
+      "dependencies": {
+        "base64-arraybuffer": {
+          "version": "1.0.1",
+          "resolved": "https://registry.npmjs.org/base64-arraybuffer/-/base64-arraybuffer-1.0.1.tgz",
+          "integrity": "sha512-vFIUq7FdLtjZMhATwDul5RZWv2jpXQ09Pd6jcVEOvIsqCWTRFD/ONHNfyOS8dA/Ippi5dsIgpyKWKZaAKZltbA==",
+          "dev": true
+        }
+      }
     },
     "error-ex": {
       "version": "1.3.2",
@@ -2405,18 +2451,29 @@
       "integrity": "sha512-PBZpxUPYjmoogY0aoaTmo1643JelsaS1CiAwNjRVdrI0X9Seuc19Y2Wife8k88avW6haG8cznvwbubAZwH4Mtg=="
     },
     "socket.io-client": {
-      "version": "4.2.0",
-      "resolved": "https://registry.npmjs.org/socket.io-client/-/socket.io-client-4.2.0.tgz",
-      "integrity": "sha512-3GJ2KMh7inJUNAOjgf8NaKJZJa9uRyfryh2LrVJyKyxmzoXlfW9DeDNqylJn0ovOFt4e/kRLNWzMt/YqqEWYSA==",
+      "version": "4.3.1",
+      "resolved": "https://registry.npmjs.org/socket.io-client/-/socket.io-client-4.3.1.tgz",
+      "integrity": "sha512-Few8Zw4Au4dEWAfwAR4QRf8aVmNP22kxHQYtGQqkZwLuDFhX9XgcZoAZJiGXnHNIydcL2r2wgRGMOaEW7Dx6pw==",
       "dev": true,
       "requires": {
-        "@types/component-emitter": "^1.2.10",
+        "@socket.io/component-emitter": "~3.0.0",
         "backo2": "~1.0.2",
-        "component-emitter": "~1.3.0",
         "debug": "~4.3.2",
-        "engine.io-client": "~5.2.0",
+        "engine.io-client": "~6.0.1",
         "parseuri": "0.0.6",
-        "socket.io-parser": "~4.0.4"
+        "socket.io-parser": "~4.1.1"
+      },
+      "dependencies": {
+        "socket.io-parser": {
+          "version": "4.1.1",
+          "resolved": "https://registry.npmjs.org/socket.io-parser/-/socket.io-parser-4.1.1.tgz",
+          "integrity": "sha512-USQVLSkDWE5nbcY760ExdKaJxCE65kcsG/8k5FDGZVVxpD1pA7hABYXYkCUvxUuYYh/+uQw0N/fvBzfT8o07KA==",
+          "dev": true,
+          "requires": {
+            "@socket.io/component-emitter": "~3.0.0",
+            "debug": "~4.3.1"
+          }
+        }
       }
     },
     "socket.io-client-v2": {
@@ -2915,7 +2972,8 @@
     "ws": {
       "version": "7.4.2",
       "resolved": "https://registry.npmjs.org/ws/-/ws-7.4.2.tgz",
-      "integrity": "sha512-T4tewALS3+qsrpGI/8dqNMLIVdq/g/85U98HPMa6F0m6xTbvhXU6RCQLqPH3+SlomNV/LdY6RXEbBpMH6EOJnA=="
+      "integrity": "sha512-T4tewALS3+qsrpGI/8dqNMLIVdq/g/85U98HPMa6F0m6xTbvhXU6RCQLqPH3+SlomNV/LdY6RXEbBpMH6EOJnA==",
+      "dev": true
     },
     "xmlhttprequest-ssl": {
       "version": "1.5.5",

package.json

@@ -1,6 +1,6 @@
 {
   "name": "socket.io",
-  "version": "4.2.0",
+  "version": "4.3.1",
   "description": "node.js realtime framework server",
   "keywords": [
     "realtime",
@@ -45,13 +45,10 @@
     "prepack": "npm run compile"
   },
   "dependencies": {
-    "@types/cookie": "^0.4.1",
-    "@types/cors": "^2.8.12",
-    "@types/node": ">=10.0.0",
     "accepts": "~1.3.4",
     "base64id": "~2.0.0",
     "debug": "~4.3.2",
-    "engine.io": "~5.2.0",
+    "engine.io": "~6.0.0",
     "socket.io-adapter": "~2.3.2",
     "socket.io-parser": "~4.0.4"
   },
@@ -62,7 +59,7 @@
     "nyc": "^15.1.0",
     "prettier": "^2.3.2",
     "rimraf": "^3.0.2",
-    "socket.io-client": "4.2.0",
+    "socket.io-client": "4.3.1",
     "socket.io-client-v2": "npm:socket.io-client@^2.4.0",
     "superagent": "^6.1.0",
     "supertest": "^6.1.6",

test/fixtures/server-close.ts

@@ -3,7 +3,7 @@ const ioc = require("socket.io-client");
 const io = require("../..")(server);
 
 const srv = server.listen(() => {
-  const socket = ioc("ws://localhost:" + server.address().port);
+  const socket = ioc.connect("ws://localhost:" + server.address().port);
   socket.on("connect", () => {
     io.close();
     socket.close();

test/socket.io.ts

@@ -39,6 +39,11 @@ const waitFor = (emitter, event) => {
   });
 };
 
+const getPort = (io: Server): number => {
+  // @ts-ignore
+  return io.httpServer.address().port;
+};
+
 describe("socket.io", () => {
   it("should be the same version as client", () => {
     const version = require("../package").version;
@@ -120,6 +125,13 @@ describe("socket.io", () => {
         testSourceMap("socket.io.msgpack.min.js.map")
       );
 
+      it("should serve the ESM bundle", testSource("socket.io.esm.min.js"));
+
+      it(
+        "should serve the source map for the ESM bundle",
+        testSourceMap("socket.io.esm.min.js.map")
+      );
+
       it("should handle 304", (done) => {
         const srv = createServer();
         new Server(srv);
@@ -189,29 +201,17 @@ describe("socket.io", () => {
 
     describe("port", () => {
       it("should be bound", (done) => {
-        const sockets = new Server(54010);
-        request("http://localhost:54010")
-          .get("/socket.io/socket.io.js")
-          .expect(200, done);
-      });
+        const io = new Server(0);
 
-      it("should be bound as a string", (done) => {
-        const sockets = new Server(54020);
-        request("http://localhost:54020")
+        request(`http://localhost:${getPort(io)}`)
           .get("/socket.io/socket.io.js")
           .expect(200, done);
       });
 
       it("with listen", (done) => {
-        const sockets = new Server().listen(54011);
-        request("http://localhost:54011")
-          .get("/socket.io/socket.io.js")
-          .expect(200, done);
-      });
+        const io = new Server().listen(0);
 
-      it("as a string", (done) => {
-        const sockets = new Server().listen(54012);
-        request("http://localhost:54012")
+        request(`http://localhost:${getPort(io)}`)
           .get("/socket.io/socket.io.js")
           .expect(200, done);
       });
@@ -222,7 +222,7 @@ describe("socket.io", () => {
     const request = require("superagent");
 
     it("should send the Access-Control-Allow-xxx headers on OPTIONS request", (done) => {
-      const sockets = new Server(54013, {
+      const io = new Server(0, {
         cors: {
           origin: "http://localhost:54023",
           methods: ["GET", "POST"],
@@ -231,7 +231,7 @@ describe("socket.io", () => {
         },
       });
       request
-        .options("http://localhost:54013/socket.io/default/")
+        .options(`http://localhost:${getPort(io)}/socket.io/default/`)
         .query({ transport: "polling", EIO: 4 })
         .set("Origin", "http://localhost:54023")
         .end((err, res) => {
@@ -250,7 +250,7 @@ describe("socket.io", () => {
     });
 
     it("should send the Access-Control-Allow-xxx headers on GET request", (done) => {
-      const sockets = new Server(54014, {
+      const io = new Server(0, {
         cors: {
           origin: "http://localhost:54024",
           methods: ["GET", "POST"],
@@ -259,7 +259,7 @@ describe("socket.io", () => {
         },
       });
       request
-        .get("http://localhost:54014/socket.io/default/")
+        .get(`http://localhost:${getPort(io)}/socket.io/default/`)
         .query({ transport: "polling", EIO: 4 })
         .set("Origin", "http://localhost:54024")
         .end((err, res) => {
@@ -274,12 +274,12 @@ describe("socket.io", () => {
     });
 
     it("should allow request if custom function in opts.allowRequest returns true", (done) => {
-      const sockets = new Server(createServer().listen(54022), {
+      const io = new Server(0, {
         allowRequest: (req, callback) => callback(null, true),
       });
 
       request
-        .get("http://localhost:54022/socket.io/default/")
+        .get(`http://localhost:${getPort(io)}/socket.io/default/`)
         .query({ transport: "polling", EIO: 4 })
         .end((err, res) => {
           expect(res.status).to.be(200);
@@ -288,11 +288,11 @@ describe("socket.io", () => {
     });
 
     it("should disallow request if custom function in opts.allowRequest returns false", (done) => {
-      const sockets = new Server(createServer().listen(54023), {
+      const io = new Server(0, {
         allowRequest: (req, callback) => callback(null, false),
       });
       request
-        .get("http://localhost:54023/socket.io/default/")
+        .get(`http://localhost:${getPort(io)}/socket.io/default/`)
         .set("origin", "http://foo.example")
         .query({ transport: "polling", EIO: 4 })
         .end((err, res) => {
@@ -304,22 +304,22 @@ describe("socket.io", () => {
 
   describe("close", () => {
     it("should be able to close sio sending a srv", (done) => {
-      const PORT = 54018;
-      const srv = createServer().listen(PORT);
-      const sio = new Server(srv);
+      const httpServer = createServer().listen(0);
+      const io = new Server(httpServer);
+      const port = getPort(io);
       const net = require("net");
       const server = net.createServer();
 
-      const clientSocket = client(srv, { reconnection: false });
+      const clientSocket = client(httpServer, { reconnection: false });
 
       clientSocket.on("disconnect", () => {
-        expect(sio.sockets.sockets.size).to.equal(0);
-        server.listen(PORT);
+        expect(io.sockets.sockets.size).to.equal(0);
+        server.listen(port);
       });
 
       clientSocket.on("connect", () => {
-        expect(sio.sockets.sockets.size).to.equal(1);
-        sio.close();
+        expect(io.sockets.sockets.size).to.equal(1);
+        io.close();
       });
 
       server.once("listening", () => {
@@ -331,30 +331,31 @@ describe("socket.io", () => {
       });
     });
 
-    it("should be able to close sio sending a port", () => {
-      const PORT = 54019;
-      const sio = new Server(PORT);
+    it("should be able to close sio sending a srv", (done) => {
+      const io = new Server(0);
+      const port = getPort(io);
       const net = require("net");
       const server = net.createServer();
 
-      const clientSocket = ioc("ws://0.0.0.0:" + PORT, {
+      const clientSocket = ioc("ws://0.0.0.0:" + port, {
         reconnection: false,
       });
 
       clientSocket.on("disconnect", () => {
-        expect(Object.keys(sio._nsps["/"].sockets).length).to.equal(0);
-        server.listen(PORT);
+        expect(io.sockets.sockets.size).to.equal(0);
+        server.listen(port);
       });
 
       clientSocket.on("connect", () => {
-        expect(Object.keys(sio._nsps["/"].sockets).length).to.equal(1);
-        sio.close();
+        expect(io.sockets.sockets.size).to.equal(1);
+        io.close();
       });
 
       server.once("listening", () => {
         // PORT should be free
         server.close((error) => {
           expect(error).to.be(undefined);
+          done();
         });
       });
     });
@@ -806,6 +807,7 @@ describe("socket.io", () => {
       srv.listen(() => {
         const socket = client(srv);
 
+        // @ts-ignore
         socket.io.engine.write = () => {}; // prevent the client from sending a CONNECT packet
 
         socket.on("disconnect", () => {
@@ -1382,6 +1384,32 @@ describe("socket.io", () => {
       }, 200);
     });
 
+    it("should emit only one consecutive volatile event with binary (ws)", (done) => {
+      const srv = createServer();
+      const sio = new Server(srv, { transports: ["websocket"] });
+
+      let counter = 0;
+      srv.listen(() => {
+        sio.on("connection", (s) => {
+          // Wait to make sure there are no packets being sent for opening the connection
+          setTimeout(() => {
+            s.volatile.emit("ev", Buffer.from([1, 2, 3]));
+            s.volatile.emit("ev", Buffer.from([4, 5, 6]));
+          }, 20);
+        });
+
+        const socket = client(srv, { transports: ["websocket"] });
+        socket.on("ev", () => {
+          counter++;
+        });
+      });
+
+      setTimeout(() => {
+        expect(counter).to.be(1);
+        done();
+      }, 200);
+    });
+
     it("should emit regular events after trying a failed volatile event (polling)", (done) => {
       const srv = createServer();
       const sio = new Server(srv, { transports: ["polling"] });
@@ -1806,6 +1834,7 @@ describe("socket.io", () => {
             console.log(
               "\u001b[96mNote: warning expected and normal in test.\u001b[39m"
             );
+            // @ts-ignore
             socket.io.engine.write("5woooot");
             setTimeout(() => {
               done();
@@ -1825,6 +1854,7 @@ describe("socket.io", () => {
             console.log(
               "\u001b[96mNote: warning expected and normal in test.\u001b[39m"
             );
+            // @ts-ignore
             socket.io.engine.write('44["handle me please"]');
             setTimeout(() => {
               done();
@@ -1845,6 +1875,7 @@ describe("socket.io", () => {
             done();
           });
           s.conn.on("upgrade", () => {
+            // @ts-ignore
             socket.io.engine.write("5woooot");
           });
         });
@@ -1862,6 +1893,7 @@ describe("socket.io", () => {
             done();
           });
           s.conn.on("upgrade", () => {
+            // @ts-ignore
             socket.io.engine.write("5");
           });
         });