fix tests

[skip ci]

packages/engine.io-parser/test.js

@@ -1,12 +0,0 @@
-const parser = require('.');
-
-parser.encodePayload([
-  {
-    type: 'message',
-    data: '€',
-  },
-  {
-    type: 'message',
-    data: Buffer.from([1, 2, 3, 4]),
-  },
-], true, console.log);

packages/engine.io-parser/zuul.config.js

@@ -1,44 +0,0 @@
-"use strict";
-
-const browsers = require("socket.io-browsers");
-
-const zuulConfig = (module.exports = {
-  ui: "mocha-bdd",
-
-  // test on localhost by default
-  local: true,
-  open: true,
-
-  concurrency: 2, // ngrok only accepts two tunnels by default
-  // if browser does not sends output in 120s since last output:
-  // stop testing, something is wrong
-  browser_output_timeout: 120 * 1000,
-  browser_open_timeout: 60 * 4 * 1000,
-  // we want to be notified something is wrong asap, so no retry
-  browser_retries: 1,
-
-  browserify: [
-    {
-      plugin: ["tsify", {
-        target: "es5"
-      }],
-      transform: {
-        name: "babelify",
-        presets: ["@babel/preset-env"]
-      }
-    }
-  ]
-});
-
-if (process.env.CI === "true") {
-  zuulConfig.local = false;
-  zuulConfig.tunnel = {
-    type: "ngrok",
-    bind_tls: true
-  };
-}
-
-const isPullRequest =
-  process.env.TRAVIS_PULL_REQUEST &&
-  process.env.TRAVIS_PULL_REQUEST !== "false";
-zuulConfig.browsers = isPullRequest ? browsers.pullRequest : browsers.all;

packages/socket.io/lib/index.ts

@@ -831,14 +831,13 @@ export class Server<
     restoreAdapter();
 
     if (this.httpServer) {
-      await new Promise<void>((resolve, reject) => {
+      return new Promise<void>((resolve) => {
         this.httpServer.close((err) => {
           fn && fn(err);
           if (err) {
-            reject(err);
-          } else {
-            resolve();
+            debug("server was not running");
           }
+          resolve();
         });
       });
     } else {

packages/socket.io/test/close.ts

@@ -70,6 +70,27 @@ describe("close", () => {
     });
   });
 
+  it("should not throw when the underlying HTTP server is not running (callback)", (done) => {
+    const httpServer = createServer();
+    const io = new Server(httpServer);
+
+    io.close((err) => {
+      expect((err as Error & { code: string }).code).to.eql(
+        "ERR_SERVER_NOT_RUNNING",
+      );
+      done();
+    });
+  });
+
+  it("should not throw when the underlying HTTP server is not running (Promise)", (done) => {
+    const httpServer = createServer();
+    const io = new Server(httpServer);
+
+    io.close()
+      .then(() => done())
+      .catch((e) => done(e));
+  });
+
   describe("graceful close", () => {
     function fixture(filename) {
       return (