github/textmate
1
1
Fork 0
mirror of https://github.com/textmate/textmate.git synced 2026-04-28 03:00:34 -04:00
Code Issues Packages Projects Releases Wiki Activity

Show alert if readlink fails

Browse Source 
I am seeing crash reports from resolve_links and I can’t think of any other reason for this crash, than readlink() returning a value which is neither -1 nor in the range [0..len].
This commit is contained in:
Allan Odgaard
2012-08-29 17:42:57 +02:00
parent 0e96a04d76
commit 68ed829313
1 changed files with 10 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
Frameworks/io/src/path.cc
View File

@@ -266,12 +266,18 @@ namespace path
{
char buf[PATH_MAX];
ssize_t len = readlink(path.c_str(), buf, sizeof(buf));
if(len == -1)
if(0 < len && len < PATH_MAX)
{
fprintf(stderr, "*** error reading link ‘%s’\n", path.c_str());
return NULL_STR;
path = resolve_links(join(resolvedParent, std::string(buf, buf + len)), resolveParent, seen);
}
else
{
std::string errStr = len == -1 ? strerror(errno) : text::format("Result outside allowed range %zd", len);
std::string message = text::format("Failure calling readlink(‘%s’):\n\n\u2003%s\n\nPlease submit a bug report quoting the above:\nhttps://github.com/textmate/textmate/issues", path.c_str(), errStr.c_str());
CFOptionFlags responseFlags;
CFUserNotificationDisplayAlert(0 /* timeout */, kCFUserNotificationStopAlertLevel, NULL /* iconURL */, NULL /* soundURL */, NULL /* localizationURL */, CFSTR("Read Link Failed"), cf::wrap(message), CFSTR("Continue"), NULL /* alternateButtonTitle */, NULL /* otherButtonTitle */, &responseFlags);
}
path = resolve_links(join(resolvedParent, std::string(buf, buf + len)), resolveParent, seen);
}
else if(S_ISREG(buf.st_mode))
{