github/textmate
1
1
Fork 0
mirror of https://github.com/textmate/textmate.git synced 2026-01-21 04:38:13 -05:00
Code Issues Packages Projects Releases Wiki Activity

Add safety checks

Browse Source 
Since 10% of reported crashes are in synchronizeWindowTitle and seems to be about not having a proper document pointer, I am adding these checks and some debug output — don’t understand how we would get into this situation though.
This commit is contained in:
Allan Odgaard
2012-09-16 11:38:45 +02:00
parent 13ba42f98d
commit 7cd8ae4b8e
1 changed files with 13 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
Frameworks/DocumentWindow/src/DocumentController.mm
View File

@@ -506,7 +506,20 @@ OAK_DEBUG_VAR(DocumentController);
- (void)synchronizeWindowTitle
{
if(selectedTabIndex >= documentTabs.size())
{
fprintf(stderr, "*** error: selected tab out of bounds: %zu >= %zu\n", selectedTabIndex, documentTabs.size());
return;
}
document::document_ptr doc = [self selectedDocument];
if(!doc)
{
fprintf(stderr, "*** error: no document (synchronizeWindowTitle)\n");
return;
}
std::string docDirectory = doc->path() != NULL_STR ? path::parent(doc->path()) : to_s(self.untitledSavePath);
std::map<std::string, std::string> map;