github/textmate
1
1
Fork 0
mirror of https://github.com/textmate/textmate.git synced 2026-04-28 03:00:34 -04:00
Code Issues Packages Projects Releases Wiki Activity

Introduce plug-in blacklist which defaults to io.emmet.EmmetTextmate

Browse Source 
We have been detecting plug-in crashes for about two years, and we offer the user to remove crashing plug-ins, nonetheless we are still getting a significant number of crash reports from loading the Emmet plug-in.
This commit is contained in:
Allan Odgaard
2016-07-11 23:00:55 +02:00
parent ee26676df4
commit 81d2586ffc
1 changed files with 12 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
Applications/TextMate/src/TMPlugInController.mm
View File

@@ -11,6 +11,7 @@ OAK_DEBUG_VAR(PlugInController);
static TMPlugInController* SharedInstance;
static NSInteger const kPlugInAPIVersion = 2;
static NSString* const kUserDefaultsDisabledPlugInsKey = @"disabledPlugIns";
@interface TMPlugInController ()
@property (nonatomic) NSMutableDictionary* loadedPlugIns;
@@ -33,6 +34,13 @@ static id CreateInstanceOfPlugInClass (Class cl, TMPlugInController* controller)
return SharedInstance ?: [TMPlugInController new];
}
+ (void)initialize
{
[[NSUserDefaults standardUserDefaults] registerDefaults:@{
kUserDefaultsDisabledPlugInsKey : @[ @"io.emmet.EmmetTextmate" ]
}];
}
- (id)init
{
if(SharedInstance)
@@ -58,6 +66,10 @@ static id CreateInstanceOfPlugInClass (Class cl, TMPlugInController* controller)
NSString* identifier = [bundle objectForInfoDictionaryKey:@"CFBundleIdentifier"];
NSString* name = [bundle objectForInfoDictionaryKey:@"CFBundleName"];
NSArray* blacklist = [[NSUserDefaults standardUserDefaults] arrayForKey:kUserDefaultsDisabledPlugInsKey];
if([blacklist containsObject:identifier])
return;
if(![self.loadedPlugIns objectForKey:identifier])
{
if([[bundle objectForInfoDictionaryKey:@"TMPlugInAPIVersion"] intValue] == kPlugInAPIVersion)