github/textmate
1
1
Fork 0
mirror of https://github.com/textmate/textmate.git synced 2026-04-28 03:00:34 -04:00
Code Issues Packages Projects Releases Wiki Activity

Update backup file atomically and verify that writing succeeded

Browse Source
This commit is contained in:
Allan Odgaard
2016-06-23 09:46:11 +02:00
parent 1f3ea40516
commit 994d60120f
1 changed files with 8 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
Frameworks/document/src/OakDocument.mm
View File

@@ -14,6 +14,7 @@
#import <text/newlines.h>
#import <text/utf8.h>
#import <io/entries.h>
#import <io/intermediate.h>
#import <file/type.h>
#import <file/open.h>
#import <file/save.h>
@@ -513,16 +514,20 @@ private:
if(!_backupPath)
self.backupPath = [self createAndReturnBackupPath];
int fd = open([_backupPath fileSystemRepresentation], O_CREAT|O_TRUNC|O_WRONLY|O_CLOEXEC, S_IRUSR|S_IWUSR|S_IRGRP|S_IWGRP|S_IROTH);
path::intermediate_t dest(to_s(self.backupPath));
int fd = open(dest, O_CREAT|O_TRUNC|O_WRONLY|O_CLOEXEC, S_IRUSR|S_IWUSR|S_IRGRP|S_IWGRP|S_IROTH);
if(fd == -1)
return NO;
_buffer->visit_data([fd](char const* bytes, size_t offset, size_t len, bool*){
write(fd, bytes, len);
bool error = _buffer->visit_data([fd](char const* bytes, size_t offset, size_t len, bool* stop){
*stop = write(fd, bytes, len) != len;
});
close(fd);
if(error || !dest.commit())
return unlink(dest), NO;
auto attr = [self extendedAttributeds];
attr["com.macromates.backup.path"] = to_s(_path);