github/textmate
1
1
Fork 0
mirror of https://github.com/textmate/textmate.git synced 2026-01-20 20:27:59 -05:00
Code Issues Packages Projects Releases Wiki Activity

Failing to set/remove extended attributes is no longer an error

Browse Source 
Workaround for osxfuse/osxfuse#85 (and possibly other file systems).
This commit is contained in:
Allan Odgaard
2013-05-26 10:22:54 +08:00
parent f8d71729fe
commit ef6082006d
1 changed files with 9 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files

21
Frameworks/io/src/path.cc
View File

@@ -844,22 +844,19 @@ namespace path
res = true;
iterate(pair, attributes)
{
bool removeAttr = pair->second == NULL_STR;
int rc = 0;
if(removeAttr)
if(pair->second == NULL_STR)
rc = fremovexattr(fd, pair->first.c_str(), 0);
else rc = fsetxattr(fd, pair->first.c_str(), pair->second.data(), pair->second.size(), 0, 0);
if(rc != 0 && removeAttr && errno == ENOATTR)
rc = 0;
else if(rc != 0 && removeAttr && errno == EINVAL) // We get this from AFP when removing a non-existing attribute
rc = 0;
else if(rc != 0 && !removeAttr && errno == ENOENT) // We get this from Samba saving to ext4 via virtual machine
rc = 0;
else if(rc != 0)
perror((removeAttr ? text::format("fremovexattr(%d, \"%s\")", fd, pair->first.c_str()) : text::format("fsetxattr(%d, %s, \"%s\")", fd, pair->first.c_str(), pair->second.c_str())).c_str());
res = res && rc == 0;
if(rc != 0 && errno != ENOTSUP && errno != ENOATTR)
{
// We only log the error since:
// fremovexattr() on AFP for non-existing attributes gives us EINVAL
// fsetxattr() on Samba saving to ext4 via virtual machine gives us ENOENT
// sshfs with ‘-o noappledouble’ will return ENOATTR or EPERM
perror((pair->second == NULL_STR ? text::format("fremovexattr(%d, \"%s\")", fd, pair->first.c_str()) : text::format("fsetxattr(%d, %s, \"%s\")", fd, pair->first.c_str(), pair->second.c_str())).c_str());
}
}
close(fd);
}