Commit Graph

1323 Commits

Author SHA1 Message Date
Allan Odgaard
1e970fad97 Select table view row before initiating the field editor
If we don’t ensure the row is selected then tab (from the cell with the field editor) will not advance to the row’s next column.
2013-06-24 09:02:14 +07:00
Allan Odgaard
306fc7406f Update syntax to use a dictionary literal (Objective-C 2) 2013-06-23 22:53:22 +07:00
Allan Odgaard
9638e4b70c Allow setting arbitrary activation strings for menu items
The implementation is presently geared toward only setting various activation strings, as unsetting e.g. a key equivalent won’t restore a potential (previously set) tab trigger etc.
2013-06-23 11:23:42 +07:00
Allan Odgaard
44ce84f79c Support setting menu item’s modified state to NO 2013-06-23 11:23:42 +07:00
Allan Odgaard
5c4a2025a3 Add menu item to toggle column selection
The motivation for this is mainly to make the ⌥ shortcut visible in the UI, which presently, it is not, as we need to “hack” the menu item to show it.
2013-06-23 11:23:42 +07:00
Allan Odgaard
0c26060f1c Find dialog now responds to findAllInSelection:
This is the action method sent by the Edit → Find → Find All (⌥⌘F) menu item, and is now treated as an alias to the existing findAll: action method (that the Find All button in the find dialog sends).
2013-06-23 11:23:42 +07:00
Allan Odgaard
ea2cf8d875 Add CR to default trim character set 2013-06-22 21:02:45 +07:00
Allan Odgaard
10c212cbd6 Improve error dialog when failing to add license 2013-06-22 21:02:45 +07:00
Allan Odgaard
f43414ae54 Don’t use kSecAttrCreator with keychain API
The creator code is obsolete and doesn’t serve much of a purpose, as we already mention TextMate in the service name.

When updating a keychain item we leave out kSecAttrLabel and kSecAttrComment, which may fix issue #1029.
2013-06-22 21:02:45 +07:00
Allan Odgaard
241d105dc9 Skip loading Bundles → TextMate → Update Notification (⌘Q)
The bundle item is causing ⌘Q to act subtlety different (issue #1031) but as we still see a lot of users on old versions, the item is still valuable to keep around.
2013-06-22 21:02:45 +07:00
Allan Odgaard
ffae9da1d3 Only skip setting search folder for ⇧⌘F if already “owner”
The user may use ⇧⌘F either to bring existing results to front, or to start a new folder search for a potential different project.

If the dialog is not visible, we always initialize it fully. If already visible, we previously would not setup search folder since the current search folder might have been manually set by the user, which we do not want to overwrite.
2013-06-21 11:49:16 +07:00
Allan Odgaard
d22f7163c5 Ensure tab size read from .tm_properties is larger than zero
Closes #1028.
2013-06-21 01:43:42 +07:00
Allan Odgaard
6e5181210e Don’t let up/down abort multiple carets when all on same line
In this situation, abort the multiple carets by moving them all to the beginning or end of the current line (⌘←/⌘→ or ⌃A/⌃E).
2013-06-21 01:43:42 +07:00
Allan Odgaard
b835952823 Don’t pre-select (find) “in selection” by default
Previously this would be selected if the user had a multi-line selection and was pressing ⌘F. The old behavior can be restored using:

    defaults write findInSelectionByDefault -bool YES
2013-06-21 01:43:42 +07:00
Allan Odgaard
6b64f38053 Update dialog text 2013-06-19 11:55:32 +07:00
Allan Odgaard
1f893b5543 Stopping long lived TextMate.system() executions would crash 2013-06-19 11:55:32 +07:00
Allan Odgaard
f01a9d9a71 Remove keychain argument
The new (non-deprecated) API no longer allows us to target a specific keychain for add, remove, and lookup.

This wasn’t used by TextMate itself but was extremely useful for writing tests against the API (using temporary keychains).
2013-06-19 11:55:32 +07:00
Allan Odgaard
c3f79e2e05 Improve code to find license key 2013-06-18 13:43:18 +07:00
Allan Odgaard
570afce039 Reformat and justify was broken for multi-paragraph input
Fixes #1021.
2013-06-18 11:44:47 +07:00
Allan Odgaard
6c6aadc38b Make labels right-aligned by default 2013-06-17 12:36:27 +07:00
Allan Odgaard
c04eb1cd2a Fix exception when finding all in untitled documents
Untitled documents have no path, so we were creating a dictionary with a nil object. The path isn’t actually used (we go via the identifier) so removing the potential path from the dictionary avoids the problem.
2013-06-16 17:44:34 +07:00
Allan Odgaard
d71f29074e Use symbolic name for REST API URL 2013-06-16 17:44:34 +07:00
Allan Odgaard
49a424438c Revert "Apply injections from child rules without match pattern"
This reverts commit fc419f5332.
2013-06-15 23:08:11 +07:00
Allan Odgaard
4586bc2024 Fix async mode for TextMate.system (JS bridge)
In commit 03aea09148 we switched to properties for the mapped instance variables which meant they all got an underscore prefix and wasn’t seen from JavaScript.
2013-06-15 16:13:22 +07:00
Jakub Suder
ac9f5e5d8d Don't add files from find window to recent list 2013-06-15 16:13:22 +07:00
Joachim Mårtensson
fc419f5332 Apply injections from child rules without match pattern
This is useful when including a grammar and its injections needs to be applied.
2013-06-15 16:06:43 +07:00
Allan Odgaard
3db66d1a05 Support “Find Previous” in macros 2013-06-15 16:06:43 +07:00
Allan Odgaard
2af39bc935 Fix retain cycle
Fixes #1009.
2013-06-15 16:06:38 +07:00
Allan Odgaard
6ee93431bc Avoid passing -1 (as fd) to kevent() and close()
Observing paths will normally fail when opening files that only privileged users can read.
2013-06-15 16:05:48 +07:00
Allan Odgaard
ed9396ed84 Workaround for a wrong bundle index
This is work in progress, the reason why the situation arise has not yet been found and there are likely other ways in which the index can be wrong/stale (based on user reports like issue #998).
2013-06-15 16:05:48 +07:00
Allan Odgaard
9dd653a3e7 Ignore non-UTF-8 completion command results 2013-05-26 17:27:44 +08:00
Allan Odgaard
6a9b0374ed Sanitize non-UTF-8 command output
We now convert the output to a hex-dump incase it is not valid UTF-8. Ideally we would present the user with a dialog, but for now a hex-dump will do and prevents a potential crash.
2013-05-26 17:26:06 +08:00
Allan Odgaard
2df18d80b0 The bundle’s info.plist can now specify requiredCommands
This will apply to all items in the bundle so it’s questionable if it’s something we want to use, as it would not allow the user to run a “Help” command from the bundle without first setting up the requirements. OTOH setting requiredCommands for all but a few items in e.g. the Git bundle seems redundant — perhaps items should be able to eclipse keys from the bundle’s info.plist to effectively unset the requiredCommands for a select few items.
2013-05-26 15:40:23 +08:00
Allan Odgaard
0594b2c83e Fix issue with requirements that had no locations array
The variable provided was ignored meaning that it would only work correctly if the executable was found via PATH, and if it wasn’t found, the error message would display a bogus character as the variable that the user should set.
2013-05-26 15:34:54 +08:00
Allan Odgaard
8017428011 If deleting old version fails then move it to trash
We also add a time suffix to the old version so that if we fail to remove it, the user will not get (another) error when retrying the update.

Presumably fixes #991.
2013-05-26 13:32:46 +08:00
Allan Odgaard
05bb8d3304 Log malformed UUID incase of error
This is instead of showing “no valid UUID” (which could mean either missing or malformed).
2013-05-26 13:16:22 +08:00
Allan Odgaard
ef6082006d Failing to set/remove extended attributes is no longer an error
Workaround for osxfuse/osxfuse#85 (and possibly other file systems).
2013-05-26 10:24:35 +08:00
Allan Odgaard
f8d71729fe Add SOCKS proxy support
This is for updating bundles and itself plus posting crash reports.

It now also ignores unknown proxy types.
2013-05-26 10:24:35 +08:00
Allan Odgaard
ee32b97ea0 Fix error checks for key chain lookups 2013-05-26 10:24:35 +08:00
Allan Odgaard
e3c44d78db Add missing variables for export commands
Fixes #990.
2013-05-18 08:51:23 +08:00
Allan Odgaard
e0523bb926 Improve encapsulation 2013-05-16 21:36:49 +07:00
Allan Odgaard
eb6b0541b2 Move reader_t and process_t to command framework
These are now only used by the command framework and should soon be retired.
2013-05-16 21:36:49 +07:00
Allan Odgaard
ffb900deb1 Add missing include 2013-05-16 21:36:49 +07:00
Allan Odgaard
b747dc662b Delete cf::run_loop assignment/copy constructor
They were previously declared private, as they weren’t implemented and we can’t use generated versions.
2013-05-16 21:36:49 +07:00
Allan Odgaard
03aea09148 Use io::spawn instead of oak::command_t for TextMate.system
Like with snippets, we no longer support executing a shebang-script given “inline” — though this was never a documented feature and I am not aware of anything having made use of it.
2013-05-16 21:36:49 +07:00
Allan Odgaard
b6fce5fe30 Check if command result is valid UTF-8
This was previously implicit by using oak::command_t
2013-05-16 21:36:43 +07:00
Allan Odgaard
28ab42bff9 Remove oak::command_t 2013-05-16 21:36:07 +07:00
Allan Odgaard
714779d89b Use io::spawn instead of oak::command_t with snippets
Since we now run the shell code directly (via ‘/bin/sh -c «command»’) we no longer source ‘TM_SUPPORT_PATH/lib/bash_init.sh’.

I don’t think any code embedded in snippets rely on things setup by this file, but if they do, I’d prefer we update the snippets to explicitly source the file.
2013-05-16 21:36:00 +07:00
Allan Odgaard
a2e7de29e7 Add missing include 2013-05-16 21:29:59 +07:00
Allan Odgaard
7dbb02652f Use io::spawn instead of oak::command_t for /usr/bin/diff3 2013-05-16 21:29:35 +07:00