Commit Graph

2673 Commits

Author SHA1 Message Date
Allan Odgaard
754f1a1a4f Checkin release notes v2.0-alpha.9551 2014-07-12 00:07:07 +02:00
Allan Odgaard
e4d92941ee Update QuickLook generator to use the new bundle item index
This should improve startup time significantly, since it would previously have to re-index all the bundle items.
2014-07-11 14:11:03 +02:00
Allan Odgaard
1d57e46493 Let OakChooser decide when to render table view as having focus 2014-07-10 23:43:20 +02:00
Allan Odgaard
922f9c13af Add ‘drawAsHighlighted’ public table view property
This allows factoring out the decision of when to draw as highlighted.
2014-07-10 23:43:20 +02:00
Allan Odgaard
81e47090cc Call recalculateKeyViewLoop after current event loop iteration 2014-07-10 23:43:20 +02:00
Allan Odgaard
36cfb177a5 Leverage the default implementation of bindings 2014-07-10 23:43:20 +02:00
Allan Odgaard
4f19370458 Let key equivalent field pass unused key down events to super 2014-07-10 23:43:20 +02:00
Allan Odgaard
01fe210895 Key equivalent field no longer activate recording on return
This is to allow using the control in windows with a “default” button (which gets the return key).
2014-07-10 23:43:20 +02:00
Allan Odgaard
bfb33e6144 Let bundle item chooser’s ranker remember user corrections 2014-07-09 22:14:41 +02:00
Allan Odgaard
d4ca90724a OakChooser: Reselect first item when filter string is changed 2014-07-09 22:14:40 +02:00
Allan Odgaard
d16f5216c2 Ensure we “search by title” when opening the bundle item chooser 2014-07-09 17:25:16 +02:00
Allan Odgaard
6a8cd7e1ac Only set search field as first responder if it’s in the window
For example the bundle item chooser may swap it out with a key equivalent view.
2014-07-09 17:25:16 +02:00
Allan Odgaard
f94b70cd0d Move files on disk 2014-07-09 17:25:16 +02:00
Allan Odgaard
d821793182 Remove old filter list code 2014-07-09 17:25:16 +02:00
Allan Odgaard
c57dd931e1 Let the bundle item chooser inherit from OakChooser 2014-07-09 17:25:16 +02:00
Allan Odgaard
420f70cf93 Make OakChooser’s cancel: method public API 2014-07-09 17:03:45 +02:00
Allan Odgaard
96b8b00df7 Implement intrinsicContentSize for OakKeyEquivalentView
This will allow it to be used with constraint based layouts.
2014-07-09 17:03:45 +02:00
Allan Odgaard
d85b4e280b Reference MGScopeBar class to prevent linker from stripping it
We instantiate the class in the xib file, so the linker does not know that we actually need it.

Currently the filter list framework use MGScopeBar, which is why this issue is not an actual problem (yet).
2014-07-09 17:03:44 +02:00
Allan Odgaard
565d0b915e Limit QuickLook preview to the first 20 KiB of the file
This was suggested in pull request #1226. Ideally we would make the limit flexible, e.g. see how much we can generate in 1-2 seconds, but that is a non-trivial change, so the fixed limit will do for now, and while truncated data is suboptimal, it’s better than being killed due to QL manager’s timeout.
2014-07-08 17:49:42 +02:00
Allan Odgaard
5715ebf754 Allow a limit to be passed to file::read_utf8
Currently the API does not allow the caller to know that the data was actually truncated.
2014-07-08 17:49:42 +02:00
Allan Odgaard
f2387d8d23 Workaround for ruby 2.0 warning (shadowing outer local variable) 2014-07-06 22:42:00 +02:00
Allan Odgaard
a7d45aa573 Checkin release notes v2.0-alpha.9549 2014-07-06 22:35:47 +02:00
Allan Odgaard
bef21962c8 Changing font (Show Fonts) would fail when current font was ‘nil’ 2014-07-06 22:16:14 +02:00
Allan Odgaard
5af1ec23ca Enable ligatures
If you are using the Mensch font then you need to update to version 2 to avoid problems with the ligature for ‘fi’: http://robey.lag.net/2012/08/22/mensch-2.html
2014-07-06 14:50:11 +02:00
Ronald Wampler
cc64b1e24f Add search field to Bundle preference pane 2014-07-06 11:34:34 +02:00
Ronald Wampler
8f50838b25 Use "System Small" font in VariablesPreference table
Since variable strings can be very long and we reduced the font size in the bundle table, let's be consistent and use a smaller font size here too.
2014-07-06 11:34:33 +02:00
Ronald Wampler
a2690f9418 Save VariablesPreferences.xib with Xcode 5.1.1 (5B1008) 2014-07-06 11:34:33 +02:00
Ronald Wampler
9812748a07 Use "System Small" fonts in BundlePreference table
By using a smaller font size in the bundle table we can show more of the bundle description. Also, it minimizes the amount of resizing of the pane we have to do to see the entire description string for most of the bundles.
2014-07-06 11:34:33 +02:00
Ronald Wampler
360443682d Save BundlePreferences.xib with Xcode 5.1.1 (5B1008) 2014-07-06 11:34:33 +02:00
Allan Odgaard
f370408910 File browser actions were disabled for broken symbolic links
This made it impossible to move a broken symbolic link to trash.
2014-07-05 21:33:29 +02:00
Allan Odgaard
2c8a020d39 Implement selectNext/PreviousTab in FindWindowController 2014-07-05 21:33:29 +02:00
Allan Odgaard
42a64270bc Remove undesired whitespace 2014-07-05 21:33:29 +02:00
Allan Odgaard
1c742b0559 The cap’n proto rule should not be a generator rule
Also change 1 → true for another use of generator (for consistency).
2014-07-05 21:33:29 +02:00
Boris Dušek
eea001f5d5 Fix build error on clear rebuild
When rebuilding textmate from scratch:

git clean -xffd; git reset --hard HEAD; rm -rf ~/build/TextMate/; ./configure; ninja

This error appears:

Frameworks/OakAppKit/src/OakTabBarView.mm:7:9: fatal error: 'OakAppKit/OakFileIconImage.h' file not found

After one issues "ninja" again, textmate continues building fine.

I guess this might be because perhaps OakAppKit's headers are being copied
to the build include directory (~/build/TextMate/include) in parallel when
building OakTabBarView.mm. No matter what actually is the case, this patch
fixes building during clean build.
2014-06-29 21:40:33 +02:00
Boris Dušek
320c3ec23a Add contributor emails
In other words, I don't like build warnings of any kind :-)
And they deserve credit for their contributions.
2014-06-29 18:21:50 +02:00
Boris Dušek
900ee1f523 Use NSAccessibilitySharedFocusElementsAttribute in OakChooser
This new 10.10 API allows one to mark, for some UI element, a set of UI
elements to track selection. VoiceOver (and other accessibility clients)
will then track and announce selection (cursor) changes not only in the
currently focused element, but also for all elements contained in its
"shared focus elements" array. This is a perfect fit for search field
with a table of results. In fact it is used for new 10.10 Spotlight -
its search field's shared focus element is the table containing the results.

As NSAccessibilitySharedFocusElementsAttribute is available only in the 10.10 SDK,
so make a way to use its value with previous SDKs (with which TextMate
is currently compiled).

We also retain the kind-of-hacky solution for pre-10.10 OSes introduced in
and instead use NSAccessibilitySharedFocusElementsAttribute.

This code was tested in all 6 fields of a 3×2 matrix:
* compiled with 10.8, 10.9 and 10.10 SDK
* run on 10.9 and 10.10 (DP2)

For user, this means more standard behavior (says the same "completion selected"
thing as with Spotlight) and a bit more correctness (no extra space
before beginning / after end of search field on braille display).

For developer, this means once we stop supporting 10.9, we will be ready to
drop a lot of code which, while serving us well to make the choosers more
user friendly on pre-10.10, will no longer be needed.
2014-06-29 11:01:58 +02:00
Allan Odgaard
a76b6eae9c Respond to next/previous tab actions in file/favorites chooser
This makes it possible to use ⌘{ and ⌘} to move between the source lists, which is consistent with other windows with multiple sources (like the Preferences and About windows).

Closes #1236.
2014-06-28 18:22:02 +02:00
Adam Strzelecki
59a699c078 Tune tab label inset shadow
Now it matches more way other OSX elements are inset both on Retina and
non-Retina displays.
2014-06-28 18:02:00 +02:00
Adam Strzelecki
56cfc1a3e0 Reworked OakTabBarView layout plist
Now it supports properly Retina using Cocoa rounded corner rendering instead
pixel patches. All colors are now references by name.
2014-06-28 18:02:00 +02:00
Adam Strzelecki
2ef711ad97 Define color names for OakTabBarView
This lets layout file refer to color names instead hardcoding color hex values.

Also colors referenced by name can return different values depending on OSX
version, which will in future solve problems with OSX 10.10 Yosemite L&F.
2014-06-28 17:59:27 +02:00
Adam Strzelecki
53943e4409 Extend layer_t with cornerRadius & borderColor
This allows drawing rounded layers with border in resolution independent
manner. Also it reduces number of layers needed to certain UI elements.
2014-06-28 17:56:50 +02:00
Boris Dušek
72bb6e6eb6 Fix enum/int conversion error with 10.10 SDK
10.10 SDK makes NSLineBreakMode into a proper NS_ENUM enum (in 10.9 SDK it was
a plain typedef for NSUInteger with some integer NSLineBreak* values
conveniently available for it in an anonymous enum).

Nevertheless, attr_string code should have always used NSLineBreakMode instead
of NSUInteger (unless I am missing something like values in style::line_break::mode
that do not correspond to the enum), so this commit makes it so and
thus also fixes building with 10.10 SDK.
2014-06-28 17:54:16 +02:00
Allan Odgaard
2427464f60 Disable tar’s support for extended attributes and resource forks
A problem has been reported where tar will freeze while extracting the default bundles archive to a networked Application Support folder.

From the bug report (Michael Kuron):

File servers tested: SMB on OS X 10.9.3, AFP on OS X 10.9.3, AFP on OS X 10.6.8, SMB on Windows 2008 R2.

Multiple machines tested.

Using ‘gnutar’ from MacPorts does not show the problem.

Setting ‘COPYFILE_DISABLE=1’ before running tar does not show the problem (the workaround used in this commit).
2014-06-28 17:42:23 +02:00
Allan Odgaard
9f10bd56c7 Set ‘depfile = $out.d’ (may require ninja 1.5 for proper escapes) 2014-06-28 17:42:23 +02:00
Allan Odgaard
d20acae00b Update onigmo submodule 2014-06-28 17:42:23 +02:00
Allan Odgaard
e78764a89e Let threaded syntax highlight parsing for ng::buffer_t be opt-in 2014-06-28 17:42:23 +02:00
Allan Odgaard
0ae6782d80 Remove support for custom views in OakControl 2014-06-28 17:42:23 +02:00
Allan Odgaard
cb775822aa Use current ruby (rather than 1.8) for a few helper scripts 2014-06-28 17:42:23 +02:00
Allan Odgaard
c1552d56bc Include some context in error message 2014-06-28 17:42:23 +02:00
Allan Odgaard
7675aeb4ec Changing case would truncate the result if it grew in size 2014-06-28 17:42:22 +02:00