Allan Odgaard
fdc20c7b15
Let OakDocument use OakSourceControlManager
2016-09-21 22:20:40 +02:00
Allan Odgaard
0c8fa250b9
WIP: Add OakSourceControlManager
2016-09-21 22:20:39 +02:00
Allan Odgaard
7713496749
Searching “other” folder would still use project folder
2016-09-21 22:20:39 +02:00
Allan Odgaard
ba7ef25d66
No need for document editor to observe content did change notification
2016-09-21 22:20:39 +02:00
Allan Odgaard
b9e937283a
Checkin release notes for 2.0-beta.12.13
2016-09-21 22:20:39 +02:00
Allan Odgaard
bedf79aff3
Fix issue when loading the same document simultaneously
...
This could happen when restoring a session where the same document was open in multiple windows.
2016-09-21 20:39:42 +02:00
Allan Odgaard
5de8e6fd58
Sanitize selection if buffer is changed outside change group
2016-09-21 20:39:42 +02:00
Allan Odgaard
981b7a6d8f
Move undo grouping to OakDocumentEditor
2016-09-21 20:39:42 +02:00
Allan Odgaard
aa2e86a015
Fix crash when clearing document that was never set
...
This would show when opening a file that prompted the user for input (e.g. unknown encoding) and then selecting cancel.
2016-09-21 20:39:42 +02:00
Allan Odgaard
b8c2b8889c
Going to SCM status for non-repository with spaces would throw exception
2016-09-21 20:39:42 +02:00
Allan Odgaard
c0b4e7319c
Only regular expression searches use file size limit for non-open files
2016-09-21 20:39:42 +02:00
Allan Odgaard
017f4a3ba1
Check if path is a folder before calling path::entries()
...
This is just to suppress a warning from path::entries().
2016-09-21 20:39:42 +02:00
Allan Odgaard
2f5b8559fb
Only add folders to find dialog’s Recent Places
...
Now that documents selected in the file browser can be searched, we can end up with a document path in the ‘otherFolder’ property.
This would happen by selecting a document in the file browser, opening the find dialog, and then selecting this document in the pop-up, as it is listed in the pop-up with a menu item tag of “FFSearchTargetOther”.
2016-09-21 20:39:42 +02:00
Allan Odgaard
74a2c9e801
Handle potential exception when asking NSFileHandle for fileDescriptor
...
Based on crash logs this occasionally throws an “Operation not permitted” or “unknown error” exception, so now we catch these.
2016-09-21 20:39:41 +02:00
Allan Odgaard
6db5ac8de3
Rename performCloseOtherTabs: to performCloseOtherTabsXYZ:
...
Starting with macOS 10.12 the NSWindow class will swallow this method, even if we set NSWindow.allowsAutomaticWindowTabbing = NO.
2016-09-21 20:39:41 +02:00
Allan Odgaard
ad01eb1ac6
Use stringArrayForKey: where appropriate
2016-09-21 20:39:41 +02:00
Allan Odgaard
808563c934
Remove unnecessary overloads of requiresConstraintBasedLayout
...
It should only be necessary to overload this method (to return YES) when the system is unable to figure out by itself, that it should enable constraint-based layout for the window in which the view is placed.
2016-09-21 20:39:41 +02:00
Ronald Wampler
f38eaa5315
Let OakPopOutAnimation set the color in the image to black
...
This makes the text easier to see against the yellow background.
2016-09-21 08:11:48 +02:00
Allan Odgaard
2ffbfe02a5
Remove find::kSearchOpenFiles constant
2016-09-20 20:04:33 +02:00
Allan Odgaard
1087a68f44
Add “File Browser Items” as find dialog search target
2016-09-20 20:04:19 +02:00
Allan Odgaard
4dc3de163e
Guard against infinite loop
2016-09-20 20:03:32 +02:00
Allan Odgaard
9d97662b89
Let FFDocumentSearch accept an array of paths
2016-09-20 20:02:08 +02:00
Allan Odgaard
315735a13a
Add helper function for common ancestor
2016-09-20 19:55:16 +02:00
Allan Odgaard
c04430ebe4
FFDocumentSearch no longer search current document or open files
2016-09-20 18:20:36 +02:00
Allan Odgaard
d7f4b5bfb6
Use ‘enabled2’ in binding since we already bind to ‘enabled’
...
Before the Replace & Find button was enabled for folder searches.
2016-09-20 18:19:20 +02:00
Allan Odgaard
dbee4704cc
Clear the countOfMatches properties after unbinding
...
The Replace All button’s enabled state is based on count of matches (via bindings), so unbinding would leave it possibly enabled when it should have been disabled.
2016-09-20 18:17:37 +02:00
Allan Odgaard
2e61de9f7d
Do not show missing items under Recent Places in folder search
2016-09-20 18:17:06 +02:00
Allan Odgaard
e20bb55d18
Use home folder as fallback in FFFolderMenu
...
This is to avoid an exception when the code is used with menu items that have no represented object (which it normally wouldn’t in shipping code, but it seems it should be supported nonetheless).
2016-09-20 18:16:41 +02:00
Allan Odgaard
53a6708c08
Add API to search for documents at multiple locations
2016-09-20 18:15:20 +02:00
Allan Odgaard
330695a775
Import Find.h instead of redeclaring some of its symbols
2016-09-20 18:14:07 +02:00
Allan Odgaard
27c34c8991
Add missing key bindings for Back and Forward items in File Browser menu
...
This broke when we changed the menu name from Go to File Browser.
2016-09-20 18:13:46 +02:00
Allan Odgaard
c722c0266d
Include spelling languages in the bundle item chooser
2016-09-20 18:13:24 +02:00
Allan Odgaard
e3874bcecb
Only set menu item image when required
...
The system can be updating the menu only to resolve a key equivalent, hence the image is not required. The document icon can be a little expensive to create because of the SCM badge. This would be noticeable when doing a folder search with hundres or thousands of results and then pressing ⌘1, here it would previously need to create all the document icons before responding to the key.
2016-09-20 18:12:13 +02:00
Allan Odgaard
1fad00682a
Do not include final “newline” when creating image from selection
...
Previously searching for something with a trailing newline would have the pop-out animation (image) include an extra empty line.
An issue is when only searching for a newline, currently this results in an empty image, so we need to special-case that.
2016-09-20 18:11:23 +02:00
Allan Odgaard
10f88212e4
Use setDynamicTitle: for menu items with dynamic title
...
See previous commit for details.
2016-09-20 10:03:45 +02:00
Allan Odgaard
60441f69e4
Add NSMenuItem category method to be used for dynamic titles
...
When a menu item has a custom app shortcut it is necessary to keep the original title as we would otherwise lose the custom app shortcut defined by the user (using the original title).
2016-09-20 10:03:45 +02:00
Allan Odgaard
ad883f7211
fixup! Only set table view’s row height during sizeToFit
...
Incase of no choices we would set a row height of zero which is not allowed.
2016-09-19 13:12:53 +02:00
Allan Odgaard
7bddb114bc
Only obtain SCM info when file chooser is showing Uncommitted Changes
2016-09-19 12:57:50 +02:00
Allan Odgaard
6f4eddf88c
Avoid wrapper objects in FileChooser
2016-09-19 12:56:03 +02:00
Allan Odgaard
7cc017f343
Harmonize all implementations of sharedInstance
2016-09-19 12:54:19 +02:00
Allan Odgaard
fe831c2fc2
Declare NSMenuDelegate protocol conformance for OakOpenWithMenu
2016-09-19 12:52:46 +02:00
Allan Odgaard
41bf68e636
Remove FileChooser’s openDocuments property
...
List of open documents are (now) obtained from OakDocumentController.
2016-09-19 12:51:36 +02:00
Allan Odgaard
9397aed6ef
Make document icon and close button update in FileChooser
2016-09-19 12:51:19 +02:00
Allan Odgaard
44d037da65
Use OakDocument’s icon for Select Tab menu items
2016-09-19 12:50:04 +02:00
Allan Odgaard
297cfa1726
Remove unused OakFileIconImage.h includes
2016-09-19 12:49:03 +02:00
Allan Odgaard
636b0fe5f8
Use OakDocument for icon and close button in Open Quickly
...
Currently these do not update when document properties change.
2016-09-19 12:48:46 +02:00
Allan Odgaard
238ee0cc4f
Load potential backup before operating on non-loaded documents
2016-09-19 12:48:12 +02:00
Allan Odgaard
9b75a50520
Fix issue where aborting a file rename did not restore display name
2016-09-19 12:46:54 +02:00
Allan Odgaard
7a69bf3b28
Ensure untitled documents are in the LRU list after session restore
2016-09-19 12:46:07 +02:00
Allan Odgaard
de83ebf06e
Introduce OakCreateCloseButton API
2016-09-19 09:01:35 +02:00
