Commit Graph

5154 Commits

Author SHA1 Message Date
Allan Odgaard
88e5f1cd3c Checkin release notes for 2.0-rc.30 v2.0-rc.30 2019-08-21 11:56:45 +02:00
Allan Odgaard
306d46ec71 Add even more debug output for when TextMate is activated via mate 2019-08-21 11:51:26 +02:00
Allan Odgaard
5e96d41a3d Look for numeric prefix when duplicating a file and increase it if found
For example if we have a directory with files named 001-foo.txt, 002-bar.txt, and 003-fud.txt, duplicating one of these will result in the duplicate starting with 004.

Also improve support for finding dates in file names being duplicated. Previously we only looked for YYYY-MM-DD but now we also support YYYY_MM_DD and YYYYMMDD. If a date is found in the file name being duplicated, it is replaced with the current date in the duplicate.
2019-08-08 21:37:42 +02:00
Allan Odgaard
f33ba968a8 Don’t ignore result from writeObjects: 2019-08-02 21:07:04 +02:00
Allan Odgaard
454b1b4644 Use availableTypeFromArray: instead of checking types array directly 2019-08-02 21:06:21 +02:00
Allan Odgaard
774e66c009 Ignore ‘types’ in implementation of writeSelectionToPasteboard:types:
The issue is that the types requested may be ‘NSStringPboardType’ but that symbol is deprecated (starting with 10.14), yet the replacement (‘NSPasteboardTypeString’) is not string-equivalent, therefore our simple string comparison would fail.

This effectively broke services starting with 1ef78b3af7 (where we adopted the new symbols).

Implementation of validRequestorForSendType:returnType: does not appear to be a problem, as that method is called with both ‘NSStringPboardType’ and ‘NSPasteboardTypeString’.

Also switched to using NSPasteboard’s writeObjects: so we don’t have to explicitly deal with the type of the data we write to the pasteboard (presumably NSString will declare it using both the old and new type).
2019-08-02 21:03:39 +02:00
Allan Odgaard
16c4239393 Do not pass builddir/ninja_required_version as variables to generator
This is to avoid redundancy as ninja_required_version is hardcoded in the generator script and builddir is already passed via the --build-directory/-C option (and explicitly exported as a variable in the generator script).
2019-08-01 10:49:55 +02:00
Allan Odgaard
328c5bdca7 Revert "No need to explicitly set builddir as it’s already among our variables"
There may be situations in which the user already have (generated) ninja build files which do not match our assertions.

This reverts commit b42cbb1f7e.
2019-08-01 10:46:05 +02:00
Allan Odgaard
e59f9fcfa6 Remove oak::cap from algorithm.h 2019-08-01 10:28:35 +02:00
Allan Odgaard
8f685ff25c Use std::clamp instead of oak::cap (C++17) 2019-08-01 10:23:55 +02:00
Allan Odgaard
4c318529ab Build as C++20 (up from C++14)
The C++20 feature list has been frozen although clang (and libc++) doesn’t yet have full support and the clang option we are using is -std=c++2a to indicate that things may still change.
2019-08-01 10:17:51 +02:00
Allan Odgaard
253fc90448 Remove ‘requires’ member function since it clashes with a C++20 keyword
This member function was never called by anyone.
2019-08-01 10:17:20 +02:00
Allan Odgaard
acfee9901c Use ‘NSInteger’ for result of selectedRow (instead of legacy ‘int’ type) 2019-08-01 10:11:24 +02:00
Allan Odgaard
caefacb911 Add missing space (according to syntax style guide) 2019-08-01 10:05:58 +02:00
Allan Odgaard
e155e6810a Re-add target to (build and) run non-bundled executables 2019-08-01 10:02:55 +02:00
Allan Odgaard
75be599e48 Do not set any targets as default in the generated build file 2019-07-19 16:45:18 +02:00
Allan Odgaard
9c51080d15 Add «target»/tests to run all tests for «target» or its dependencies 2019-07-19 16:42:44 +02:00
Allan Odgaard
af91d39be5 Generate build rules for tests but do not depend on the tests passing 2019-07-16 20:27:21 +02:00
Allan Odgaard
2bc982dfd8 Refactor bin/gen_build 2019-07-16 20:24:07 +02:00
Allan Odgaard
77bc9f7a6f Remove test for localized folder names as it does not work (10.14)
I cannot find any information online about Apple dropping support for this, but I also cannot make it work, and it wouldn’t surprise me if they view localized folder names as a security problem.
2019-07-16 20:02:42 +02:00
Allan Odgaard
b42cbb1f7e No need to explicitly set builddir as it’s already among our variables 2019-07-16 19:42:29 +02:00
Allan Odgaard
4e6e765e5f Update CxxTest 2019-07-16 19:42:29 +02:00
Allan Odgaard
dae1103728 Update LINK declarations 2019-07-16 19:42:29 +02:00
Allan Odgaard
36f414dbea Add missing include in test file 2019-07-16 19:42:20 +02:00
Allan Odgaard
f21d570b73 Remove test for VOL_CAP_INT_EXCHANGEDATA
This is no longer supported (with APFS) so there is no reason to keep this code around.
2019-07-16 14:29:20 +02:00
Allan Odgaard
eb4e0bfcd0 Update tests to reflect how the code works
The “matching pair” move behavior was changed in 7f99c4cbc7
2019-07-16 14:27:28 +02:00
Allan Odgaard
f47a7b5f53 Code to bump date in filename is no longer a testable separate function 2019-07-16 14:24:07 +02:00
Allan Odgaard
c920035f99 Variables from ./configure are now in the “local” (bootstrap) build file
This seems like a logical separation, as the build directory now contains things 100% generated, whereas the “local” build file has variables that came from the original ./configure step and may be edited.
2019-07-16 12:05:11 +02:00
Allan Odgaard
608c53a423 Refactor bin/gen_build 2019-07-16 12:02:16 +02:00
Allan Odgaard
d8fcf27cb5 Fix test for whether or not we have default targets 2019-07-16 11:53:48 +02:00
Allan Odgaard
72bf77c2e5 Handle a failing ‘xcrun altool --notarization-info’ gracefully
We now write the captured output to stderr and retry after 10 seconds.
2019-07-16 09:18:43 +02:00
Allan Odgaard
c4cec82869 Checkin release notes for 2.0-rc.29 v2.0-rc.29 2019-07-16 08:35:13 +02:00
Allan Odgaard
eecfe6e619 Add more debug output for when TextMate is activated via mate
Related to 2ffc74ad8b
2019-07-16 08:33:05 +02:00
Allan Odgaard
ad74df7824 Include explanation in the log message for when a plug-in fails to load
Credit: https://lists.macromates.com/textmate/2019-July/041047.html
2019-07-15 21:41:30 +02:00
Allan Odgaard
b176bf8f9a Use number formatter for count in Find All / Replace All status text
The Find dialog was already using number formatters, but the tool tips shown in the text view (when doing searches or replacements without going through the find dialog) were not.

This makes a difference when the count is > 999, as it will then format the number with thousand separators.
2019-07-14 11:26:31 +02:00
Allan Odgaard
dfd5f85fb5 Remove unnecessary Info.plist file from Find framework 2019-07-14 10:59:30 +02:00
Allan Odgaard
63e82b9bc0 Drop localization support in Find dialog
This was unnecessary indirection as we don’t generally lookup strings for the UI (so TextMate is not actually localizable) and the catalog for the strings we did look up was actually out of date.
2019-07-14 10:57:27 +02:00
Allan Odgaard
6b3c8747e7 Remove unused localization strings 2019-07-14 10:46:31 +02:00
Allan Odgaard
a7542c7ea1 Retain current thread’s run loop 2019-07-13 11:43:24 +02:00
Allan Odgaard
f5d0f38cc7 Don’t update NSUSerDefaults in OakTabBarView’s initialize
The use of an animator proxy is causing the initialize method to be called during animation, and when registering user defaults in initialize, we may trigger key/value observers to be notified, which for this code can result in a crash in OS code with the message: “Trying to recursively lock an os_unfair_lock”.
2019-07-13 11:18:20 +02:00
Allan Odgaard
066e020265 Ensure temporary std::string stays in scope when using its data 2019-07-13 11:02:25 +02:00
Allan Odgaard
027038aaed Checkin release notes for 2.0-rc.28 v2.0-rc.28 2019-07-13 10:21:44 +02:00
Allan Odgaard
57c2e25af1 Update dialog plug-in (Rename symbols for the 10.14 SDK) 2019-07-13 10:20:09 +02:00
Allan Odgaard
2ffc74ad8b Add debug output when TextMate is activated via mate
Some users report a significant delay from executing mate until the TextMate window is brought to front.

The debug information can be extracted by running the following in a terminal:

    log show --predicate 'subsystem = "com.macromates.TextMate" && category = "BringToFront"'

Alternatively use `stream` instead of `log` to get a live stream of debug output.

See `man log` for options such as `--start date/time` (to limit the query to e.g. the last 10 minutes)
2019-07-13 10:20:09 +02:00
Allan Odgaard
72f4b7447e Do not hardcode code signing flags in bin/gen_build 2019-07-13 08:49:45 +02:00
Allan Odgaard
168915307d Assign small icon to sieve scripts (file browser etc.) 2019-07-13 08:23:06 +02:00
Allan Odgaard
087e0ce0a7 Import os/log.h when deployment target is macOS 10.12 or later 2019-07-13 08:22:00 +02:00
Allan Odgaard
ba60e7091d Use flat_map instead of map { … }.flatten 2019-07-10 20:32:40 +02:00
Allan Odgaard
be677cb0b4 Checkin release notes for 2.0-rc.27 v2.0-rc.27 2019-07-08 13:10:18 +02:00
Allan Odgaard
a9b5925f57 Saving a file would lose existing file permission flags 2019-07-08 13:07:28 +02:00