github/tinygrad
1
1
Fork 0
mirror of https://github.com/tinygrad/tinygrad.git synced 2026-04-29 03:00:14 -04:00
Code Issues Packages Projects Releases Wiki Activity

update test_assign (#15809)

Browse Source 
clean up old skips and update tests
This commit is contained in:
chenyu
2026-04-18 21:25:44 -04:00
committed by GitHub
parent 022d8c4a11
commit 5bdfd4883f
1 changed files with 5 additions and 14 deletions
Download Patch File Download Diff File Expand all files Collapse all files

19
test/unit/test_assign.py
View File

@@ -139,7 +139,6 @@ class TestAssign(unittest.TestCase):
self.assertNotEqual(a.item(), b.item())
def test_assign_changes_realized_alt(self): return self.test_assign_changes_alt(realize=True)
@unittest.skip("assign to contiguous shouldn't change the base buffer")
def test_assign_changes_buffer_alt(self):
a, b = [Tensor(Tensor(0).contiguous().realize().uop.buf_uop) for _ in range(2)]
Tensor.realize(a.contiguous().assign(1), b.contiguous().assign(2))
@@ -507,17 +506,6 @@ class TestAssign(unittest.TestCase):
# TODO: broken now
np.testing.assert_equal(a.numpy(), [0]*8)
@unittest.skip("don't use output buffer, and mismatch dtype no longer supported")
def test_cast_assignment(self):
a = Tensor(np.arange(N*N, dtype=np.float32)).reshape(N,N)
a.realize()
oba1 = a.uop.base.output_buffer
a.assign(a.cast(dtypes.int32).realize())
a.realize()
oba2 = a.uop.base.output_buffer
assert oba1 is None and oba2 is None
np.testing.assert_allclose(a.numpy(), np.arange(N*N,dtype=np.int32).reshape((N,N)))
def test_assign_dtype_mismatch(self):
# assign should not implicitly cast dtypes - this can lose precision
a = Tensor.zeros(4, dtype=dtypes.float32).contiguous().realize()
@@ -684,7 +672,6 @@ class TestAssignOrdering(unittest.TestCase):
self.assertEqual(r1.item(), 4)
self.assertEqual(r2.item(), 8)
@unittest.skip("TODO: this is broken")
def test_write_read_write_chain(self):
"""Write, read, write chain - middle read must complete before second write."""
buf = Tensor.zeros(4).contiguous().realize()
@@ -694,7 +681,11 @@ class TestAssignOrdering(unittest.TestCase):
final_sum = buf.sum() # lazy read, should be 20
# Realize in "wrong" order - final first
self.assertEqual(final_sum.realize().item(), 20)
self.assertEqual(mid_sum.realize().item(), 12)
try:
self.assertEqual(mid_sum.realize().item(), 12)
except AssertionError:
# TODO: this is wrong
self.assertEqual(mid_sum.realize().item(), 20)
def test_slice_read_then_full_write(self):
"""Read from slice, then overwrite full buffer - WAR dependency works for full buffer assigns."""