github/wgpu
1
1
Fork 0
mirror of https://github.com/gfx-rs/wgpu.git synced 2026-04-22 03:02:01 -04:00
Code Issues Packages Projects Releases Wiki Activity

cli: Change --generate-debug-symbols from option to switch.

Browse Source 
Change `--generate-debug-symbols` from an option that requires a
value, "true" or "false", to a switch, whose mere presence enables the
feature.
This commit is contained in:
Jim Blandy
2023-09-12 13:31:50 -07:00
committed by Teodor Tanasoaia
parent 2a47a15f03
commit 23860c0e29
1 changed files with 22 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

31
cli/src/bin/naga.rs
View File

@@ -76,8 +76,8 @@ struct Args {
stdin_file_path: Option<String>,
/// generate debug symbols, only works for spv-out for now
#[argh(option, short = 'g')]
generate_debug_symbols: Option<bool>,
#[argh(switch, short = 'g')]
generate_debug_symbols: bool,
/// show version
#[argh(switch)]
@@ -448,19 +448,32 @@ fn run() -> Result<(), Box<dyn std::error::Error>> {
params.spv.bounds_check_policies = params.bounds_check_policies;
//Insert Debug infos
params.spv.debug_info = args.generate_debug_symbols.and_then(|debug| {
params.spv.flags.set(spv::WriterFlags::DEBUG, debug);
// Include debugging information if requested.
params.spv.debug_info = if args.generate_debug_symbols {
if let Some(ref input_text) = input_text {
params.spv.flags.set(spv::WriterFlags::DEBUG, true);
if debug {
Some(spv::DebugInfo {
source_code: input_text.as_ref()?,
file_name: input_path.file_name().and_then(std::ffi::OsStr::to_str)?,
source_code: input_text,
file_name: input_path
.file_name()
.and_then(std::ffi::OsStr::to_str)
.ok_or(CliError(
"input path for couldn't be converted to string \
for `--generate-debug-symbols",
))?,
})
} else {
eprintln!(
"warning: `--generate-debug-symbols` was passed, \
but input is not human-readable: {}",
input_path.display()
);
None
}
});
} else {
None
};
params.spv.flags.set(
spv::WriterFlags::ADJUST_COORDINATE_SPACE,