github/wgpu
1
1
Fork 0
mirror of https://github.com/gfx-rs/wgpu.git synced 2026-04-22 03:02:01 -04:00
Code Issues Packages Projects Releases Wiki Activity

[glsl-in] Don't read builtin if it isn't available

Browse Source
This commit is contained in:
João Capucho
2021-05-21 22:46:17 +01:00
committed by Dzmitry Malyshau
parent e7308e1903
commit 28a1ee4354
1 changed files with 27 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

27
src/front/glsl/functions.rs
View File

@@ -439,6 +439,7 @@ impl Program<'_> {
for (binding, input, handle) in self.entry_args.iter().cloned() {
match binding {
Binding::Location { .. } if !input => continue,
Binding::BuiltIn(builtin) if !should_read(builtin, stage) => continue,
_ => {}
}
@@ -524,6 +525,32 @@ impl Program<'_> {
}
}
// FIXME: Both of the functions below should be removed they are a temporary solution
//
// The fix should analyze the entry point and children function calls
// (recursively) and store something like `GlobalUse` and then later only read
// or store the globals that need to be read or written in that stage
fn should_read(built_in: BuiltIn, stage: ShaderStage) -> bool {
match (built_in, stage) {
(BuiltIn::Position, ShaderStage::Fragment)
| (BuiltIn::BaseInstance, ShaderStage::Vertex)
| (BuiltIn::BaseVertex, ShaderStage::Vertex)
| (BuiltIn::ClipDistance, ShaderStage::Fragment)
| (BuiltIn::InstanceIndex, ShaderStage::Vertex)
| (BuiltIn::VertexIndex, ShaderStage::Vertex)
| (BuiltIn::FrontFacing, ShaderStage::Fragment)
| (BuiltIn::SampleIndex, ShaderStage::Fragment)
| (BuiltIn::SampleMask, ShaderStage::Fragment)
| (BuiltIn::GlobalInvocationId, ShaderStage::Compute)
| (BuiltIn::LocalInvocationId, ShaderStage::Compute)
| (BuiltIn::LocalInvocationIndex, ShaderStage::Compute)
| (BuiltIn::WorkGroupId, ShaderStage::Compute)
| (BuiltIn::WorkGroupSize, ShaderStage::Compute) => true,
_ => false,
}
}
fn should_write(built_in: BuiltIn, stage: ShaderStage) -> bool {
match (built_in, stage) {
(BuiltIn::Position, ShaderStage::Vertex)