github/wgpu
1
1
Fork 0
mirror of https://github.com/gfx-rs/wgpu.git synced 2026-04-22 03:02:01 -04:00
Code Issues Packages Projects Releases Wiki Activity

Still close the encoder on error

Browse Source
This commit is contained in:
Dzmitry Malyshau
2021-09-09 09:13:01 -04:00
committed by Dzmitry Malyshau
parent bdd72dc94d
commit 83abe2a06d
1 changed files with 17 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

27
wgpu-core/src/command/mod.rs
View File

@@ -348,16 +348,23 @@ impl<G: GlobalIdentityHandlerFactory> Global<G> {
let mut token = Token::root();
let (mut cmd_buf_guard, _) = hub.command_buffers.write(&mut token);
let error = match CommandBuffer::get_encoder_mut(&mut *cmd_buf_guard, encoder_id) {
Ok(cmd_buf) => {
cmd_buf.encoder.close();
cmd_buf.status = CommandEncoderStatus::Finished;
//Note: if we want to stop tracking the swapchain texture view,
// this is the place to do it.
log::trace!("Command buffer {:?} {:#?}", encoder_id, cmd_buf.trackers);
None
}
Err(e) => Some(e),
let error = match cmd_buf_guard.get_mut(encoder_id) {
Ok(cmd_buf) => match cmd_buf.status {
CommandEncoderStatus::Recording => {
cmd_buf.encoder.close();
cmd_buf.status = CommandEncoderStatus::Finished;
//Note: if we want to stop tracking the swapchain texture view,
// this is the place to do it.
log::trace!("Command buffer {:?} {:#?}", encoder_id, cmd_buf.trackers);
None
}
CommandEncoderStatus::Finished => Some(CommandEncoderError::NotRecording),
CommandEncoderStatus::Error => {
cmd_buf.encoder.close();
Some(CommandEncoderError::Invalid)
}
},
Err(_) => Some(CommandEncoderError::Invalid),
};
(encoder_id, error)