Port the Web backend to the Context trait

examples/capture/main.rs

@@ -23,7 +23,8 @@ async fn run() {
             },
             limits: wgpu::Limits::default(),
         })
-        .await;
+        .await
+        .unwrap();
 
     // Rendered image is 256×256 with 32-bit RGBA color
     let size = 256u32;

examples/framework.rs

@@ -50,7 +50,7 @@ async fn run_async<E: Example>(event_loop: EventLoop<()>, window: Window) {
     log::info!("Initializing the surface...");
 
     let instance = wgpu::Instance::new();
-    let (size, surface) = {
+    let (size, surface) = unsafe {
         let size = window.inner_size();
         let surface = instance.create_surface(&window);
         (size, surface)
@@ -74,7 +74,8 @@ async fn run_async<E: Example>(event_loop: EventLoop<()>, window: Window) {
             },
             limits: wgpu::Limits::default(),
         })
-        .await;
+        .await
+        .unwrap();
 
     let mut sc_desc = wgpu::SwapChainDescriptor {
         usage: wgpu::TextureUsage::OUTPUT_ATTACHMENT,

examples/hello-compute/main.rs

@@ -39,7 +39,8 @@ async fn execute_gpu(numbers: Vec<u32>) -> Vec<u32> {
             },
             limits: wgpu::Limits::default(),
         })
-        .await;
+        .await
+        .unwrap();
 
     let cs = include_bytes!("shader.comp.spv");
     let cs_module =

examples/hello-triangle/main.rs

@@ -7,7 +7,7 @@ use winit::{
 async fn run(event_loop: EventLoop<()>, window: Window, swapchain_format: wgpu::TextureFormat) {
     let size = window.inner_size();
     let instance = wgpu::Instance::new();
-    let surface = instance.create_surface(&window);
+    let surface = unsafe { instance.create_surface(&window) };
     let adapter = instance
         .request_adapter(
             &wgpu::RequestAdapterOptions {
@@ -26,7 +26,8 @@ async fn run(event_loop: EventLoop<()>, window: Window, swapchain_format: wgpu::
             },
             limits: wgpu::Limits::default(),
         })
-        .await;
+        .await
+        .unwrap();
 
     let vs = include_bytes!("shader.vert.spv");
     let vs_module =

src/backend/direct.rs

@@ -26,24 +26,6 @@ macro_rules! gfx_select {
     };
 }
 
-fn map_buffer_copy_view(view: crate::BufferCopyView<'_>) -> wgc::command::BufferCopyView {
-    wgc::command::BufferCopyView {
-        buffer: view.buffer.id,
-        offset: view.offset,
-        bytes_per_row: view.bytes_per_row,
-        rows_per_image: view.rows_per_image,
-    }
-}
-
-fn map_texture_copy_view<'a>(view: crate::TextureCopyView<'a>) -> wgc::command::TextureCopyView {
-    wgc::command::TextureCopyView {
-        texture: view.texture.id,
-        mip_level: view.mip_level,
-        array_layer: view.array_layer,
-        origin: view.origin,
-    }
-}
-
 pub type Context = wgc::hub::Global<wgc::hub::IdentityManagerFactory>;
 
 mod pass_impl {
@@ -184,6 +166,24 @@ mod pass_impl {
     }
 }
 
+fn map_buffer_copy_view(view: crate::BufferCopyView<'_>) -> wgc::command::BufferCopyView {
+    wgc::command::BufferCopyView {
+        buffer: view.buffer.id,
+        offset: view.offset,
+        bytes_per_row: view.bytes_per_row,
+        rows_per_image: view.rows_per_image,
+    }
+}
+
+fn map_texture_copy_view<'a>(view: crate::TextureCopyView<'a>) -> wgc::command::TextureCopyView {
+    wgc::command::TextureCopyView {
+        texture: view.texture.id,
+        mip_level: view.mip_level,
+        array_layer: view.array_layer,
+        origin: view.origin,
+    }
+}
+
 impl crate::Context for Context {
     type AdapterId = wgc::id::AdapterId;
     type DeviceId = wgc::id::DeviceId;
@@ -211,11 +211,12 @@ impl crate::Context for Context {
     type SwapChainOutputDetail = SwapChainOutputDetail;
 
     type RequestAdapterFuture = Ready<Option<Self::AdapterId>>;
-    type RequestDeviceFuture = Ready<(Self::DeviceId, Self::QueueId)>;
+    type RequestDeviceFuture =
+        Ready<Result<(Self::DeviceId, Self::QueueId), crate::RequestDeviceError>>;
     type MapReadFuture =
-        native_gpu_future::GpuFuture<Result<BufferReadMappingDetail, crate::BufferAsyncErr>>;
+        native_gpu_future::GpuFuture<Result<BufferReadMappingDetail, crate::BufferAsyncError>>;
     type MapWriteFuture =
-        native_gpu_future::GpuFuture<Result<BufferWriteMappingDetail, crate::BufferAsyncErr>>;
+        native_gpu_future::GpuFuture<Result<BufferWriteMappingDetail, crate::BufferAsyncError>>;
 
     fn init() -> Self {
         wgc::hub::Global::new("wgpu", wgc::hub::IdentityManagerFactory)
@@ -319,7 +320,7 @@ impl crate::Context for Context {
     ) -> Self::RequestDeviceFuture {
         let device_id =
             gfx_select!(*adapter => self.adapter_request_device(*adapter, desc, PhantomData));
-        ready((device_id, device_id))
+        ready(Ok((device_id, device_id)))
     }
 
     fn device_create_swap_chain(
@@ -694,7 +695,7 @@ impl crate::Context for Context {
                     buffer_id,
                 }));
             } else {
-                completion.complete(Err(crate::BufferAsyncErr));
+                completion.complete(Err(crate::BufferAsyncError));
             }
         }
 
@@ -731,7 +732,7 @@ impl crate::Context for Context {
                     buffer_id,
                 }));
             } else {
-                completion.complete(Err(crate::BufferAsyncErr));
+                completion.complete(Err(crate::BufferAsyncError));
             }
         }
 

src/backend/mod.rs

@@ -1,7 +1,7 @@
 #[cfg(target_arch = "wasm32")]
 mod web;
-//#[cfg(target_arch = "wasm32")]
-//pub use web::*;
+#[cfg(target_arch = "wasm32")]
+pub(crate) use web::Context;
 
 #[cfg(not(target_arch = "wasm32"))]
 mod direct;

src/lib.rs

@@ -110,9 +110,11 @@ trait Context: Sized {
     type SwapChainOutputDetail;
 
     type RequestAdapterFuture: Future<Output = Option<Self::AdapterId>>;
-    type RequestDeviceFuture: Future<Output = (Self::DeviceId, Self::QueueId)>;
-    type MapReadFuture: Future<Output = Result<Self::BufferReadMappingDetail, BufferAsyncErr>>;
-    type MapWriteFuture: Future<Output = Result<Self::BufferWriteMappingDetail, BufferAsyncErr>>;
+    type RequestDeviceFuture: Future<
+        Output = Result<(Self::DeviceId, Self::QueueId), RequestDeviceError>,
+    >;
+    type MapReadFuture: Future<Output = Result<Self::BufferReadMappingDetail, BufferAsyncError>>;
+    type MapWriteFuture: Future<Output = Result<Self::BufferWriteMappingDetail, BufferAsyncError>>;
 
     fn init() -> Self;
     fn instance_create_surface<W: raw_window_handle::HasRawWindowHandle>(
@@ -483,21 +485,13 @@ impl Drop for ComputePipeline {
 /// a [`CommandEncoder`] and then calling [`CommandEncoder::finish`].
 pub struct CommandBuffer {
     context: Arc<C>,
-    id: <C as Context>::CommandBufferId,
-    alive: bool,
-}
-
-impl CommandBuffer {
-    fn commit(mut self) -> <C as Context>::CommandBufferId {
-        self.alive = false;
-        self.id
-    }
+    id: Option<<C as Context>::CommandBufferId>,
 }
 
 impl Drop for CommandBuffer {
     fn drop(&mut self) {
-        if self.alive {
-            self.context.command_buffer_drop(&self.id);
+        if let Some(ref id) = self.id {
+            self.context.command_buffer_drop(id);
         }
     }
 }
@@ -514,7 +508,7 @@ pub struct CommandEncoder {
     id: <C as Context>::CommandEncoderId,
     /// This type should be !Send !Sync, because it represents an allocation on this thread's
     /// command buffer.
-    _p: std::marker::PhantomData<*const u8>,
+    _p: PhantomData<*const u8>,
 }
 
 /// An in-progress recording of a render pass.
@@ -913,26 +907,29 @@ impl Instance {
 
     /// Retrieves all available [`Adapter`]s that match the given backends.
     #[cfg(not(target_arch = "wasm32"))]
-    pub fn enumerate_adapters(&self, backends: wgt::BackendBit) -> Vec<Adapter> {
+    pub fn enumerate_adapters(&self, backends: wgt::BackendBit) -> impl Iterator<Item = Adapter> {
+        let context = Arc::clone(&self.context);
         self.context
             .enumerate_adapters(wgc::instance::AdapterInputs::Mask(backends, || PhantomData))
             .into_iter()
-            .map(|id| crate::Adapter {
+            .map(move |id| crate::Adapter {
                 id,
-                context: Arc::clone(&self.context),
+                context: Arc::clone(&context),
             })
-            .collect()
     }
 
     /// Creates a surface from a raw window handle.
-    pub fn create_surface<W: raw_window_handle::HasRawWindowHandle>(&self, window: &W) -> Surface {
+    pub unsafe fn create_surface<W: raw_window_handle::HasRawWindowHandle>(
+        &self,
+        window: &W,
+    ) -> Surface {
         Surface {
             id: self.context.instance_create_surface(window),
         }
     }
 
     #[cfg(any(target_os = "ios", target_os = "macos"))]
-    pub fn create_surface_from_core_animation_layer(
+    pub unsafe fn create_surface_from_core_animation_layer(
         &self,
         layer: *mut std::ffi::c_void,
     ) -> Surface {
@@ -983,10 +980,13 @@ impl Adapter {
     /// # Panics
     ///
     /// Panics if the extensions specified by `desc` are not supported by this adapter.
-    pub fn request_device(&self, desc: &DeviceDescriptor) -> impl Future<Output = (Device, Queue)> {
+    pub fn request_device(
+        &self,
+        desc: &DeviceDescriptor,
+    ) -> impl Future<Output = Result<(Device, Queue), RequestDeviceError>> {
         let context = Arc::clone(&self.context);
-        Context::adapter_request_device(&*self.context, &self.id, desc).map(
-            |(device_id, queue_id)| {
+        Context::adapter_request_device(&*self.context, &self.id, desc).map(|result| {
+            result.map(|(device_id, queue_id)| {
                 (
                     Device {
                         context: Arc::clone(&context),
@@ -997,8 +997,8 @@ impl Adapter {
                         id: queue_id,
                     },
                 )
-            },
-        )
+            })
+        })
     }
 
     #[cfg(not(target_arch = "wasm32"))]
@@ -1144,7 +1144,10 @@ impl Drop for Device {
 }
 
 #[derive(Clone, PartialEq, Eq, Debug)]
-pub struct BufferAsyncErr;
+pub struct RequestDeviceError;
+
+#[derive(Clone, PartialEq, Eq, Debug)]
+pub struct BufferAsyncError;
 
 pub struct BufferReadMapping {
     context: Arc<C>,
@@ -1199,7 +1202,7 @@ impl Buffer {
         &self,
         start: BufferAddress,
         size: BufferAddress,
-    ) -> impl Future<Output = Result<BufferReadMapping, BufferAsyncErr>> {
+    ) -> impl Future<Output = Result<BufferReadMapping, BufferAsyncError>> {
         let context = Arc::clone(&self.context);
         self.context
             .buffer_map_read(&self.id, start, size)
@@ -1214,7 +1217,7 @@ impl Buffer {
         &self,
         start: BufferAddress,
         size: BufferAddress,
-    ) -> impl Future<Output = Result<BufferWriteMapping, BufferAsyncErr>> {
+    ) -> impl Future<Output = Result<BufferWriteMapping, BufferAsyncError>> {
         let context = Arc::clone(&self.context);
         self.context
             .buffer_map_write(&self.id, start, size)
@@ -1274,8 +1277,7 @@ impl CommandEncoder {
     pub fn finish(self) -> CommandBuffer {
         CommandBuffer {
             context: Arc::clone(&self.context),
-            id: Context::encoder_finish(&*self.context, &self.id),
-            alive: true,
+            id: Some(Context::encoder_finish(&*self.context, &self.id)),
         }
     }
 
@@ -1405,7 +1407,7 @@ impl<'a> RenderPass<'a> {
         offset: BufferAddress,
         size: BufferAddress,
     ) {
-        self.id.set_index_buffer(&buffer.id, offset, size)
+        RenderPassInner::set_index_buffer(&mut self.id, &buffer.id, offset, size)
     }
 
     /// Assign a vertex buffer to a slot.
@@ -1429,7 +1431,7 @@ impl<'a> RenderPass<'a> {
         offset: BufferAddress,
         size: BufferAddress,
     ) {
-        self.id.set_vertex_buffer(slot, &buffer.id, offset, size)
+        RenderPassInner::set_vertex_buffer(&mut self.id, slot, &buffer.id, offset, size)
     }
 
     /// Sets the scissor region.
@@ -1457,7 +1459,7 @@ impl<'a> RenderPass<'a> {
     ///
     /// The active vertex buffers can be set with [`RenderPass::set_vertex_buffer`].
     pub fn draw(&mut self, vertices: Range<u32>, instances: Range<u32>) {
-        self.id.draw(vertices, instances)
+        RenderPassInner::draw(&mut self.id, vertices, instances)
     }
 
     /// Draws indexed primitives using the active index buffer and the active vertex buffers.
@@ -1465,7 +1467,7 @@ impl<'a> RenderPass<'a> {
     /// The active index buffer can be set with [`RenderPass::set_index_buffer`], while the active
     /// vertex buffers can be set with [`RenderPass::set_vertex_buffer`].
     pub fn draw_indexed(&mut self, indices: Range<u32>, base_vertex: i32, instances: Range<u32>) {
-        self.id.draw_indexed(indices, base_vertex, instances);
+        RenderPassInner::draw_indexed(&mut self.id, indices, base_vertex, instances);
     }
 
     /// Draws primitives from the active vertex buffer(s) based on the contents of the `indirect_buffer`.
@@ -1545,7 +1547,7 @@ impl<'a> ComputePass<'a> {
     ///
     /// `x`, `y` and `z` denote the number of work groups to dispatch in each dimension.
     pub fn dispatch(&mut self, x: u32, y: u32, z: u32) {
-        self.id.dispatch(x, y, z);
+        ComputePassInner::dispatch(&mut self.id, x, y, z);
     }
 
     /// Dispatches compute work operations, based on the contents of the `indirect_buffer`.
@@ -1554,8 +1556,7 @@ impl<'a> ComputePass<'a> {
         indirect_buffer: &'a Buffer,
         indirect_offset: BufferAddress,
     ) {
-        self.id
-            .dispatch_indirect(&indirect_buffer.id, indirect_offset);
+        ComputePassInner::dispatch_indirect(&mut self.id, &indirect_buffer.id, indirect_offset);
     }
 }
 
@@ -1575,7 +1576,9 @@ impl Queue {
         Context::queue_submit(
             &*self.context,
             &self.id,
-            command_buffers.into_iter().map(CommandBuffer::commit),
+            command_buffers
+                .into_iter()
+                .map(|mut comb| comb.id.take().unwrap()),
         );
     }
 }