github/wgpu
1
1
Fork 0
mirror of https://github.com/gfx-rs/wgpu.git synced 2026-04-22 03:02:01 -04:00
Code Issues Packages Projects Releases Wiki Activity

[spv-out] Avoid duplicate lookup in write_type_declaration_local.

Browse Source
This commit is contained in:
Jim Blandy
2021-08-28 17:00:32 -07:00
committed by Dzmitry Malyshau
parent 846dbb5a3e
commit e8d35e8035
1 changed files with 13 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

23
src/back/spv/writer.rs
View File

@@ -173,12 +173,18 @@ impl Writer {
}
pub(super) fn get_type_id(&mut self, lookup_ty: LookupType) -> Word {
if let Entry::Occupied(e) = self.lookup_type.entry(lookup_ty) {
*e.get()
} else {
match lookup_ty {
LookupType::Handle(_handle) => unreachable!("Handles are populated at start"),
LookupType::Local(local_ty) => self.write_type_declaration_local(local_ty),
match self.lookup_type.entry(lookup_ty) {
Entry::Occupied(e) => *e.get(),
Entry::Vacant(e) => {
let local = match lookup_ty {
LookupType::Handle(_handle) => unreachable!("Handles are populated at start"),
LookupType::Local(local) => local,
};
let id = self.id_gen.next();
e.insert(id);
self.write_type_declaration_local(id, local);
id
}
}
}
@@ -585,8 +591,7 @@ impl Writer {
}
}
fn write_type_declaration_local(&mut self, local_ty: LocalType) -> Word {
let id = self.id_gen.next();
fn write_type_declaration_local(&mut self, id: Word, local_ty: LocalType) {
let instruction = match local_ty {
LocalType::Value {
vector_size: None,
@@ -646,9 +651,7 @@ impl Writer {
}
};
self.lookup_type.insert(LookupType::Local(local_ty), id);
instruction.to_words(&mut self.logical_layout.declarations);
id
}
fn write_type_declaration_arena(