This clarifies that the window that a surface is created on must be kept
alive for the lifetime of the surface. This requirement and a proposal
to change it are described in https://github.com/gfx-rs/wgpu/issues/1463
1739: Run Reftests on WARP r=kvark a=cwfitzgerald
**Connections**
#1551.
**Description**
All the segmentation faults on linux, none of them on windows.
**Testing**
It is!
Co-authored-by: Connor Fitzgerald <connorwadefitzgerald@gmail.com>
1744: hal/dx12: fix depth formats and pipeline layout r=kvark a=kvark
**Connections**
Closes#1727
**Description**
There were 2 problems. One was that the reversing of the pipeline layout was done wrong (again). I don't know how it still worked on one of my machines :/
The other was that the backend relied on the depth format reinterpretation without using a typeless format. This is OK on higher-level platforms, but we should be doing it more careful. I tried to approach this maximally efficient: we only use the typeless format if all of the following are true:
1. it's a depth/stencil format
2. it needs to be seen as SRV/UAV
So in the case of a simple depth texture, we are still going to be using a fully-qualified format, and therefore get all of the benefit of HW compression on it.
**Testing**
Ran the examples on Intel
Co-authored-by: Dzmitry Malyshau <dmalyshau@mozilla.com>
1741: Improve Docs for DownlevelFlags r=cwfitzgerald a=zicklag
**Connections**
None
**Description**
Clarifies the documentation on the `DownlevelFlags`, and wraps the documentation of some of the flags to 100 chars.
**Testing**
Tested on Ubuntu 20.04
Co-authored-by: Zicklag <zicklag@katharostech.com>
1742: Mention WGPU_ADAPTER_NAME Env Var in WGPU README r=cwfitzgerald a=zicklag
**Connections**
None
**Description**
Mentions the new `WGPU_ADAPTER_NAME` environment variable in the WGPU readme.
**Testing**
Co-authored-by: Zicklag <zicklag@katharostech.com>
1737: Use Bitshift Style for All Bitflag Consts r=cwfitzgerald a=zicklag
**Connections**
None exactly, but somewhat related to https://github.com/gfx-rs/wgpu/pull/1686 as I was going to put some of this change into that PR, but am splitting it out for ease of review.
**Description**
This is purely code-style related, but it makes it easier to read bitflag constants and much eaiser to add bitflags in the future.
**Testing**
Tested on Ubuntu 20.04
Co-authored-by: Zicklag <zicklag@katharostech.com>
1738: Rename texture usage names according to binding r=kvark a=kvark
**Connections**
Matches https://github.com/gpuweb/gpuweb/pull/1989
**Description**
The `SAMPLED` usage name was confusing because integer and MSAA textures can't be sampled (with a sampler), but fetching data from them is under this usage.
**Testing**
No need
Co-authored-by: Dzmitry Malyshau <kvarkus@gmail.com>
1722: Document coordinate systems in README r=cwfitzgerald a=MichaelMMacLeod
I had to do a bit of digging to find information about coordinate systems in
wgpu (asking on Matrix). This commit adds a table of coordinate systems to help
clarify the issue.
The table comes from the DX12 backend documentation of gfx-rs:
https://github.com/gfx-rs/gfx/tree/master/src/backend/dx12
**Connections**
(none)
**Description**
It was difficult for me to find information about what coordinate systems wgpu uses. This commit addresses this issue by adding documentation about wgpu's coordinate systems to the README.
**Testing**
This is purely a documentation change (I have written no tests).
If you want to see how the table looks on Github, check out my fork at https://github.com/MichaelMMacLeod/wgpu/tree/add-coords-to-readme
Co-authored-by: Michael MacLeod <michaelmmacleod@gmail.com>
