github/zk-email-verify
1
1
Fork 0
mirror of https://github.com/zkemail/zk-email-verify.git synced 2026-01-09 13:38:03 -05:00
Code Issues Packages Projects Releases Wiki Activity

fix: handle missing p= value

Browse Source
This commit is contained in:
Saleel
2024-10-16 23:13:20 +01:00
parent 18f874691b
commit ba1c892949
1 changed files with 12 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

15
packages/helpers/src/dkim/dns-over-http.ts
View File

@@ -65,7 +65,7 @@ export class DoH {
if (result.Status === DoH.DoHStatusNoError && result.Answer.length > 0) {
for (const ans of result.Answer) {
if (ans.type === DoH.DoHTypeTXT) {
let DKIMRecord = ans.data;
let dkimRecord = ans.data;
/*
Remove all double quotes
Some DNS providers wrap TXT records in double quotes,
@@ -73,8 +73,8 @@ export class DoH {
TXT (potentially multi-line) and DKIM (Base64 data) standards,
we can directly remove all double quotes from the DKIM public key.
*/
DKIMRecord = DKIMRecord.replace(/"/g, "");
return DKIMRecord;
dkimRecord = dkimRecord.replace(/"/g, "");
return dkimRecord;
}
}
}
@@ -115,6 +115,15 @@ export async function resolveDNSHTTP(name: string, type: string) {
throw new CustomError('No DKIM record found in Google', 'ENODATA');
}
const regex = /p=([^;]*)/;
const match = regex.exec(googleResult);
if (match) {
const valueAfterP = match[1]; // Extracting the value after p=
if (valueAfterP === '') {
throw new CustomError('No DKIM record found in Google (empty p=)', 'ENODATA');
}
}
const cloudflareResult = await DoH.resolveDKIMPublicKey(
name,
DoHServer.Cloudflare