Commit Graph

1906 Commits

Author SHA1 Message Date
Felipe Faraggi
28205875c5 roll back on ALL-CAPS.md files for TSC proposal (#376)
Signed-off-by: Felipe Faraggi <felipefaraggi@gmail.com>
2020-02-26 13:39:26 +01:00
Sally MacFarlane
9a088f7b2d fixed typos (#429)
Signed-off-by: Sally MacFarlane <sally.macfarlane@consensys.net>

Co-authored-by: CJ Hare <CjHare@users.noreply.github.com>
2020-02-26 17:15:29 +10:00
anthonybuckle
30fa565dca BESU-146 - check if success and return errorResponse otherwise (#424)
Signed-off-by: Anthony Buckle <anthonybuckle@gmail.com>

Co-authored-by: CJ Hare <CjHare@users.noreply.github.com>
2020-02-26 14:44:18 +10:00
Lucas Saldanha
bfc40be32e Adds priv_getcode (#428)
* Adds priv_getcode

Signed-off-by: Joshua Richardson <joshua@richardson.tech>
2020-02-25 11:16:58 +13:00
Danno Ferrin
7fe1d4796e Implement Eth/64 (#425)
Wire in the fork identifier into the status messages as Eth64.

Signed-off-by: Danno Ferrin <danno.ferrin@gmail.com>
2020-02-22 09:30:53 -07:00
Horacio Mijail Antón Quiles
0a19f4750f Remove unused ExecutorService init/termination (#419)
Signed-off-by: Horacio Mijail Anton Quiles <hmijail@gmail.com>

Co-authored-by: CJ Hare <CjHare@users.noreply.github.com>
2020-02-22 12:39:59 +10:00
Edward Mack
3603f8d14d Update SLOAD_GAS cost to 200 in Aztlan Gas Calculator (#23) (#382)
* Update SLOAD_GAS cost to 200 in Aztlan Gas Calculator

Change SLOAD_GAS cost in Aztlan Gas Calculator from 800 to 200 and
update functions that use SLOAD_GAS.

Signed-off-by: edwardmack <ed@edwardmack.com>

* Update SLOAD_GAS cost to 200 in Aztlan Gas Calculator

Change SLOAD_GAS cost in Aztlan Gas Calculator from 800 to 200 and
update functions that use SLOAD_GAS.

Signed-off-by: edwardmack <ed@edwardmack.com>
Signed-off-by: Edward Mack <ed@edwardmack.com>

* remove overrides

removed overrides of calculateStorageCost and
calculateStorageRefundAmount in AztlanGasCalculator because these were
causing aztlan fork not to sync with kotti testnet.

Signed-off-by: Edward Mack <ed@edwardmack.com>

* merge

Signed-off-by: Edward Mack <ed@edwardmack.com>
2020-02-20 11:09:32 -05:00
Karim T
145710abf8 fix order of nat detector (#414)
Signed-off-by: Karim TAAM <karim.t2am@gmail.com>
2020-02-20 09:36:52 +01:00
Danno Ferrin
e28396a5dc Reduce recaching in Transaction Log Bloom Filter Cache (#415)
Do a cursory cache check at start up (file is present and correct size)
instead of re-generating the cache at startup.

Signed-off-by: Danno Ferrin <danno.ferrin@gmail.com>
2020-02-19 11:22:31 -07:00
Danno Ferrin
90d46b7445 LogBloomCache - make sure the current segment is filled (#411)
Make sure we cache the current cache segment with all of the data from
the beginning of the segment.  Use a flip file approach since it will be
 a partial file until done.

Signed-off-by: Danno Ferrin <danno.ferrin@gmail.com>

Co-authored-by: Abdelhamid Bakhta <45264458+abdelhamidbakhta@users.noreply.github.com>
2020-02-19 10:46:03 -07:00
Karim T
8a68402732 [BOUNTY-4] Add NAT Kubernetes Support (#410)
* add kubernetes support

Signed-off-by: Karim TAAM <karim.t2am@gmail.com>

* fix review issues

Signed-off-by: Karim TAAM <karim.t2am@gmail.com>
2020-02-19 10:34:36 +01:00
pinges
1b0dffcb30 Rename method (#412)
* rename the method isPersistingState to isPersistingPrivateState because that is what it is used for

Signed-off-by: Stefan Pingel <stefan.pingel@consensys.net>

* rename the method isPersistingState to isPersistingPrivateState because that is what it is used for

Signed-off-by: Stefan Pingel <stefan.pingel@consensys.net>

* rename the method isPersistingState to isPersistingPrivateState because that is what it is used for

Signed-off-by: Stefan Pingel <stefan.pingel@consensys.net>
2020-02-19 19:00:19 +13:00
Abdelhamid Bakhta
8afd6516e1 Create a custom error when plugin is not found. (#409)
Signed-off-by: Abdelhamid Bakhta <abdelhamid.bakhta@consensys.net>
2020-02-18 17:56:15 +01:00
Abdelhamid Bakhta
c38152abf0 [PIE-2303] Automatic log bloom caching - Remove usage of pending file. (#407)
* Don't use pending file.

Signed-off-by: Abdelhamid Bakhta <abdelhamid.bakhta@consensys.net>

* Don't use pending file.

Signed-off-by: Abdelhamid Bakhta <abdelhamid.bakhta@consensys.net>
2020-02-17 15:15:55 +01:00
Lucas Saldanha
9fa9c858ea Private state update metadata and migration (#404)
(backport from release-1.4)
Private state update metadata and migration

Signed-off-by: Lucas Saldanha <lucas.saldanha@consensys.net>
2020-02-17 15:08:51 +13:00
mark-terry
3773d255c8 [PIE-1798] Fail cases for multitenancy ATs (#400)
Signed-off-by: Mark Terry <mark.terry@consensys.net>
2020-02-14 09:18:56 -05:00
Danno Ferrin
20664f96da Rename logs bloom indexer to log bloom cache to match CLI flag. (#401)
Changes class names, variables, and CLI flags as needed.

Signed-off-by: Danno Ferrin <danno.ferrin@gmail.com>
2020-02-14 07:15:43 +01:00
Danno Ferrin
bb0c9cb017 [BESU-25] Use Devp2p Ping packets at v5 (#392)
Broadcast that we support snappy compression

Signed-off-by: Danno Ferrin <danno.ferrin@gmail.com>
2020-02-13 09:29:58 -07:00
Abdelhamid Bakhta
6677362598 [BESU-169] cache logs bloom filters automatically. (#367)
* First iteration. Draft PR.

Signed-off-by: Abdelhamid Bakhta <abdelhamid.bakhta@consensys.net>

* fix SPDX header

Signed-off-by: Abdelhamid Bakhta <abdelhamid.bakhta@consensys.net>

* Use block broadcaster to index log bloom.

Signed-off-by: Abdelhamid Bakhta <abdelhamid.bakhta@consensys.net>

* Remove useless toString method

Signed-off-by: Abdelhamid Bakhta <abdelhamid.bakhta@consensys.net>

* spotless apply

Signed-off-by: Abdelhamid Bakhta <abdelhamid.bakhta@consensys.net>

* cacheLogsBloomForBlockHeader

Signed-off-by: Abdelhamid Bakhta <abdelhamid.bakhta@consensys.net>

* spotless apply

Signed-off-by: Abdelhamid Bakhta <abdelhamid.bakhta@consensys.net>

* ensurePreviousSegmentsArePresent

Signed-off-by: Abdelhamid Bakhta <abdelhamid.bakhta@consensys.net>

* Added CLI flag to enable / disable automatic logs bloom indexing.

Signed-off-by: Abdelhamid Bakhta <abdelhamid.bakhta@consensys.net>

* Create cache directory and cache file if not exist.

Signed-off-by: Abdelhamid Bakhta <abdelhamid.bakhta@consensys.net>

* Fix acceptance test

Signed-off-by: Abdelhamid Bakhta <abdelhamid.bakhta@consensys.net>

* Write cache for block only if block is new canonical head.

Signed-off-by: Abdelhamid Bakhta <abdelhamid.bakhta@consensys.net>

* Handling of chain reorg.

Signed-off-by: Abdelhamid Bakhta <abdelhamid.bakhta@consensys.net>

* fix

Signed-off-by: Abdelhamid Bakhta <abdelhamid.bakhta@consensys.net>

* sportless apply

Signed-off-by: Abdelhamid Bakhta <abdelhamid.bakhta@consensys.net>

* Address PR comments.

Signed-off-by: Abdelhamid Bakhta <abdelhamid.bakhta@consensys.net>

* Remove unused constant.

Signed-off-by: Abdelhamid Bakhta <abdelhamid.bakhta@consensys.net>

* spotless apply

Signed-off-by: Abdelhamid Bakhta <abdelhamid.bakhta@consensys.net>
2020-02-13 16:33:10 +01:00
Joshua Fernandes
d82c8191d9 updating verion to 1.4.1-snapshot (#398)
Signed-off-by: Joshua Fernandes <joshua.fernandes@consensys.net>
2020-02-13 13:17:21 +10:00
Joshua Fernandes
9135622c12 updating version to 1.4.0-rc1 (#397)
Signed-off-by: Joshua Fernandes <joshua.fernandes@consensys.net>
2020-02-13 12:57:19 +10:00
MadelineMurray
3728c3ced5 Added known bug to changelog (#388)
* Added known bug

Signed-off-by: Madeline <madeline.murray@consensys.net>

* Added another known bug

Signed-off-by: Madeline <madeline.murray@consensys.net>
2020-02-13 12:01:32 +10:00
Ratan Rai Sur
d06c8bfefc docker changelog (#391)
* docker changelog

Signed-off-by: Ratan Rai Sur <ratan.r.sur@gmail.com>

* address comments

Signed-off-by: Ratan Rai Sur <ratan.r.sur@gmail.com>

Co-authored-by: MadelineMurray <43356962+MadelineMurray@users.noreply.github.com>
2020-02-13 11:40:55 +10:00
MadelineMurray
80e0ee102e Fixed link (#393)
Signed-off-by: Madeline <madeline.murray@consensys.net>

Co-authored-by: Edward <edjojob@gmail.com>
2020-02-13 11:20:21 +10:00
Sally MacFarlane
4c72ab7ef3 1.5 RC Changelog (#395)
* 1.5 RC changelog additions

Signed-off-by: Sally MacFarlane <sally.macfarlane@consensys.net>
2020-02-13 09:54:51 +10:00
Jason Frame
8b8a39c90d Changelog entry for multi-tenancy feature (#394)
Signed-off-by: Edward Evans <edward.joshua.evans@gmail.com>
Signed-off-by: Jason Frame <jasonwframe@gmail.com>
2020-02-13 08:54:40 +10:00
Antoine Toulme
358458d5a7 BESU-56: remove erroneous links to errorprone checks (#385)
Signed-off-by: Antoine Toulme <antoine@lunar-ocean.com>
2020-02-12 11:05:38 -07:00
Joshua Fernandes
21e02b12b7 adding the plugin-api javadoc jar at the root level (#378)
Signed-off-by: Joshua Fernandes <joshua.fernandes@consensys.net>
2020-02-12 10:49:16 -07:00
Danno Ferrin
ae3bd0129e More trace fixes (#386)
* pop flat trace context when handling halts
* Better detection of precompiled and non-executed contracts
* correct from address when calling in init code
* fix some exotic nesting cases
* correct from field for init code calls at depth >1
* correct cost on a non-call
* changelog and notes

Signed-off-by: Danno Ferrin <danno.ferrin@gmail.com>
2020-02-12 10:31:52 -07:00
Danno Ferrin
87f4829e23 More specific task metrics names (#389)
A prior refactoring had accidentally removed the specific task names
from the metrics labels.

Signed-off-by: Danno Ferrin <danno.ferrin@gmail.com>
2020-02-12 09:16:59 -07:00
mark-terry
d25297443e [PIE-1798] Priv RPC acceptance tests with stub enclave. (#330)
* [PIE-1798] Added some Privacy RPC ATs with a stub enclave.

Signed-off-by: Mark Terry <mark.terry@consensys.net>
2020-02-11 12:19:44 +10:00
Karim T
39826b1423 [BOUNTY-2] Add NAT Docker Support (#368)
* add docker detection

Signed-off-by: Karim TAAM <karim.t2am@gmail.com>

* add port mapping detection

Signed-off-by: Karim TAAM <karim.t2am@gmail.com>

* add tests and refactor ip detection

Signed-off-by: Karim TAAM <karim.t2am@gmail.com>

* clean RunnerBuilder

Signed-off-by: Karim TAAM <karim.t2am@gmail.com>

* clean useless modification

Signed-off-by: Karim TAAM <karim.t2am@gmail.com>

* spotless

Signed-off-by: Karim TAAM <karim.t2am@gmail.com>

* resolve tests issues

Signed-off-by: Karim TAAM <karim.t2am@gmail.com>

* streamline auto detection

Signed-off-by: Ratan Rai Sur <ratan.r.sur@gmail.com>

Co-authored-by: Abdelhamid Bakhta <45264458+abdelhamidbakhta@users.noreply.github.com>
Co-authored-by: Ratan Rai Sur <ratan.r.sur@gmail.com>
2020-02-10 21:13:20 +01:00
Danno Ferrin
358ab092b4 Trace API fixes (#377)
- Correct Reporting of reverts in nested call
- correct reporting and handling of value transfer in nested calls
- correct handling of precompiles via DELEGATECALL & CALLCODE
- Addition of precompiled contract gas costs
- Re-work handling of storage writes
- Initial handling of gas refunds
- fix bug in DELEGATECALL tests, we don't need gas in the stack
  * this has a cascading effect on balances in diff tests
- rework depth detection in flat trace
- two new tests blocks

Signed-off-by: Danno Ferrin <danno.ferrin@gmail.com>
2020-02-10 12:15:24 -07:00
Jason Frame
9b35c3b658 Validate private transaction before sending to enclave (#356)
Signed-off-by: Jason Frame <jasonwframe@gmail.com>
2020-02-10 11:02:23 +10:00
Danno Ferrin
059f0ae5f5 VM Trace fixes (#372)
* correct refund addresses
* correct returned memory from static precompiled calls.
* update integration test
* precompiles sometimes get plain old CALLs

Signed-off-by: Danno Ferrin <danno.ferrin@gmail.com>
2020-02-07 07:33:56 -07:00
Danno Ferrin
f4b921b7fc Plugin error stack traces (#369)
Because of how the Log4J2 api works exception stack traces were not
being printed.  Update to use the explicit "throwable" overloaded
methods.

Signed-off-by: Danno Ferrin <danno.ferrin@gmail.com>
2020-02-07 06:03:55 -07:00
Edward Mack
b6e25567a1 [ETC] Aztlan fork support (#366)
This PR introduces functionality to conform with ECIP-1061
https://ecips.ethereumclassic.org/ECIPs/ecip-1061

Signed-off-by: edwardmack <ed@edwardmack.com>
Signed-off-by: Danno Ferrin <danno.ferrin@gmail.com>

Co-authored-by: Danno Ferrin <danno.ferrin@shemnon.com>
2020-02-05 13:01:02 -05:00
Danno Ferrin
a7d3896af8 More tracing api fixes (#361)
* Handle CREATE and CREATE2 in flat trace
* precompile calls don't generate traces
* Handle REVERT in output and result nodes.
* output doesn't need to be held behind a supplier
* Handle padded output values when end is past memory
* Store memory in vm trace for MLOADs
* CREATE and CREATE2 store memory in vm-trace

Signed-off-by: Danno Ferrin <danno.ferrin@gmail.com>
2020-02-04 14:47:49 -07:00
Danno Ferrin
a933179254 Json Blocks Import timestamp (#358)
Allows for the setting of the timestamp in JSON block importer.
Ordinarily it is now and then 1 second for each block.  The initial time
can now be set via CLI option `--start-time`, which defaults to now.

Signed-off-by: Danno Ferrin <danno.ferrin@gmail.com>
2020-02-04 14:32:23 -07:00
Abdelhamid Bakhta
21dc78af61 Renamed .index to .cache. (#364)
Signed-off-by: Abdelhamid Bakhta <abdelhamid.bakhta@consensys.net>
2020-02-04 19:38:46 +01:00
Sally MacFarlane
9dfed5ab74 [BESU-80] TLS to orion (#324)
* enable SSL on connection to enclave

Signed-off-by: Sally MacFarlane <sally.macfarlane@consensys.net>
2020-02-04 15:59:06 +10:00
Joshua Fernandes
f12c92ec58 add the binary on ci at build time, dont need it to be in the code base (#359)
Signed-off-by: Joshua Fernandes <joshua.fernandes@consensys.net>
2020-02-04 07:53:49 +10:00
Abdelhamid Bakhta
d7d82e417d [BESU-176] JRPC response to eth_getTransactionCount is different from other node implementations. (#351)
* Fix strategy for getting next nonce for sender in `PendingTransactions`.
Added test.

Signed-off-by: Abdelhamid Bakhta <abdelhamid.bakhta@consensys.net>

* Introduced `TransactionsForSenderInfo` structure to have a less naive implementation, more robust against load testing.
A queue of gaps between used nonces is maintained.
`getNextNonceForSender` has been updated and have the following logic:
- if no infos corresponding to the nonce returns an empty optional
- if gap list is not empty returns the lowest nonce in the gap
- else returns the max nonce + 1

Signed-off-by: Abdelhamid Bakhta <abdelhamid.bakhta@consensys.net>

* spotless

Signed-off-by: Abdelhamid Bakhta <abdelhamid.bakhta@consensys.net>

* spotless

Signed-off-by: Abdelhamid Bakhta <abdelhamid.bakhta@consensys.net>

* added test

Signed-off-by: Abdelhamid Bakhta <abdelhamid.bakhta@consensys.net>

* spotless

Signed-off-by: Abdelhamid Bakhta <abdelhamid.bakhta@consensys.net>
2020-02-03 20:27:24 +01:00
Danno Ferrin
7a7416f74e Handle CREATE and CREATE2 in flat trace (#353)
* Handle CREATE and CREATE2 in flat trace

Handle create and create2 operations. Some other tests also got adjusted
as the source accounts were running out of test ether.  Bumping up the
value in the genesis caused the statediff values to also go up.

Signed-off-by: Danno Ferrin <danno.ferrin@gmail.com>
2020-02-03 11:01:53 +01:00
Paul Harris
20e9cbbc7e [BESU-184] Update PicoCLI to latest version (#349)
- Updated PicoCLI from version 3.9.6 to 4.1.4 and fixed test cases that were impacted by breaking changes of PicoCLI.

- Updated the command factory to fallback to the default factory, as directed in the PicoCli v.4.0.0 release notes.

Signed-off-by: Paul Harris <paul.harris@consensys.net>
2020-02-03 15:34:27 +10:00
Sally MacFarlane
13b1ca6bae [MINOR] typo (#357)
* typo

Signed-off-by: Sally MacFarlane <sally.macfarlane@consensys.net>
2020-02-03 13:09:17 +10:00
MadelineMurray
8577e667bd Adding Danno's changes back (#355)
Signed-off-by: Madeline <madeline.murray@consensys.net>
2020-02-03 08:05:51 +10:00
Danno Ferrin
fd3f2d30c1 Tracing multiple levels of calls now works properly (#352)
The iterative look back mechanism flat trace was using was missing
many of the nesting subtlties, so a stack based calculation is used.

A new test case with two levels of calls is also introduced.

Signed-off-by: Danno Ferrin <danno.ferrin@gmail.com>
2020-02-01 00:18:05 -07:00
Edward
ee12a7c284 Prepare for version 1.4.0-beta4-SNAPSHOT (#348)
Signed-off-by: Edward Evans <edward.joshua.evans@gmail.com>
2020-01-31 10:41:19 +10:00
Danno Ferrin
15108e1fd4 1.4.0-beta3 release (#347)
Signed-off-by: Edward Evans <edward.joshua.evans@gmail.com>
2020-01-31 09:54:27 +10:00