fix: enforce not having unused imports, and force correct casing (#58)

config.nims

@@ -1,2 +1,10 @@
 --mm:
   refc
+
+--styleCheck:
+  usages
+--styleCheck:
+  error
+
+switch("warningAsError", "UnusedImport:on")
+switch("warningAsError", "UseBase:on")

examples/poc_gossipsub.nim

@@ -1,16 +1,13 @@
 import chronicles, sequtils, strutils, chronos, results
-import std/[enumerate, strformat, sysrand]
+import std/[enumerate, strformat]
 import ../mix
+import libp2p
 import
   libp2p/[
     crypto/secp,
-    multiaddress,
-    builders,
-    muxers/yamux/yamux,
     protocols/pubsub/gossipsub,
     protocols/pubsub/pubsubpeer,
     protocols/pubsub/rpc/messages,
-    transports/tcptransport,
   ]
 
 type Node = tuple[switch: Switch, gossip: GossipSub, mix: MixProtocol, id: int]

examples/poc_gossipsub_repeated_runs.nim

@@ -1,16 +1,13 @@
-import chronicles, math, sequtils, strutils, sugar, chronos, results
-import std/[atomics, enumerate, strformat, sysrand]
+import chronicles, chronos, results
+import std/[atomics, enumerate, sequtils, strformat, strutils, sugar]
 import ../mix
+import libp2p
 import
   libp2p/[
     crypto/secp,
-    multiaddress,
-    builders,
-    muxers/yamux/yamux,
     protocols/pubsub/gossipsub,
     protocols/pubsub/pubsubpeer,
     protocols/pubsub/rpc/messages,
-    transports/tcptransport,
   ]
 
 type Node = tuple[switch: Switch, gossip: GossipSub, mix: MixProtocol, id: int]

examples/poc_noresp_ping.nim

@@ -1,9 +1,7 @@
 import chronicles, chronos, results, strutils
 import std/[enumerate, sysrand]
 import libp2p
-import
-  libp2p/
-    [crypto/secp, multiaddress, builders, muxers/yamux/yamux, protocols/ping, switch]
+import libp2p/[crypto/secp]
 import ./protocols/noresp_ping
 
 import ../mix

mix/entry_connection.nim

@@ -1,6 +1,6 @@
 import hashes, chronos, stew/byteutils, results
 import libp2p/stream/connection
-import ./protocol, ./mix_node, ./mix_protocol
+import ./protocol, ./mix_protocol
 
 type MixDialer* = proc(
   msg: seq[byte],

mix/entry_connection_callbacks.nim

@@ -1,6 +1,6 @@
 # TODO: this file should likely become mix.nim in the root of the project
 
-import bearssl/rand, chronos, chronicles, results
+import chronos, chronicles, results
 import std/[sequtils, sets]
 import libp2p/[multiaddress, protocols/pubsub/pubsubpeer, switch]
 import ./[entry_connection, mix_protocol, protocol]

mix/mix_protocol.nim

@@ -252,7 +252,7 @@ proc anonymizeLocalProtocolSend*(
 
   mix_messages_recvd.inc(labelValues = ["Entry"])
 
-  let paddedMsg = padMessage(serialized, peerID)
+  let paddedMsg = padMessage(serialized, peerId)
 
   var
     multiAddrs: seq[string] = @[]

mix/sphinx.nim

@@ -1,5 +1,4 @@
 import results, sequtils
-import std/math
 import ./[config, crypto, curve25519, serialization, tag_manager]
 
 # Define possible outcomes of processing a Sphinx packet
@@ -181,7 +180,7 @@ proc computeBetaGammaDelta(
         return err("Error in aes: " & deltaRes.error)
       delta = deltaRes.get()
 
-    gamma = toseq(hmac(mac_key, beta))
+    gamma = toSeq(hmac(mac_key, beta))
 
   return ok((beta, gamma, delta))
 
@@ -241,7 +240,7 @@ proc processSphinxPacket*(
   # Compute MAC
   let mac_key = kdf(deriveKeyMaterial("mac_key", sBytes))
 
-  if not (toseq(hmac(mac_key, beta)) == gamma):
+  if not (toSeq(hmac(mac_key, beta)) == gamma):
     # If MAC not verified
     return ok((Hop(), @[], @[], InvalidMAC))
 

tests/test_crypto.nim

@@ -1,3 +1,5 @@
+{.used.}
+
 import chronicles, nimcrypto, results, unittest
 import ../mix/crypto
 

tests/test_curve25519.nim

@@ -1,3 +1,5 @@
+{.used.}
+
 import chronicles, results, unittest
 import pkg/libp2p/crypto/curve25519
 import ../mix/curve25519

tests/test_fragmentation.nim

@@ -1,3 +1,5 @@
+{.used.}
+
 import chronicles, results, unittest
 import libp2p/peerid
 import ../mix/[config, fragmentation]

tests/test_mix_message.nim

@@ -1,3 +1,5 @@
+{.used.}
+
 import chronicles, results, unittest
 import ../mix/[mix_message, protocol]
 

tests/test_mix_node.nim

@@ -1,4 +1,6 @@
-import chronicles, os, strformat, results, strutils, unittest
+{.used.}
+
+import chronicles, strformat, results, strutils, unittest
 import libp2p/[crypto/crypto, crypto/secp, multiaddress, peerid]
 import ../mix/[curve25519, mix_node]
 

tests/test_seqno_generator.nim

@@ -1,3 +1,5 @@
+{.used.}
+
 import chronicles, sets, unittest
 import std/[os, times]
 import libp2p/peerid

tests/test_serialization.nim

@@ -1,3 +1,5 @@
+{.used.}
+
 import chronicles, results, unittest
 import ../mix/[config, serialization]
 

tests/test_sphinx.nim

@@ -1,3 +1,5 @@
+{.used.}
+
 import chronicles, random, results, unittest
 import ../mix/[config, curve25519, serialization, sphinx, tag_manager]
 

tests/test_tag_manager.nim

@@ -1,3 +1,5 @@
+{.used.}
+
 import chronicles, results, unittest
 import ../mix/[curve25519, tag_manager]
 

tests/test_utils.nim

@@ -1,3 +1,5 @@
+{.used.}
+
 import chronicles, results, unittest
 import ../mix/[config, utils]