vacp2p/staking-reward-streamer
1
0
Fork 0
mirror of https://github.com/vacp2p/staking-reward-streamer.git synced 2026-01-08 20:48:00 -05:00
Code Issues Packages Projects Releases Wiki Activity

test(StakeVault): add test to ensure users cannot withdraw without unstaking

Browse Source
This commit is contained in:
r4bbit
2024-11-26 10:27:17 +01:00
parent e8d880e4ea
commit e823711c9a
4 changed files with 35 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

19
.gas-report
View File

@@ -22,17 +22,18 @@
| MIN_LOCKUP_PERIOD | 275 | 275 | 275 | 275 | 11 |
| MP_RATE_PER_YEAR | 231 | 231 | 231 | 231 | 3 |
| SCALE_FACTOR | 295 | 295 | 295 | 295 | 41 |
| STAKING_TOKEN | 273 | 273 | 273 | 273 | 172 |
| STAKING_TOKEN | 273 | 273 | 273 | 273 | 174 |
| accountedRewards | 351 | 906 | 351 | 2351 | 72 |
| emergencyModeEnabled | 2377 | 2377 | 2377 | 2377 | 7 |
| enableEmergencyMode | 23504 | 40411 | 45696 | 45696 | 8 |
| getAccount | 1596 | 1596 | 1596 | 1596 | 71 |
| isTrustedCodehash | 496 | 996 | 496 | 2496 | 172 |
| getStakedBalance | 2579 | 2579 | 2579 | 2579 | 1 |
| isTrustedCodehash | 496 | 1013 | 496 | 2496 | 174 |
| rewardIndex | 373 | 400 | 373 | 2373 | 72 |
| setTrustedCodehash | 47926 | 47926 | 47926 | 47926 | 43 |
| setTrustedCodehash | 47926 | 47926 | 47926 | 47926 | 45 |
| totalMP | 330 | 330 | 330 | 330 | 75 |
| totalMaxMP | 351 | 351 | 351 | 351 | 75 |
| totalStaked | 330 | 330 | 330 | 330 | 75 |
| totalStaked | 330 | 330 | 330 | 330 | 76 |
| updateAccountMP | 36758 | 38996 | 39260 | 39260 | 19 |
| updateGlobalState | 32134 | 60366 | 49513 | 82460 | 28 |
@@ -42,10 +43,12 @@
| Deployment Cost | Deployment Size | | | | |
| 1095864 | 5202 | | | | |
| Function Name | min | avg | median | max | # calls |
| STAKING_TOKEN | 217 | 217 | 217 | 217 | 1 |
| emergencyExit | 31410 | 43924 | 43160 | 60260 | 7 |
| lock | 38362 | 60516 | 42741 | 100445 | 3 |
| stake | 199213 | 236948 | 242906 | 263435 | 55 |
| stake | 199213 | 237055 | 242906 | 263435 | 56 |
| unstake | 84988 | 113999 | 103434 | 146128 | 13 |
| withdraw | 37318 | 37318 | 37318 | 37318 | 1 |
| src/XPNFTToken.sol:XPNFTToken contract | | | | | |
@@ -121,9 +124,9 @@
| Deployment Cost | Deployment Size | | | | |
| 639406 | 3369 | | | | |
| Function Name | min | avg | median | max | # calls |
| approve | 46334 | 46343 | 46346 | 46346 | 220 |
| balanceOf | 561 | 1381 | 561 | 2561 | 334 |
| mint | 51284 | 58817 | 51284 | 68384 | 236 |
| approve | 46334 | 46343 | 46346 | 46346 | 222 |
| balanceOf | 561 | 1382 | 561 | 2561 | 336 |
| mint | 51284 | 58898 | 51284 | 68384 | 238 |
| transfer | 34390 | 48859 | 51490 | 51490 | 13 |

2
.gas-snapshot
View File

@@ -29,6 +29,7 @@ StakeTest:test_StakeOneAccountReachingMPLimit() (gas: 494078)
StakeTest:test_StakeOneAccountWithMaxLockUp() (gas: 298175)
StakeTest:test_StakeOneAccountWithMinLockUp() (gas: 298187)
StakeTest:test_StakeOneAccountWithRandomLockUp() (gas: 298298)
StakingTokenTest:testStakeToken() (gas: 10426)
UnstakeTest:test_StakeMultipleAccounts() (gas: 493323)
UnstakeTest:test_StakeMultipleAccountsAndRewards() (gas: 640807)
UnstakeTest:test_StakeMultipleAccountsMPIncreasesMaxMPDoesNotChange() (gas: 818251)
@@ -48,6 +49,7 @@ UnstakeTest:test_UnstakeOneAccount() (gas: 480152)
UnstakeTest:test_UnstakeOneAccountAndAccruedMP() (gas: 496638)
UnstakeTest:test_UnstakeOneAccountAndRewards() (gas: 585964)
UnstakeTest:test_UnstakeOneAccountWithLockUpAndAccruedMP() (gas: 518574)
WithdrawTest:test_CannotWithdrawStakedFunds() (gas: 295608)
XPNFTTokenTest:testApproveNotAllowed() (gas: 10507)
XPNFTTokenTest:testGetApproved() (gas: 10531)
XPNFTTokenTest:testIsApprovedForAll() (gas: 10705)

4
src/StakeVault.sol
View File

@@ -13,7 +13,7 @@ import { IStakeManager } from "./interfaces/IStakeManager.sol";
* @dev This contract is owned by the user and allows staking, unstaking, and withdrawing tokens.
*/
contract StakeVault is Ownable {
error StakeVault__NoEnoughAvailableBalance();
error StakeVault__NotEnoughAvailableBalance();
error StakeVault__InvalidDestinationAddress();
error StakeVault__UpdateNotAvailable();
error StakeVault__StakingFailed();
@@ -156,7 +156,7 @@ contract StakeVault is Ownable {
function _withdraw(IERC20 _token, uint256 _amount, address _destination) internal {
if (_token == STAKING_TOKEN && STAKING_TOKEN.balanceOf(address(this)) - amountStaked() < _amount) {
revert StakeVault__NoEnoughAvailableBalance();
revert StakeVault__NotEnoughAvailableBalance();
}
_token.transfer(_destination, _amount);
}

20
test/StakeVault.test.sol
View File

@@ -49,3 +49,23 @@ contract StakingTokenTest is StakeVaultTest {
assertEq(address(stakeVault.STAKING_TOKEN()), address(stakingToken));
}
}
contract WithdrawTest is StakeVaultTest {
function setUp() public override {
StakeVaultTest.setUp();
}
function test_CannotWithdrawStakedFunds() public {
// first, stake some funds
vm.prank(alice);
stakeVault.stake(10e18, 0);
assertEq(stakingToken.balanceOf(address(stakeVault)), 10e18);
assertEq(streamer.totalStaked(), 10e18);
// try withdrawing funds without unstaking
vm.prank(alice);
vm.expectRevert(StakeVault.StakeVault__NotEnoughAvailableBalance.selector);
stakeVault.withdraw(stakingToken, 10e18);
}
}