Version updates (#1503)

* Most libraries with newer stable versions were upgraded to their
  newest stable version
* One exception is RocksDB, where a previous update caused a performance
  regression.  the 6.0.1 update will be tested in another PR
* GraphQL got stingier about null variable maps, so empty maps were passed instead
* errorprone plugin got stricter with it's variable access
* There was a license that was slightly different, creating 2 MIT licenses in the license report.
* Gradle wanted a new almost identical wrapper jar.
Signed-off-by: Adrian Sutton <adrian.sutton@consensys.net>

build.gradle

@@ -14,14 +14,14 @@
 import net.ltgt.gradle.errorprone.CheckSeverity
 
 plugins {
-  id 'com.diffplug.gradle.spotless' version '3.19.0'
+  id 'com.diffplug.gradle.spotless' version '3.23.0'
   id 'com.jfrog.bintray' version '1.8.4'
   id 'com.github.ben-manes.versions' version '0.21.0'
   id 'com.github.hierynomus.license' version '0.15.0'
   id 'io.spring.dependency-management' version '1.0.7.RELEASE'
   id 'me.champeau.gradle.jmh' version '0.4.8' apply false
-  id 'net.ltgt.errorprone' version '0.7.1'
-  id 'net.researchgate.release' version '2.7.0'
+  id 'net.ltgt.errorprone' version '0.8'
+  id 'net.researchgate.release' version '2.8.0'
 }
 
 group = 'tech.pegasys.pantheon'
@@ -160,7 +160,7 @@ allprojects {
     ]
 
     options.errorprone {
-      excludedPaths '.*/(generated/*.*|.*ReferenceTest_.*)'
+      excludedPaths = '.*/(generated/*.*|.*ReferenceTest_.*)'
 
       // Our equals need to be symmetric, this checker doesn't respect that.
       check('EqualsGetClass', CheckSeverity.OFF)

errorprone-checks/build.gradle

@@ -13,7 +13,7 @@
 
 // See https://github.com/tbroyer/gradle-errorprone-plugin
 // See https://github.com/tbroyer/gradle-apt-plugin
-plugins { id 'net.ltgt.apt' version '0.20' apply false }
+plugins { id 'net.ltgt.apt' version '0.21' apply false }
 
 // we use this config to get the path of the JDK 9 javac jar, to
 // stick it in the bootclasspath when running tests

ethereum/graphql/src/main/java/tech/pegasys/pantheon/ethereum/graphql/GraphQLHttpService.java

@@ -259,7 +259,7 @@ public class GraphQLHttpService {
           if (variableString != null) {
             variables = Json.decodeValue(variableString, MAP_TYPE);
           } else {
-            variables = null;
+            variables = Collections.emptyMap();
           }
           break;
         case POST:
@@ -275,7 +275,7 @@ public class GraphQLHttpService {
             // treat all else as application/graphql
             query = routingContext.getBodyAsString().trim();
             operationName = null;
-            variables = null;
+            variables = Collections.emptyMap();
           }
           break;
         default:

gradle/check-licenses.gradle

@@ -81,7 +81,7 @@ downloadLicenses {
           license('Apache Software Licenses', 'http://www.apache.org/licenses/LICENSE-2.0.txt'),
           license('Apache', 'http://www.opensource.org/licenses/Apache-2.0')
       ],
-      (mit)       : ['The MIT License', 'MIT'],
+      (mit)       : ['The MIT License', 'MIT', 'MIT license'],
       (bsd)       : [
           'BSD',
           'BSD licence',

gradle/versions.gradle

@@ -13,11 +13,11 @@
 
 dependencyManagement {
   dependencies {
-    dependency 'com.fasterxml.jackson.core:jackson-databind:2.9.8'
+    dependency 'com.fasterxml.jackson.core:jackson-databind:2.9.9'
 
     dependency 'com.github.docker-java:docker-java:3.0.14'
 
-    dependency 'com.google.auto.service:auto-service:1.0-rc4'
+    dependency 'com.google.auto.service:auto-service:1.0-rc5'
 
     dependency 'com.google.errorprone:javac:9+181-r4173-1'
     dependency 'com.google.errorprone:error_prone_check_api:2.3.3'
@@ -25,30 +25,30 @@ dependencyManagement {
     dependency 'com.google.errorprone:error_prone_annotation:2.3.3'
     dependency 'com.google.errorprone:error_prone_test_helpers:2.3.3'
 
-    dependency 'com.graphql-java:graphql-java:11.0'
+    dependency 'com.graphql-java:graphql-java:12.0'
     
     dependency 'com.google.guava:guava:27.1-jre'
 
-    dependency 'com.squareup.okhttp3:okhttp:3.13.1'
+    dependency 'com.squareup.okhttp3:okhttp:3.14.2'
 
     dependency 'commons-cli:commons-cli:1.4'
 
-    dependency 'info.picocli:picocli:3.9.5'
+    dependency 'info.picocli:picocli:3.9.6'
 
-    dependency 'io.pkts:pkts-core:3.0.4'
+    dependency 'io.pkts:pkts-core:3.0.5'
 
     dependency 'io.prometheus:simpleclient:0.6.0'
     dependency 'io.prometheus:simpleclient_common:0.6.0'
     dependency 'io.prometheus:simpleclient_hotspot:0.6.0'
     dependency 'io.prometheus:simpleclient_pushgateway:0.6.0'
 
-    dependency 'io.reactivex.rxjava2:rxjava:2.2.7'
+    dependency 'io.reactivex.rxjava2:rxjava:2.2.8'
 
-    dependency 'io.vertx:vertx-auth-jwt:3.6.3'
-    dependency 'io.vertx:vertx-codegen:3.6.3'
-    dependency 'io.vertx:vertx-core:3.6.3'
-    dependency 'io.vertx:vertx-unit:3.6.3'
-    dependency 'io.vertx:vertx-web:3.6.3'
+    dependency 'io.vertx:vertx-auth-jwt:3.7.1'
+    dependency 'io.vertx:vertx-codegen:3.7.1'
+    dependency 'io.vertx:vertx-core:3.7.1'
+    dependency 'io.vertx:vertx-unit:3.7.1'
+    dependency 'io.vertx:vertx-web:3.7.1'
 
     dependency 'junit:junit:4.12'
 
@@ -62,7 +62,7 @@ dependencyManagement {
     dependency 'org.apache.logging.log4j:log4j-core:2.11.2'
     dependency 'org.apache.logging.log4j:log4j-slf4j-impl:2.11.2'
 
-    dependency 'org.assertj:assertj-core:3.12.1'
+    dependency 'org.assertj:assertj-core:3.12.2'
 
     dependency 'org.awaitility:awaitility:3.1.6'
 
@@ -70,19 +70,19 @@ dependencyManagement {
 
     dependency 'org.java-websocket:Java-WebSocket:1.4.0'
 
-    dependency 'org.mockito:mockito-core:2.25.0'
+    dependency 'org.mockito:mockito-core:2.27.0'
 
     dependency 'org.openjdk.jmh:jmh-core:1.21'
     dependency 'org.openjdk.jmh:jmh-generator-annprocess:1.21'
 
     dependency 'org.rocksdb:rocksdbjni:5.15.10'
 
-    dependency 'org.springframework.security:spring-security-crypto:5.1.4.RELEASE'
+    dependency 'org.springframework.security:spring-security-crypto:5.1.5.RELEASE'
     
-    dependency 'org.web3j:abi:4.1.1'
-    dependency 'org.web3j:core:4.1.1'
-    dependency 'org.web3j:crypto:4.1.1'
+    dependency 'org.web3j:abi:4.3.0'
+    dependency 'org.web3j:core:4.3.0'
+    dependency 'org.web3j:crypto:4.3.0'
 
-    dependency 'org.xerial.snappy:snappy-java:1.1.7.2'
+    dependency 'org.xerial.snappy:snappy-java:1.1.7.3'
   }
 }

gradle/wrapper/gradle-wrapper.properties

@@ -1,5 +1,5 @@
 distributionBase=GRADLE_USER_HOME
 distributionPath=wrapper/dists
+distributionUrl=https\://services.gradle.org/distributions/gradle-5.4.1-bin.zip
 zipStoreBase=GRADLE_USER_HOME
 zipStorePath=wrapper/dists
-distributionUrl=https\://services.gradle.org/distributions/gradle-5.2.1-all.zip