Revert "Enable Eth/65 by Default (#1420)" (#1459)

This reverts commit 04b08e34cd.

Signed-off-by: Ratan Rai Sur <ratan.r.sur@gmail.com>
This commit is contained in:
Ratan (Rai) Sur
2020-10-15 14:47:40 -04:00
committed by GitHub
parent 58945b3935
commit eb945a26e4
3 changed files with 10 additions and 2 deletions

View File

@@ -43,7 +43,6 @@ Hyperledger Besu is moving its versioning scheme to [CalVer](https://calver.org/
* Added support for EIP-2929 to YOLOv2. [#1387](https://github.com/hyperledger/besu/pull/1387)
* Added `--start-block` and `--end-block` to the `blocks import` subcommand [\#1399](https://github.com/hyperledger/besu/pull/1399)
* Added support for multi-tenancy when using the early access feature of [onchain privacy group management](https://besu.hyperledger.org/en/stable/Concepts/Privacy/Onchain-PrivacyGroups/)
* Fixed memory leak in eth/65 subprotocol behavior. It is now enabled by default. [\#1420](https://github.com/hyperledger/besu/pull/1420), [#1348](https://github.com/hyperledger/besu/pull/1348), [#1321](https://github.com/hyperledger/besu/pull/1321)
* Added `--privacy-flexible-groups-enabled` as an alternative for `--privacy-onchain-groups-enabled` CLI option
### Bug Fixes
@@ -53,6 +52,7 @@ Hyperledger Besu is moving its versioning scheme to [CalVer](https://calver.org/
#### Previously identified known issues
- [Eth/65 loses peers](KNOWN_ISSUES.md#eth65-loses-peers)
- [Fast sync when running Besu on cloud providers](KNOWN_ISSUES.md#fast-sync-when-running-besu-on-cloud-providers)
- [Privacy users with private transactions created using v1.3.4 or earlier](KNOWN_ISSUES.md#privacy-users-with-private-transactions-created-using-v134-or-earlier)
- [Changes not saved to database correctly causing inconsistent private states](KNOWN_ISSUES.md#Changes-not-saved-to-database-correctly-causing-inconsistent-private-states)

View File

@@ -5,6 +5,14 @@ in the current release are provided in the [Changelog](CHANGELOG.md).
Known issues are open issues categorized as [Very High or High impact](https://wiki.hyperledger.org/display/BESU/Defect+Prioritisation+Policy).
## Eth/65 loses peers
From v1.4.4, `eth/65` is [disabled by default](https://github.com/hyperledger/besu/pull/741).
If enabled, peers will slowly drop off and eventually Besu will fall out of sync or stop syncing.
A fix for this issue is being actively worked on.
## Fast sync when running Besu on cloud providers
A known [RocksDB issue](https://github.com/facebook/rocksdb/issues/6435) causes fast sync to fail

View File

@@ -27,7 +27,7 @@ public class EthProtocolConfiguration {
public static final int DEFAULT_MAX_GET_RECEIPTS = 256;
public static final int DEFAULT_MAX_GET_NODE_DATA = 384;
public static final int DEFAULT_MAX_GET_POOLED_TRANSACTIONS = 256;
public static final boolean DEFAULT_ETH_65_ENABLED = true;
public static final boolean DEFAULT_ETH_65_ENABLED = false;
private final int maxGetBlockHeaders;
private final int maxGetBlockBodies;