Can pass arguments directly to docker

Dockerfile

@@ -38,7 +38,3 @@ EXPOSE 50051
 
 # Run the prover - shell script will build arguments with parsed env var
 ENTRYPOINT ["docker-entrypoint.sh"]
-
-# Define default env variables. These will be used if not overridden during `docker run`.
-ENV SERVICE_IP="0.0.0.0" \
-    SERVICE_PORT="50051"

Readme.md

@@ -3,7 +3,7 @@
 ## Docker
 
 * docker build --progress=plain --no-cache -t prover .
-* docker run -p 50051:50051 -e MOCK_SC="1" -e MOCK_USER="mock/mock_user_1.json" prover
+* sudo docker run -p 50051:50051 prover --mock-sc true --mock-user mock/mock_user_1.json
 
 ## Run
 

docker-entrypoint.sh

@@ -1,35 +1,12 @@
 #!/bin/bash
 
-# Array to hold the command-line arguments
-CMD_ARGS=()
+args_array=("$@")
+#for i in "${args_array[@]}"
+#do
+#  :
+#  echo "### Got variable $i ###"
+#done
+#echo "args_count = $#"
 
-CMD_ARGS+=("--ip" "${SERVICE_IP}")
-CMD_ARGS+=("--port" "${SERVICE_PORT}")
-
-if [ -n "$WS_RPC_URL" ]; then
-    CMD_ARGS+=("--ws-rpc-url" "${WS_RPC_URL}")
-fi
-
-if [ -n "$KARMA_SC_ADDRESS" ]; then
-    CMD_ARGS+=("--ksc" "${KARMA_SC_ADDRESS}")
-fi
-
-if [ -n "$RLN_SC_ADDRESS" ]; then
-    CMD_ARGS+=("--rlnsc" "${RLN_SC_ADDRESS}")
-fi
-
-if [ -n "$KARMA_TIERS_SC_ADDRESS" ]; then
-    CMD_ARGS+=("--tsc" "${KARMA_TIERS_SC_ADDRESS}")
-fi
-
-if [ -n "$MOCK_SC" ]; then
-    CMD_ARGS+=("--mock-sc" "true")
-fi
-
-if [ -n "$MOCK_USER" ]; then
-    CMD_ARGS+=("--mock-user" "${MOCK_USER}")
-fi
-
-echo "Starting rln-prover-service with arguments: ${CMD_ARGS[*]}"
 export RUST_LOG=debug
-exec ./status_rln_prover "${CMD_ARGS[@]}"
+exec ./status_rln_prover "${@}"

prover/src/tier.rs

@@ -39,13 +39,14 @@ impl DerefMut for TierLimits {
 }
 
 impl TierLimits {
-    /// Filter inactive Tier (rejected by validate)
+    /// Filter inactive Tier (rejected by function validate)
     pub(crate) fn filter_inactive(&mut self) -> Self {
         let map = std::mem::take(&mut self.0);
         let map_filtered = map.into_iter().filter(|(_k, v)| v.active).collect();
         Self(map_filtered)
     }
 
+    /// Validate tier limits (unique names, increasing min & max karma ...)
     pub(crate) fn validate(&self) -> Result<(), SetTierLimitsError> {
         #[derive(Default)]
         struct Context<'a> {