github/atom
1
1
Fork 0
mirror of https://github.com/atom/atom.git synced 2026-01-25 06:48:28 -05:00
Code Issues Packages Projects Releases Wiki Activity

Fix invalid usage of activation disposable in Package::load

Browse Source 
Like deserializers and config schema, directory providers are added
at package load time, and *not* removed when the package is deactivated
This commit is contained in:
Max Brunsfeld
2016-09-15 16:34:39 -07:00
parent 3758fe5646
commit 4fa24a05da
1 changed files with 1 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
src/package.coffee
View File

@@ -298,9 +298,7 @@ class Package
for version, methodName of directoryProviderService.versions
if typeof @mainModule[methodName] is 'function'
servicesByVersion[version] = @mainModule[methodName]()
disposable = @packageManager.serviceHub.provide('atom.directory-provider', servicesByVersion)
@activationDisposables.add(disposable)
@packageManager.serviceHub.provide('atom.directory-provider', servicesByVersion)
registerViewProviders: ->
if @metadata.viewProviders? and not @registeredViewProviders