Update LineNumberComponent correctly when "number" changes

This commit is contained in:
Ash Wilson
2018-07-27 10:18:42 -04:00
parent 0f771ea604
commit 65bcd888f3

View File

@@ -3427,14 +3427,17 @@ class LineNumberComponent {
this.element.style.marginTop = ''
}
}
if (this.props.number !== number) {
if (number) {
this.element.insertBefore(nodePool.getTextNode(number), this.element.firstChild)
} else {
if (this.props.number != null) {
const numberNode = this.element.firstChild
numberNode.remove()
nodePool.release(numberNode)
}
if (number != null) {
this.element.insertBefore(nodePool.getTextNode(number), this.element.firstChild);
}
}
this.props = props