github/atom
1
1
Fork 0
mirror of https://github.com/atom/atom.git synced 2026-01-23 13:58:08 -05:00
Code Issues Packages Projects Releases Wiki Activity

Update gutter container only once per frame unless its width changes

Browse Source 
Signed-off-by: Nathan Sobo <nathan@github.com>
This commit is contained in:
Antonio Scandurra
2017-04-24 14:35:17 +02:00
parent d92e0fc0a1
commit 97125ad083
1 changed files with 13 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

18
src/text-editor-component.js
View File

@@ -330,9 +330,7 @@ class TextEditorComponent {
measureContentDuringUpdateSync () {
if (this.remeasureGutterDimensions) {
if (this.measureGutterDimensions()) {
// TODO: Ensure we update the gutter container in the second phase of the update
}
this.measureGutterDimensions()
this.remeasureGutterDimensions = false
}
const wasHorizontalScrollbarVisible = this.isHorizontalScrollbarVisible()
@@ -456,6 +454,7 @@ class TextEditorComponent {
key: 'gutterContainer',
rootComponent: this,
hasInitialMeasurements: this.hasInitialMeasurements,
measuredContent: this.measuredContent,
scrollTop: this.getScrollTop(),
scrollHeight: this.getScrollHeight(),
lineNumberGutterWidth: this.getLineNumberGutterWidth(),
@@ -2564,8 +2563,17 @@ class GutterContainerComponent {
}
update (props) {
this.props = props
etch.updateSync(this)
if (this.shouldUpdate(props)) {
this.props = props
etch.updateSync(this)
}
}
shouldUpdate (props) {
return (
!props.measuredContent ||
props.lineNumberGutterWidth !== this.props.lineNumberGutterWidth
)
}
render () {