github/atom
1
1
Fork 0
mirror of https://github.com/atom/atom.git synced 2026-01-25 14:59:03 -05:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #17958 from cacheflow/add-capturing-to-keydown-events-when-hiding-tooltips

Browse Source 
Fix: Added capturing to keydown events when hiding tooltips
This commit is contained in:
David Wilson
2018-09-06 08:18:56 -07:00
committed by GitHub
parent dc91cb647d 52331786a2
commit d0ecc657ce
2 changed files with 5 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
spec/tooltip-manager-spec.js
View File

@@ -218,7 +218,9 @@ describe('TooltipManager', () => {
const disposable = manager.add(element, { title: 'Title' })
hover(element, function () {
expect(document.body.querySelector('.tooltip')).not.toBeNull()
window.dispatchEvent(new CustomEvent('keydown'))
window.dispatchEvent(new CustomEvent('keydown', {
bubbles: true
}))
expect(document.body.querySelector('.tooltip')).toBeNull()
disposable.dispose()
})

4
src/tooltip-manager.js
View File

@@ -153,11 +153,11 @@ class TooltipManager {
}
window.addEventListener('resize', hideTooltip)
window.addEventListener('keydown', hideTooltip)
window.addEventListener('keydown', hideTooltip, { capture: true })
const disposable = new Disposable(() => {
window.removeEventListener('resize', hideTooltip)
window.removeEventListener('keydown', hideTooltip)
window.removeEventListener('keydown', hideTooltip, { capture: true })
hideTooltip()
tooltip.destroy()