Commit Graph

4008 Commits

Author SHA1 Message Date
Nathan Sobo
3bc11ede77 Set the lines div height explicitly so it can be > 100% of parent
All editor specs pass
2012-11-09 14:25:59 -07:00
Nathan Sobo
c257a989be Account for 20 extra pixels on right of lines div in spec 2012-11-09 14:05:22 -07:00
Nathan Sobo
538c44f82b Fix bug caused by the fact that 0 <= null ===> true. God. damn. it. 2012-11-09 14:02:13 -07:00
Nathan Sobo
ee9ae449f3 💄 2012-11-09 13:43:28 -07:00
Nathan Sobo
0b9e22483e Update spec to match stricter maintenance of lastRenderedScreenRow 2012-11-09 13:40:49 -07:00
Nathan Sobo
5519929d8e Kill console.log 2012-11-09 13:38:27 -07:00
Nathan Sobo
4a3dbedb71 Fix spec to allow for 20 extra pixels to right of the lines 2012-11-09 13:28:51 -07:00
Corey Johnson & Nathan Sobo
e014f60f39 Update overdraw if scrolling beyond rendered lines in either direction
Also a few refactorings, and handle scroll height change in update lines
2012-11-09 13:27:05 -07:00
Corey Johnson & Nathan Sobo
507c12a0fa Highlight cursor line after updating rendered lines 2012-11-09 11:24:47 -07:00
Corey Johnson & Nathan Sobo
1996eaeb54 Preliminary approach to updating the gutter
This is just to get specs passing. We want to use the intact ranges to only render the exact lines that changed.
2012-11-09 11:17:42 -07:00
Corey Johnson & Nathan Sobo
7c16c48e2a Ensure underlayer and overlayer are always the same width as lines
Also… simplify CSS rules for lines element. No display table or padding, instead we just set the min width when typing.
2012-11-09 11:12:33 -07:00
Corey Johnson & Nathan Sobo
d739736997 Add underlayer / overlayer for the selection and cursor
The renderedLines div can now only contain actual lines, nothing else. Thes divs are designed to match the lines div in dimensions and make it easy to put things in front of or behind the text.
2012-11-09 10:43:58 -07:00
Corey Johnson & Nathan Sobo
e6f5a60b44 Hack to open unstable windows from atom-stable 2012-11-09 10:23:02 -07:00
Nathan Sobo
1f94b2aacc WIP: Handling display buffer changes. Cursor, selection specs failing
That's because the new CodeMirror-inspired line update code assumes that lines are the only thing in the rendered lines div.
2012-11-09 08:46:33 -07:00
Nathan Sobo
1d46da55da WIP: Borrowing from code mirror to update lines. Scrolling / resizing work, but not much else 2012-11-09 07:31:30 -07:00
Nathan Sobo
13117d9a61 Move checkout-head binding to alt-meta-z (meta-Z shadows redo)
This is my fault since I told Kevin to use this binding. Ooops.
2012-11-08 10:49:38 -07:00
Nathan Sobo
f136212677 Eliminate occasional rubber-band effect on document body on scroll 2012-11-07 19:56:49 -07:00
Nathan Sobo
cc7cd4df9a Oops. Fix broken specs. 2012-11-07 19:50:00 -07:00
Nathan Sobo
312f64d200 Don't make hidden input a child of Editor's scrollView
If the input element is a child of the scroll view, then focusing it can end up changing the scroll position of the view behind our backs. We *only* want to scroll the view via our interface on editor, because a bunch of of special code needs to run when we scroll. We can't just have the browser scrolling that view around willy-nilly.
2012-11-07 19:47:31 -07:00
Corey Johnson
1850da70e3 Ensure closing the application will call window.shutdown on each window. 2012-11-07 15:45:44 -08:00
Corey Johnson
e96d1b07d3 When a window is closed, the AtomCefClient is destroyed. 2012-11-07 15:45:44 -08:00
Corey Johnson
3860fe1de7 Add atom.log (passes message directly to NSLog) 2012-11-07 15:45:44 -08:00
Nathan Sobo
19fedbcffc 💄 2012-11-07 16:24:07 -07:00
Nathan Sobo
ce033ad6f7 Multiple changes by s///g commands are undone as a single transaction 2012-11-07 16:23:44 -07:00
Nathan Sobo
19c8a39fc8 Don't autoscroll to bottom of buffer on selectAll 2012-11-07 16:01:10 -07:00
Nathan Sobo
d1d3b45474 Don't focus the specs window in beforeEach 2012-11-07 16:00:39 -07:00
Nathan Sobo
144cfadb15 Update selection rendering when font size changes 2012-11-07 14:22:43 -07:00
Nathan Sobo
df392359f9 When font size changes, correctly adjust scrollable height
This requires updating the padding of the rendered lines and then adjusting the vertical scrollbar content height before updating any of the rendered lines. This fixes (hopefully all of) the rendering issues when adjusting the font size.
2012-11-07 14:09:31 -07:00
Nathan Sobo
693b110f1c 💄 2012-11-07 13:52:55 -07:00
Nathan Sobo
f33af85154 Backfill specs for not scrolling left when activating autocomplete 2012-11-07 13:26:00 -07:00
Nathan Sobo
66efc80373 Fix broken spec 2012-11-07 13:05:03 -07:00
Nathan Sobo
cd9e3b774a Always move the hidden input element to the cursor's screen location
This avoids spuriously auto-scrolling to the left when opening an autocomplete in an editor that's scrolled to the right.
2012-11-07 13:04:54 -07:00
Nathan Sobo
d44e116321 Don't highlight the current line unless the selection is empty 2012-11-07 12:11:33 -07:00
Nathan Sobo
72d25b405f Don't show dev tools by default during specs. They steal the focus. 2012-11-07 12:04:47 -07:00
Nathan Sobo
11d8192221 Show docked dev tools synchronously.
This commit fixes the sizing issues that were forcing the asynchronous hack. It also makes the split view divider dark gray like in chrome.
2012-11-07 11:20:12 -07:00
Nathan Sobo
6145605849 Still focus the browser when window becomes main 2012-11-06 18:18:34 -07:00
Corey Johnson & Nathan Sobo
a613fdf8a9 Make browser properly unfocus when resigning main window status 2012-11-06 16:58:43 -07:00
Corey Johnson
920a81f7c9 Merge pull request #94 from github/atomic-soft-tabs
Atomic soft tabs
2012-11-06 11:56:39 -08:00
Corey Johnson & Nathan Sobo
8184c0248b Don't store tabLength on EditSession 2012-11-06 11:56:18 -08:00
Corey Johnson & Nathan Sobo
b8beec6f55 Remove foldable from ScreenLine 2012-11-06 11:41:48 -08:00
Corey Johnson & Nathan Sobo
139f5d0b50 EditSession.setTabLength assigns tabLength on the TokenizedBuffer. 2012-11-06 11:35:13 -08:00
Corey Johnson & Nathan Sobo
78a24e1e9c Remove @fold from Token 2012-11-06 11:15:18 -08:00
Corey Johnson & Nathan Sobo
dacb5f063f Remove unused references to stateForScreenRow 2012-11-06 11:13:42 -08:00
Corey Johnson & Nathan Sobo
874af0f2bc Eliminate reference to TokenizedBuffer on EditSession 2012-11-06 11:09:38 -08:00
Corey Johnson & Nathan Sobo
10090219cb TokenizedBuffer change events reference the precipitating Buffer change event. 2012-11-06 10:56:05 -08:00
Corey Johnson & Nathan Sobo
0e0f747764 TokenizedBuffer.setTabLength retokenizes the entire buffer 2012-11-06 10:44:50 -08:00
Corey Johnson & Nathan Sobo
2c14bc7ebd Optimize breakOutAtomicTokens 2012-11-06 10:44:03 -08:00
Corey Johnson & Nathan Sobo
be424c365f 💄 2012-11-06 10:03:02 -08:00
Corey Johnson
d65f13b218 💄 2012-11-06 09:41:35 -08:00
Corey Johnson
a63f838cdb Simplify breakOutAtomicTokens method 2012-11-06 09:39:44 -08:00