Commit Graph

12958 Commits

Author SHA1 Message Date
Nathan Sobo
54549f916a Change assertion API to pass error to callback
Don’t assume anything about metadata. Just give assertion callers access
to the error object.

Signed-off-by: Max Brunsfeld <maxbrunsfeld@gmail.com>
2015-07-07 19:29:23 -05:00
Nathan Sobo
4091fa9e78 Merge pull request #7770 from atom/ns-only-forward-menu-action-on-osx
Handle native chromium undo, redo, cut, copy, paste, selectAll on all platforms
2015-07-07 19:26:04 -05:00
Nathan Sobo
a4d716c491 Call native method on WebContents instead of sendActionToFirstResponder
Fixes #6587
2015-07-07 16:34:35 -05:00
Kevin Sawicki
a6dfbb2804 Remove string detail check
This appears to be in use by other packages

Refs atom/notifications#50
2015-07-07 13:46:53 -07:00
Kevin Sawicki
3a02b54851 details -> detail 2015-07-07 13:46:53 -07:00
Kevin Sawicki
93069fad75 Add stricter object checking 2015-07-07 13:46:53 -07:00
Kevin Sawicki
7fbcd147d5 Make Notification::getDetail public 2015-07-07 13:46:53 -07:00
Kevin Sawicki
4ba552c515 Valid message, options, and detail 2015-07-07 13:46:52 -07:00
Kevin Sawicki
2e2fef0c47 Merge pull request #7768 from atom/iz-more-guards-in-pane-error-handling
Guard against non-string messages in Pane.handleSaveError
2015-07-07 11:09:29 -07:00
Ivan Žužak
cd31770121 Guard against non-string messages in Pane.handleSaveError 2015-07-07 19:51:16 +02:00
Ross Allen
178fffa74e Add 'name' arg docs to PackageManager functions 2015-07-07 10:49:45 -07:00
Kevin Sawicki
34d3dadd51 📝 Mention --include-deprecated-apis is not currently supported 2015-07-07 10:42:22 -07:00
Kevin Sawicki
b852b06724 Merge pull request #7717 from atom/iz-pane-handle-save-error
Check if error message exists before using it in Pane.handleSaveError
2015-07-07 10:14:28 -07:00
Kevin Sawicki
b371b2f0c9 Guard against missing stdout/stderr 2015-07-07 09:50:07 -07:00
Max Brunsfeld
1761f19efb Merge pull request #7748 from atom/mb-emit-will-insert-text-on-paste
Emit will-insert-text event when pasting
2015-07-07 09:14:07 -07:00
Antonio Scandurra
4e4b49eef8 🐛 updateContentDimensions when model changes 2015-07-07 11:28:30 +02:00
Max Brunsfeld
8c3400c084 Emit will-insert-text event when pasting 2015-07-06 18:29:44 -07:00
Kevin Sawicki
30dccf987d Require dialog and shell early in browser process
Prevents issues when the asar bundle changes before these
files are required.
2015-07-06 16:49:59 -07:00
Nathan Sobo
5fe00dc803 Merge pull request #7733 from atom/as-remove-leftover-updates
Remove leftover update statements
2015-07-06 16:49:14 -05:00
Ben Ogle
5d42b27f5f Merge pull request #7411 from deprint/multiline-mini-editor
Mini editor with TextEditor::setMini
2015-07-06 13:56:20 -07:00
Antonio Scandurra
b07f5eb8ad 💚 2015-07-06 16:37:17 +02:00
Antonio Scandurra
251f0293b7 🔥 🐎 Remove leftover update statements 2015-07-06 15:41:20 +02:00
Ivan Zuzak
f9a54ae552 Check if error message exists before using it 2015-07-05 08:35:26 +02:00
Nounours Heureux
481b83c1ac Set a default statement 2015-07-04 11:43:54 +02:00
Nounours Heureux
d663a43b27 Different title for file dialogs and folder dialogs. 2015-07-03 19:43:10 +02:00
Nathan Sobo
e529d1e345 Request contents of buffer when first-mate tags are in a corrupt state 2015-07-01 16:46:09 -05:00
Nathan Sobo
550efc8397 Merge pull request #7633 from atom/ns-pane-items-must-be-objects
Throw an exception when adding a non-object pane item
2015-07-01 14:09:14 -05:00
Nathan Sobo
8ea36a6ac5 In invalid scope exception: include grammar metadata, ask for details 2015-07-01 13:59:47 -05:00
Nathan Sobo
8348b2c039 Throw exception when adding a non-object pane item 2015-07-01 13:29:13 -05:00
Nathan Sobo
e472830063 Merge remote-tracking branch 'origin/master' into dsandstrom-add-subword-cursors-4 2015-06-30 22:55:40 -05:00
Nathan Sobo
ba3ab41f1f Eliminate hack to move cursor to beginning of buffer
Use the structure of the regex plus a fix to text-buffer instead.
2015-06-30 22:52:35 -05:00
Ben Ogle
4d77d4161d Merge pull request #7395 from oggy/will-remove-item
Add Pane::onWillRemoveItem event.
2015-06-30 15:25:16 -07:00
Nathan Sobo
8b088926bb Merge pull request #7602 from atom/ns-mixed-indent
Restore support for mixed tabs and spaces in line indentation
2015-06-30 15:54:47 -05:00
Nathan Sobo
83bddaf34e Merge branch 'master' into add-subword-cursors-4
Conflicts:
	spec/text-editor-spec.coffee
2015-06-30 15:43:33 -05:00
Nathan Sobo
82e25872b2 Handle indentation with mixed tabs and spaces 2015-06-30 15:31:11 -05:00
Nathan Sobo
c9a8585b49 🎨 2015-06-30 15:30:58 -05:00
Nathan Sobo
1d8035c3cc Back out changes to onDidThrowError API 2015-06-30 15:30:58 -05:00
Nathan Sobo
5d957b677b Revert "Merge pull request #7373 from atom/revert-7350-ns-assertions"
This reverts commit 1a3441a503, reversing
changes made to 1aab5e74d9.
2015-06-30 15:30:58 -05:00
Antonio Scandurra
6735357dd1 Retrieve backgroundColor from the correct object
Thanks, @nathansobo! 
2015-06-30 14:46:29 +02:00
Antonio Scandurra
8cd9128bec Merge branch 'master' into as-tiled-gutter 2015-06-30 14:40:44 +02:00
Nathan Sobo
b580012173 Merge pull request #7563 from atom/ns-tabs-or-spaces-pick-one
Consider tabs or spaces mutually exclusively as indentation
2015-06-29 19:19:44 -05:00
Nathan Sobo
4af7f1e29d Merge branch 'master' into as-tiled-gutter 2015-06-29 18:37:17 -05:00
Nathan Sobo
32705ab372 Merge branch 'master' into as-tiled-gutter 2015-06-29 17:10:45 -05:00
Nathan Sobo
b6d099ac78 Consider tabs or spaces mutually exclusively as indentation
Previously, we allowed a mix of tabs and spaces to be counted toward the
indentation of a line. This caused problems when auto-indenting lines in
a hard-tabbed file that contained “alignment spaces”, such as occurs in
aligned comment blocks. For this case, it makes more sense to assume
that the line is indented via tabs only, and consider the subsequent
alignment space as part of the line’s content. Since it’s hard to
imagine actual source code in which a mixed treatment of tabs and spaces
is desirable, I’m going with this over any more complex approach.
2015-06-29 17:05:28 -05:00
Kevin Sawicki
9c4dd71de2 Remove deferred browser process requires 2015-06-29 13:30:37 -07:00
Nounours Heureux
b7b9a9fb88 The ellipsis character is now recognized as punctuation 2015-06-26 15:36:12 +02:00
Fabian Stiewitz
19315390cf TextEditorElement: Add callback for TextEditor::onDidChangeMini 2015-06-26 11:45:38 +02:00
Kevin Sawicki
85a4ae7fea Remove --include-deprecated-apis command line option 2015-06-24 16:51:48 -04:00
Kevin Sawicki
0fa514b6e1 Remove open with deprecated APIs commands 2015-06-24 16:51:47 -04:00
George Ogata
8a5dfeae05 Add Pane::onWillRemoveItem event. 2015-06-24 00:16:45 -04:00