Nathan Sobo
b7a8ddd153
Revert "Add assertion mechanism"
2015-06-22 14:27:05 -05:00
Kevin Sawicki
aa2530cb4e
Merge pull request #7360 from atom/iz-blow-up-on-undefined-command-callback
...
Throw error for commands registered with non-function callbacks
2015-06-22 11:10:17 -07:00
Kevin Sawicki
2192099d0f
Merge pull request #7351 from atom/mq-optional-clipboard-metadata
...
Mark Clipboard::write's metadata argument as optional
2015-06-22 11:02:01 -07:00
Nathan Sobo
1fe873740f
Merge pull request #7350 from atom/ns-assertions
...
Add assertion mechanism
2015-06-22 12:18:44 -05:00
Ivan Zuzak
9aa78606b3
Catch both string and object targets
2015-06-22 18:47:41 +02:00
Kevin Sawicki
648b46eb39
Merge pull request #7348 from tony612/fix-doc-for-text-editor-setText
...
fix doc for TextEditor setText
2015-06-22 09:28:03 -07:00
Ivan Zuzak
d47737718b
Throw error for commands with non-function callbacks
2015-06-22 08:30:01 +02:00
Ivan Žužak
852456fafe
Merge pull request #7173 from atom/ns-prompt-on-large-files
...
Show a warning prompt when opening files over 20MB
2015-06-21 18:17:59 +02:00
Ivan Žužak
d32f30780a
Massage the message a bit more
2015-06-21 17:48:32 +02:00
Machisté N. Quintana
4e1d47b09f
📝 Mark Clipboard::write's metadata argument as optional
2015-06-20 12:45:47 -04:00
Nathan Sobo
d1057b5de7
Fill error message in if needed for package specs
2015-06-20 18:37:54 +02:00
Nathan Sobo
a24816f76b
Handle null errors to support existing uses in tests
2015-06-20 18:37:54 +02:00
Nathan Sobo
64fca5db20
Absorb exception in isFoldableCodeAtRow and report assertion failure
...
Can’t figure out what’s going on in this bug, but we can hopefully make
it less damaging and collect more information via the new assertion
system.
Refs #5905
2015-06-20 18:37:53 +02:00
Nathan Sobo
11c3b3444b
Return a boolean from atom.assert
2015-06-20 18:37:53 +02:00
Nathan Sobo
a1f6a15c0b
Add atom.assert and atom.onDidFailAssertion
2015-06-20 18:37:53 +02:00
Nathan Sobo
cd35107f8c
Call atom.onDidThrowError handlers with the error object
...
…and remove a bunch of dead source maps handling. Source map handling
for stack traces is now built into Chromium so it shouldn’t be needed
here.
Original event properties maintained for backward compatibility with the
1.0 API. Can be deprecated for 2.0 once we transition
exception-reporter.
2015-06-20 18:37:53 +02:00
Tony Han
776eee2413
📝 fix doc for TextEditor setText
2015-06-20 17:58:31 +08:00
Antonio Scandurra
d6ac7863c9
Merge branch 'master' into as-tiled-gutter
2015-06-19 20:12:43 +02:00
Max Brunsfeld
ca146c991a
Merge pull request #7341 from atom/as-remove-orphaned-gutter-events
...
Remove event listeners from orphaned gutters
2015-06-19 10:52:17 -07:00
Kevin Sawicki
bde74dee0b
Merge pull request #7281 from atom/sm-default-editor-font
...
New default editor font
2015-06-19 09:12:18 -07:00
simurai
533abc5a63
Increase default line height even a bit more
2015-06-19 21:31:36 +09:00
Antonio Scandurra
d7156ff387
Remove event listeners from orphaned gutters
2015-06-19 10:24:48 +02:00
Antonio Scandurra
26b1d166fd
Merge pull request #7320 from atom/as-remove-gutter-from-view-registry
...
Fix TextEditorComponent Race Condition
2015-06-19 09:01:59 +02:00
simurai
2017e3fe23
Increase default line height
2015-06-19 10:22:26 +09:00
Antonio Scandurra
a3a8d8417b
Merge branch 'as-remove-gutter-from-view-registry' into as-tiled-gutter
2015-06-18 19:58:33 +02:00
Antonio Scandurra
c8f24d2358
Revert " 🐛 Remove Gutter from ViewRegistry"
...
This reverts commit b0d93accf7
2015-06-18 19:54:37 +02:00
Max Brunsfeld
64dfda572d
Use raw buffer text (w/o invisibles) when testing decreaseIndentRegex
2015-06-17 12:07:42 -07:00
Max Brunsfeld
3cdeaa8b51
Don't auto-indent when pasting text w/ no line breaks
2015-06-17 10:57:21 -07:00
Antonio Scandurra
b04b0a8dc4
🐛 Fix race condition as well
2015-06-17 13:48:31 +02:00
Antonio Scandurra
b0d93accf7
🐛 Remove Gutter from ViewRegistry
...
Closes #7306
We started noticing that when a `TextEditor` pane got split, the same view for
`Gutter` was being shared amongst several models, thereby making the same DOM
element accessible simultaneously by more than one object. This made us
experience *orphaned line numbers*, caused by two instances of
`LineNumberGutterComponent` mutating `.line-numbers` at the same time.
This is a typical race condition which I would normally address by understanding
and possibly locking the correct order in which operations should happen.
However, I believe in this situation we shouldn’t actually care about ordering
at all, since I think views should be kept “local”, thus avoiding to expose them
to the world and/or reusing them across other views (either accidentally as in
this case or on purpose).
2015-06-17 12:28:10 +02:00
Max Brunsfeld
dbb1200e1b
🔥 unused method
2015-06-16 14:54:01 -07:00
aki
449c03cb35
Fix destroy listeners
2015-06-16 18:05:45 +09:00
Max Brunsfeld
41773b0861
Fix incorrect state save when exiting
2015-06-15 14:14:08 -07:00
simurai
e4ba689e40
Replaces default editor font
...
Only affects OS X
2015-06-15 16:03:50 +09:00
Antonio Scandurra
a7ff49ebaa
🎨
2015-06-13 17:36:20 +02:00
Antonio Scandurra
e190d441ed
🔥
2015-06-13 14:25:50 +02:00
Antonio Scandurra
e893b5105b
Remove presenter as a dependency where possible
...
Although we have a couple of components which still access it, we
agreed it would have been just better to avoid relying on
`TextEditorPresenter` where possible and use it purposefully in other
places (e.g. `LinesComponent` which needs it to store text
measurements).
/cc: @jssln
2015-06-13 14:18:36 +02:00
Max Brunsfeld
715238c3cd
Add by clauses to for loops to avoid complex loop increments
2015-06-12 16:38:07 -07:00
Max Brunsfeld
6282e7e533
Merge pull request #7234 from atom/mb-keep-state-when-auto-updating
...
Avoid saving state when closing windows due to auto-update
2015-06-12 10:50:57 -07:00
Max Brunsfeld
c43233892b
Merge pull request #7225 from lpommers/add-remove-cursor-when-there-are-multiple-cursors-if-cmd-clicking-on-it
...
Add remove cursor when there are multiple cursors and cmd clicking on it
2015-06-12 10:41:17 -07:00
Antonio Scandurra
b6049857ed
🎨
2015-06-12 19:00:15 +02:00
Antonio Scandurra
374aaac7b5
Rename to LinesTileComponent
2015-06-12 18:32:40 +02:00
Antonio Scandurra
6bff934b76
🎨
2015-06-12 18:22:43 +02:00
Antonio Scandurra
7ac0cdcbf5
Start porting TextEditorComponent spec
2015-06-12 18:22:33 +02:00
Antonio Scandurra
13087eb58e
Handle Max Line Number Digits
2015-06-12 12:39:24 +02:00
Antonio Scandurra
d45fc8a41f
Port TextEditorPresenter specs
2015-06-12 12:10:55 +02:00
Antonio Scandurra
f1c5745780
Merge branch 'master' into as-tiled-gutter
2015-06-12 10:49:19 +02:00
Antonio Scandurra
d14e7b9456
Enable maxLineNumberDigits
2015-06-12 10:41:50 +02:00
Luke Pommersheim
9f0f4c0530
refactor getCursorAtScreenPosition to avoid temporary array
2015-06-12 08:38:25 +02:00
Luke Pommersheim
3b3dc83a38
📝 updating docs for getCursorAtScreenPosition - can also take an {Array}
2015-06-12 08:36:44 +02:00
