Commit Graph

5459 Commits

Author SHA1 Message Date
Kevin Sawicki & Nathan Sobo
aaf22a9433 Nuke commented code 2013-02-05 16:47:21 -07:00
Kevin Sawicki & Nathan Sobo
0d6d89b209 Fix cursor autoscrolling when position doesn't change
When assigning the cursor's position, if we decide we want to autoscroll,
we should do so even if the cursor's position doesn't change.

The previous approach relied on a comparison of the position being
assigned, but this is before it has been clipped. Now we rely on a
boolean return value from the marker position assignment methods, which
tells us if the position has changed. If not, we need to emit our own
event to force autoscrolling.
2013-02-05 16:37:54 -07:00
Kevin Sawicki & Nathan Sobo
85111748ec Reset spy in spec before making next assertion 2013-02-05 16:34:36 -07:00
Kevin Sawicki & Nathan Sobo
5a1de9fa44 Add specs for truthiness of marker position assignment return values 2013-02-05 16:33:59 -07:00
Kevin Sawicki & Nathan Sobo
0465940e05 Merge remote-tracking branch 'origin/dev' into markers 2013-02-05 16:12:35 -07:00
Kevin Sawicki
a144b054e3 Use line height instead of char height 2013-02-05 15:11:26 -08:00
Kevin Sawicki & Nathan Sobo
75e040b73b Merge remote-tracking branch 'origin/dev' into markers
Conflicts:
	src/app/editor.coffee
2013-02-05 16:07:05 -07:00
Kevin Sawicki & Nathan Sobo
3dab8e92ee Convert snippets to use markers instead of anchor ranges 2013-02-05 15:54:41 -07:00
Kevin Sawicki & Nathan Sobo
94d1edcc06 Add EditSession.selectMarker 2013-02-05 15:54:20 -07:00
Kevin Sawicki & Nathan Sobo
c893f0c338 Add Buffer.markersForPosition and coerce marker ids to strings 2013-02-05 15:50:54 -07:00
Kevin Sawicki & Nathan Sobo
240e893d33 Don't emit a cursor-moved event when only the tail of the marker moves 2013-02-05 15:19:10 -07:00
Kevin Sawicki
3e84e9886c Break out event handler setup into separate method
This mirrors the keymap setup method and allows specs
to reattach handlers after calling shutdown()
2013-02-05 13:17:53 -08:00
Kevin Sawicki
17825edf66 Use off() instead of unbind()
unbind() is so pre-jQuery 1.7
2013-02-05 13:13:01 -08:00
Kevin Sawicki
ba811c4119 Un-f a window spec 2013-02-05 12:59:26 -08:00
Justin Palmer
6cffa3ba93 Merge pull request #236 from github/window-focus-events
fix blur and focus events for the window
2013-02-05 12:57:53 -08:00
Justin Palmer
8512bee6c9 merge dev, fix conflicts 2013-02-05 12:42:44 -08:00
Nathan Sobo
1d30605f7f Convert selection and cursor fully over to markers. 2013-02-05 13:39:00 -07:00
Kevin Sawicki
8de45ccc21 Bind meta-D to duplicate line below
Refs #134
2013-02-05 12:16:50 -08:00
Kevin Sawicki
ad3c18077c Compare against EOF position when clipping
Previously the column could potentially be set to
zero since a Math.min comparison was used for the
length of an already adjusted row.
2013-02-05 12:08:17 -08:00
Justin Palmer & Nathan Sobo
65927ea0cf fix window blur and focus events 2013-02-05 12:03:56 -08:00
Justin Palmer
44df146034 remove console debug line 2013-02-05 11:00:01 -08:00
Justin Palmer
22770bd663 add onBlur and onFocus events for the window
This allows us to simulate those events and test for them easier
2013-02-05 10:53:35 -08:00
Kevin Sawicki
7ecafb1594 Don't include tag prefix and suffix
Just include the tag name in the symbols view
instead of the lengthy namespace prefix and signature
suffix.

Refs #134
2013-02-05 10:04:37 -08:00
Kevin Sawicki
1b2c7faed9 Bind ctrl-meta-f to toggle full screen
Refs #134
2013-02-05 09:36:38 -08:00
Kevin Sawicki
9011d62351 Use octicon for README files 2013-02-05 09:17:47 -08:00
Justin Palmer
6f34c94014 Merge pull request #232 from github/focus-invert
Focus invert
2013-02-05 09:13:32 -08:00
Kevin Sawicki
dbebb91908 Add back README to template packages directory 2013-02-05 09:08:41 -08:00
Jon Rohan
03055441a9 treeview blurred was missing some desaturation 2013-02-05 09:01:29 -08:00
Jon Rohan
8347b14ab3 the tabs needed some is-blurred action for the active tab 2013-02-05 08:59:21 -08:00
Justin Palmer
5af967ac4b update blurred styles for atom-light-ui 2013-02-05 08:46:54 -08:00
Kevin Sawicki
7a88e4bdb6 Add markdown link color 2013-02-05 08:41:54 -08:00
Justin Palmer
0bd6ce7ae1 more subtle look for blurred state in atom-dark-ui 2013-02-05 08:38:08 -08:00
Justin Palmer
55d282fdd4 valid json 2013-02-05 08:22:14 -08:00
Justin Palmer
dd7835faf4 merge dev, fix conflicts 2013-02-05 08:18:59 -08:00
Kevin Sawicki
3514048893 Exclude background window from expose
Previously you would see an untitled empty space
when showing application windows with ctrl-down.
2013-02-04 21:20:37 -08:00
Kevin Sawicki
651d305f76 Add package namespace to command registration 2013-02-04 20:56:25 -08:00
Kevin Sawicki
b0b38079e0 Migrate template config file to cson 2013-02-04 20:50:14 -08:00
Kevin Sawicki
39e39afa1b Bind ctrl-j to jump to matching bracket 2013-02-04 20:38:50 -08:00
Nathan Sobo
afe0a6570a Reduce observation to single observeMarker method on display buffer
It will call the observer callbacks with the buffer and screen positions
of the head and tell each time any of these values is changed.
2013-02-04 21:24:06 -07:00
Nathan Sobo
58450d6a65 Give Buffer only a single observeMarker method
It will fire the callback whenever the marker's head or tail position
changes, and it's up to the subscriber to use the information how they
want to.
2013-02-04 20:35:30 -07:00
Nathan Sobo
852b4c2f8a Merge remote-tracking branch 'origin/dev' into markers 2013-02-04 20:04:01 -07:00
Kevin Sawicki
b30fae7a68 Remove event handlers when editor is removed 2013-02-04 18:24:54 -08:00
Kevin Sawicki
0270ba3e1c Add bracket matcher that highlights pair
(), {}, and [] pairs are now highlighted when
after or before the cursor
2013-02-04 18:09:20 -08:00
Justin Palmer
eb8d6f9766 fix textmate editor specs 2013-02-04 17:07:27 -08:00
Justin Palmer
fa0d5b4ab2 add blurred css 2013-02-04 16:50:32 -08:00
Justin Palmer
022b5fb88c use is-focused for the editor because it needs it's own state independent of the window state 2013-02-04 16:42:46 -08:00
Justin Palmer
aa95590e6c kill is-focused on the dark tree-view 2013-02-04 16:20:40 -08:00
Justin Palmer
f8855ef2e3 the editor has it's own blurred state independent of the window 2013-02-04 16:20:07 -08:00
Justin Palmer
951f6128ca kill some is-focused tab styles 2013-02-04 16:06:52 -08:00
Justin Palmer
4350be62c6 💀 is-focused.
targeting blurred state instead so normal state styles don't need a
special prefix
2013-02-04 16:02:09 -08:00