Commit Graph

6294 Commits

Author SHA1 Message Date
Antonio Scandurra
582fa571b8 📝 Better spec description 2015-10-14 16:20:42 +02:00
Antonio Scandurra
6b01811d20 Avoid stack overflow when scrolling with non-integer values
We were mistakenly using the rounded scroll top to guard against such cases.
This fixes it by using `@realScrollTop` instead.
2015-10-14 16:10:12 +02:00
Antonio Scandurra
4b10f8a2b0 🔥 Avoid mocking atom.config in spec-helper 2015-10-14 12:47:33 +02:00
Antonio Scandurra
b25d3e944b Parameterize configDirPath and move config.load in ctor 2015-10-14 12:41:36 +02:00
Antonio Scandurra
d9af8686ed 🔥 Avoid attaching CommandRegistry to window twice 2015-10-14 10:29:56 +02:00
Nathan Sobo
74d644ac73 Clear GrammarRegistry in AtomEnvironment::reset 2015-10-13 20:09:56 -06:00
joseramonc
29dfd1c904 add moveLineUp and moveLineDown specs 2015-10-13 21:07:46 -05:00
Nathan Sobo
3ef6a9b63b Remove workspaceParentSelector and always attach to document body
Tests never call startEditorWindow anyway.
2015-10-13 19:54:29 -06:00
Nathan Sobo
903ecca1f7 Parameterize document on AtomEnvironment 2015-10-13 19:48:56 -06:00
Nathan Sobo
65ae175e72 Pass explicit window global into AtomEnvironment on construction 2015-10-13 19:35:51 -06:00
Nathan Sobo
84aa8471b4 Pass AppDelegate to Workspace, Pane instead of bound functions
Signed-off-by: Max Brunsfeld <maxbrunsfeld@github.com>
2015-10-13 18:54:48 -06:00
Nathan Sobo
432a59b8e5 Move tests from window-event-handler-spec for moved functionality
Signed-off-by: Max Brunsfeld <maxbrunsfeld@github.com>
2015-10-13 17:53:01 -06:00
Nathan Sobo
919571f328 Use ApplicationDelegate in WindowEventHandler
Signed-off-by: Max Brunsfeld <maxbrunsfeld@github.com>
2015-10-13 17:29:41 -06:00
Nathan Sobo
e92cb86335 Introduce ApplicationDelegate to AtomEnvironment
All external actions are performed via this delegate for test-isolation
purposes.
2015-10-13 15:42:57 -06:00
Nathan Sobo
a8ca3165a0 Remove dead code 2015-10-13 14:46:28 -06:00
Max Brunsfeld
47961a8e6b Fix setting default values in config 2015-10-13 11:00:53 -07:00
Antonio Scandurra
6459891c89 💚 Make sure to destroy AtomEnvironment in specs 2015-10-13 15:30:45 +02:00
Dave Rael
4312f76ed7 Added command line parameter to set portable
If parameter included, home directory will be copied to the portable
location to make this a portable install
2015-10-13 05:43:01 -06:00
Antonio Scandurra
e51bad5618 🐛 Install WindowEventHandler in ctor 2015-10-13 12:38:45 +02:00
Antonio Scandurra
cf5d94f084 Return a promise in test runners 2015-10-13 09:02:37 +02:00
Nathan Sobo
f7a3e6c425 Don’t load base style sheets until config is loaded
We need to know what themes are active in order to load the correct LESS
variables.
2015-10-12 16:12:46 -06:00
Nathan Sobo
d4c88cc7fd Merge branch 'master' into ns-alternative-test-env 2015-10-12 15:55:28 -06:00
Nathan Sobo
69e8b0cfb1 Prevent title change during specs 2015-10-12 15:19:55 -06:00
Nathan Sobo
79d9a13ea7 Fix ENOENT exceptions in text-editor-spec 2015-10-12 15:09:28 -06:00
Nathan Sobo
c82e331b7d Return a Disposable from mocked method to avoid exception it specs 2015-10-12 14:12:13 -06:00
abe33
d8aba0d295 🎨 Improve test descriptions and fix a typo 2015-10-12 22:10:09 +02:00
abe33
45a3dbca4e 🐛 Fix folds not preserved when moving multiple selections down
When two or more selections span the rows immediately before a fold,
the `did-change` event dispatched on the deletion will trigger a merge
of the selections, which in turn trigger an unfold at the buffer
position of the new selection, which is now the position of the fold.
Consolidating the selections at the begin of the transaction will
prevent the merge and will keep the fold untouched.
2015-10-12 22:05:25 +02:00
Nathan Sobo
29fe98581e Don’t assign atom.themes.workspace in spec-helper 2015-10-12 13:54:35 -06:00
abe33
d68a0db6d2 🎨 Fix description test
Actually it doesn’t test multiple selections moves.
2015-10-12 21:16:07 +02:00
Ross Allen
41984a2317 Add onDidStopChangingActivePaneItem for async callbacks
`onDidChangeActivePaneItem` is called synchronously when the active pane
item changes, and several non-critical actions preform work on that
event. Critical UI feedback, like changing the active tab, needs to
happen synchronously, but most other functionality should be run
asynchronously.
2015-10-12 10:24:07 -07:00
Antonio Scandurra
56e13bba69 Reset Workspace in AtomEnvironment 2015-10-12 15:01:00 +02:00
Antonio Scandurra
aebc1229f1 Always install uncaught error handler 2015-10-12 08:29:43 +02:00
abe33
09ffa8bec9 🐛 Fix moving multiple selections down locked at wrapped line 2015-10-11 18:15:06 +02:00
Antonio Scandurra
5d6713f6fa Pass deserializerManager in Workspace 2015-10-11 18:11:54 +02:00
abe33
f4f4b9fdef Merge branch 'master' into pr/8232 2015-10-11 14:23:36 +02:00
Max Brunsfeld
74c0836be5 🔥 Duplicate devMode/inDevMode parameter to Package, PackageManager 2015-10-09 17:34:22 -07:00
Max Brunsfeld
75463829f9 Pass inDevMode to package-manager as a boolean value
Rather than as a bound function
2015-10-09 17:26:19 -07:00
Max Brunsfeld
369f3d2648 Don't use atom.{notifications,config,deserializers,confirm} in Pane
Still need to get rid of one use of showSaveDialogSync
2015-10-09 17:18:26 -07:00
Max Brunsfeld
b467c83e76 Remove unused requires in spec-helper 2015-10-09 13:46:51 -07:00
Max Brunsfeld
778023c78b Make factory for StylesElements on atom.styles 2015-10-09 13:46:32 -07:00
Dave Rael
28c322a4cf Fix broken focused suite in spec 2015-10-09 11:32:56 -06:00
Dave Rael
b8a153781e Implement Portable Mode
According to these specifications:
Portable mode only applies to Windows (for now)
Portable mode only applies if ATOM_HOME is not set
If there is a .atom directory as sibling to directory with running process
	use that as ATOM_HOME
2015-10-09 11:20:41 -06:00
Antonio Scandurra
60e4b78da3 Move package reset down into PackageManager 2015-10-09 10:04:04 +02:00
Max Brunsfeld
43d0241685 Reset project in AtomEnvironment::reset 2015-10-08 17:54:43 -07:00
Max Brunsfeld
7617c35856 Rename AtomEnvironment::removeEditorWindow -> ::destroy 2015-10-08 17:51:27 -07:00
Max Brunsfeld
5c545c0898 Don't register CommandRegistry's window listeners in AtomEnvironment constructor 2015-10-08 17:34:41 -07:00
Max Brunsfeld
4835fef7be Reset service-hub in AtomEnvironment::reset() 2015-10-08 16:29:54 -07:00
Max Brunsfeld
a9c8640ab1 Stop using directory providers when their providing packages are deactivated 2015-10-08 15:20:13 -07:00
Max Brunsfeld
b754f1e125 Clean up project specs for custom directory and repository providers 2015-10-08 15:15:02 -07:00
Max Brunsfeld
2af6f995b4 Clean up repository-providers when their providing packages are are deactivated 2015-10-08 13:49:37 -07:00