github/atom
1
1
Fork 0
mirror of https://github.com/atom/atom.git synced 2026-04-28 03:01:47 -04:00
Code Issues Packages Projects Releases Wiki Activity
31,994 Commits 140 Branches 571 Tags
edf1b7fb74746826ca514f5a9aa2728aaf563052
Commit Graph

15762 Commits

Author SHA1 Message Date
Nathan Sobo
edf1b7fb74 Remove dead code 2017-05-05 11:30:14 -06:00
Antonio Scandurra
15f25a745a Update width of content when approximate longest screen row changes 2017-05-05 11:29:57 -06:00
Antonio Scandurra
2855e01289 Don't create empty nodes when a text decoration ends next to a text tag 
This was causing problems in measurements because in that code path we
assume that text nodes are never empty. This commit also adds a test
verifying this invariant when a text decoration ending right after a
text tag is added.
 2017-05-05 11:22:01 +02:00
Antonio Scandurra
f7b79b477a Update class list even when the editor is not attached 2017-05-05 09:30:08 +02:00
Antonio Scandurra
97d2d7fb8b Fix remaining linting warnings 2017-05-05 09:30:08 +02:00
Antonio Scandurra
c541d3941c Fix remaining test failures in core 2017-05-05 09:30:08 +02:00
Nathan Sobo
bc34344d90 Maintain the scroll position when changing font size 2017-05-05 09:30:08 +02:00
Nathan Sobo
0c7030c70b Only resolve update promise after final render phase 2017-05-05 09:30:08 +02:00
Nathan Sobo
c5c48094ba Avoid requesting horizontal measurement when auto-scrolling vertically 
This was leaving a measurement request in the map that was getting
picked up on the next frame. In some cases, the requested measurement
row was not present, causing an exception.
 2017-05-05 09:30:08 +02:00
Nathan Sobo
1b1973db15 Rename method to match old implementation 2017-05-05 09:30:08 +02:00
Nathan Sobo
c00ad62a0e Pass mini attribute when creating new TextEditor from TextEditorElement 
This avoids content being shifted over due to rendering and measuring
the gutter on element creation and then subsequently hiding it.
 2017-05-05 09:30:08 +02:00
Nathan Sobo
42bb02c8a8 Account for vertical scrollbar width when soft-wrapping lines 2017-05-05 09:30:08 +02:00
Nathan Sobo
fe13279531 Update DOM in screenPositionForPixelPosition if needed 
Some packages are interacting with this method assuming this behavior,
so this commit eliminates `screenPositionForPixelPositionSync` and
instead just performs the DOM update in `screenPositionForPixelPosition`
if it is needed.
 2017-05-05 09:30:08 +02:00
Antonio Scandurra
001fef4a05 Don't activate scrollPastEnd for autoHeight editors 2017-05-05 09:30:08 +02:00
Antonio Scandurra
ccc35b5141 Make first-mate scope ids always larger than built-in ones 2017-05-05 09:29:30 +02:00
Antonio Scandurra
c2b854123b Never create empty spans at the beginning of a row 
This was happening when a text decoration overlapped a row, but the next
boundary was located exactly at the beginning of it.
 2017-05-05 09:29:30 +02:00
Nathan Sobo
ac8a908385 Implement text decorations in rendering layer 2017-05-05 09:29:30 +02:00
Antonio Scandurra
f17baf4790 Use scope ids instead of tags 2017-05-05 09:29:30 +02:00
Antonio Scandurra
570cfdeaff Ignore resize events if they are delivered while the editor is hidden 2017-05-05 09:29:30 +02:00
Nathan Sobo
16b2fba851 Fix lint errors 2017-05-05 09:29:30 +02:00
Nathan Sobo
c36303e631 Avoid blowing away classes assigned on the editor element by packages 
/cc @t9md
 2017-05-05 09:29:30 +02:00
Nathan Sobo
c7228f6d81 Fix error when attaching soft-wrap editor in synchronous update mode 
Taking the initial measurement was setting the soft wrap column, which
was triggering a display layer reset, which was scheduling an update.
This update occurred at an unexpected time causing an exception.
 2017-05-05 09:29:30 +02:00
Nathan Sobo
bd6eedcc88 Eliminate strictly contained divs wrapping lines and highlights 
I was hoping to strictly contain the layouts of highlights an lines
separately, since they are updated during different render phases.
Unfortunately, strict containment requires both divs to be positioned
absolutely. This in turn creates separate stacking contexts for lines
and highlights, which makes it impossible to render highlights in front
lines which themes sometimes need to do. For example,
atom-material-syntax pushes bracket matcher highlights to the front so
they are not obscured by the theme's solid black cursor line background.

/cc @as-cii. You should examine my work here and make sure I'm not
screwing something up with your line/block decoration update code.
 2017-05-05 09:29:30 +02:00
Antonio Scandurra
72351481c7 Fix positioning for block decorations located at the beginning of a tile 2017-05-05 09:29:30 +02:00
Antonio Scandurra
638bb78ecb Fix build failures 2017-05-05 09:29:30 +02:00
Antonio Scandurra
45e95912fa Cache derived dimensions during each phase of updateSync 
Signed-off-by: Nathan Sobo <nathan@github.com>
 2017-05-05 09:29:30 +02:00
Antonio Scandurra
4b34c476a3 Update lines content only once per frame 
Signed-off-by: Nathan Sobo <nathan@github.com>
 2017-05-05 09:29:30 +02:00
Antonio Scandurra
1544e3bc7f Update cursors only once per frame (after content has been measured) 
Signed-off-by: Nathan Sobo <nathan@github.com>
 2017-05-05 09:29:30 +02:00
Antonio Scandurra
97125ad083 Update gutter container only once per frame unless its width changes 
Signed-off-by: Nathan Sobo <nathan@github.com>
 2017-05-05 09:29:30 +02:00
Nathan Sobo
d92e0fc0a1 Eliminate cached placeholderTextVnode 2017-05-05 09:29:30 +02:00
Nathan Sobo
82cdf80f25 Extract CursorsAndInputComponent 2017-05-05 09:29:30 +02:00
Nathan Sobo
b23dcb7b9f Eliminate caching of linesVnode 2017-05-05 09:29:30 +02:00
Nathan Sobo
7d7a6ab507 Pass props to GutterContainerComponent instead of reaching up to parent 
There are still a few rootComponent references remaining in the
LineNumberGutterComponent. These should be removed and instead we should
consult this data when constructing the line numbers to render.
 2017-05-05 09:29:30 +02:00
Nathan Sobo
8c7f4d91f8 🎨 2017-05-05 09:29:30 +02:00
Nathan Sobo
656cabda0f Initialize all measurements to 0 2017-05-05 09:29:30 +02:00
Nathan Sobo
1ca4c69c87 WIP: Start extracting gutter component 2017-05-05 09:29:30 +02:00
Nathan Sobo
305fd14cd9 Add TextEditorElement.pixelRectRangeForScreenRange for compatibility 2017-05-05 09:29:30 +02:00
Nathan Sobo
a5a80448cb Add intersectsVisibleRowRange on TextEditorElement 2017-05-05 09:29:30 +02:00
Nathan Sobo
b54dbb58ab Add missing methods on TextEditorElement 2017-05-05 09:29:30 +02:00
Nathan Sobo
44539b1dc6 Remove some redundant styling 2017-05-05 09:29:30 +02:00
Nathan Sobo
0996d90be3 Add scrollbar classes in case any packages or themes target them 2017-05-05 09:29:30 +02:00
Nathan Sobo
207cd31054 Add highlights class for package compatibility 2017-05-05 09:29:30 +02:00
Antonio Scandurra
6ed7cd97cc Add highlight decoration classes to region elements as well 
Signed-off-by: Nathan Sobo <nathan@github.com>
 2017-05-05 09:29:30 +02:00
Antonio Scandurra
4bcace1628 Don't remeasure scrollbars for mini editors 
Signed-off-by: Nathan Sobo <nathan@github.com>
 2017-05-05 09:29:30 +02:00
Antonio Scandurra
e1ae3749c0 Add a pixelPositionForMouseEvent method 
This was a private method in the previous implementation that was used
by some packages.

Signed-off-by: Nathan Sobo <nathan@github.com>
 2017-05-05 09:29:30 +02:00
Antonio Scandurra
59ae239a8c Provide an editorElement shim on TextEditor 
Signed-off-by: Nathan Sobo <nathan@github.com>
 2017-05-05 09:29:30 +02:00
Antonio Scandurra
f45ff05306 Add {get,set}FirstVisibleScreen{Row,Column} to TextEditorElement 2017-05-05 09:29:30 +02:00
Antonio Scandurra
37b5d2eb4d Restore scrollbar positions correctly on reload 2017-05-05 09:29:30 +02:00
Antonio Scandurra
72d6316459 Fix shift-scroll on Windows and Linux 2017-05-05 09:29:29 +02:00
Antonio Scandurra
8f5e4216dc Fix more lint errors 2017-05-05 09:29:29 +02:00