Commit Graph

1078 Commits

Author SHA1 Message Date
Jeremy Ashkenas
a88efef3cd Merge pull request #1213 from braddunbar/backbone-ajax
Fix #474 - Backbone.ajax
2012-04-11 07:37:24 -07:00
Brad Dunbar
87c9b17aa7 Fix #474 - Backbone.ajax 2012-04-11 08:33:20 -04:00
Jeremy Ashkenas
67c3ea86c1 simple refactor for #1206 2012-04-10 10:27:22 -04:00
Jeremy Ashkenas
656f59e018 Merge pull request #1206 from aterris/frag
Normalize fragment when hashChange: false in navigate
2012-04-10 07:24:09 -07:00
Andrew Terris
35f11ba5c5 remove unneeded line and return on window.location.assign 2012-04-09 23:20:05 -05:00
Andrew Terris
b9021b64be normalize fragment when hashChange: false in navigate 2012-04-09 21:14:02 -05:00
Jeremy Ashkenas
2cab3a346c Fixes #1134 -- better document that model attributes are 'plain' data, not often arbitrary JS objects. 2012-04-09 17:07:06 -04:00
Jeremy Ashkenas
db4f66ba52 Fixes #1151 2012-04-09 16:16:34 -04:00
Jeremy Ashkenas
8bb15b9ee5 tweaking wording 2012-04-09 16:13:24 -04:00
Jeremy Ashkenas
2e652e4d1b Merge pull request #1187 from Benjen/master
Issue #1145: Changed documentation to elaborate when to use a function to define model defaults.
2012-04-09 13:09:19 -07:00
brad dunbar
0b270ccee7 Merge pull request #1204 from paulmillr/patch-2
Update salon.io example.
2012-04-09 11:49:31 -07:00
Paul Miller
8455b5007a Update salon.io example.
You can see they're using brunch in index.html source code (~L35).
Oh, and their dev (Jan) is on our core team.
2012-04-09 21:47:19 +03:00
Jeremy Ashkenas
951f1db12d Merge pull request #1203 from paulmillr/patch-1
Slightly update blossom example.
2012-04-09 11:00:07 -07:00
Paul Miller
c8030ce3c7 Slightly update blossom example. 2012-04-09 20:59:02 +03:00
Jeremy Ashkenas
e2c5ce850e Merge pull request #1200 from ymichael/master
Issue 1173: (todo example) model ids are not properly indexed by collections on creation
2012-04-06 08:58:19 -07:00
Michael Yong
f71bc0d53b fix setting of id for todo model 2012-04-06 23:43:31 +08:00
Jeremy Ashkenas
1bd9b7cb62 adding art.sy as an example app 2012-04-06 10:55:06 -04:00
Jeremy Ashkenas
fb49233436 Merge pull request #1185 from aterris/fragment
Use window.location.pathname as the fragment when _wantsHashChange == false
2012-04-06 07:39:24 -07:00
Jeremy Ashkenas
f60e4854e0 Merge pull request #1199 from mostly-magic/master
Fix continuous reload loop when { hashChange: false } in IE <= 7
2012-04-06 07:13:39 -07:00
Mitchell Cowie
74dec4d956 Bypass iframe for old IE when hash change disabled 2012-04-05 23:03:14 -06:00
Benjen
1b8ed46f2b Added additional information to warning text in model-defaults section, to explain when to use a function to define model default values. See Issue #1145 2012-04-06 00:02:54 +08:00
Andrew Terris
7596947b06 use pathname as fragment when hashChange: false 2012-04-04 21:44:18 -05:00
Jeremy Ashkenas
091b3e5a80 Merge pull request #1181 from braddunbar/isvalid
Fix #1179 - isValid returns true in the absence of validate.
2012-04-04 07:08:33 -07:00
Brad Dunbar
af30bcf3ca off is chainable when there are no events. 2012-04-04 05:52:54 -07:00
Brad Dunbar
137b7fd670 Fix #1179 - isValid returns true in the absence of validate. 2012-04-04 05:28:40 -07:00
Jeremy Ashkenas
a2ed079af8 removing reg exp test. 2012-04-02 17:35:26 -04:00
Jeremy Ashkenas
e5aabc6003 Merge branch 'master' of github.com:documentcloud/backbone 2012-04-02 17:25:11 -04:00
Jeremy Ashkenas
34c058e756 Fixes #1155 -- remove erroneous documentation about create() returning an XHR 2012-04-02 17:25:08 -04:00
Jeremy Ashkenas
948d41c290 Merge pull request #1156 from VIISON/master
Router test for urls with encoded characters
2012-04-02 14:22:16 -07:00
Jeremy Ashkenas
d7b8c8cdc4 reworking docs for model.collection 2012-04-02 17:16:46 -04:00
Jeremy Ashkenas
fad38af936 Merge pull request #1163 from aterris/model-collection-docs
Fix #1161: Documentation for model.collection property
2012-04-02 14:11:46 -07:00
Jeremy Ashkenas
da97490f0b Optimizing #1172 2012-04-02 10:13:50 -04:00
Jeremy Ashkenas
bc922ab134 Merge pull request #1172 from wrapp/master
This fixes as bug when have an attribute in a view and specify an ID to the constructor
2012-04-02 07:12:15 -07:00
Nicklas Ansman Giertz
2a1d06353f Make sure the attribute object is clone before extending it 2012-04-02 12:38:27 +02:00
Nicklas Ansman Giertz
d852c729df Add a test case for cloning the attribute object
The problem is that the attribute object isn't cloned so when an ID is
set through the constructor attributes[id] will get set on all
subsequent objects as well.
2012-04-02 12:37:25 +02:00
Andrew Terris
42bb5406e1 fix comment to more accurately reflect its true usage 2012-04-02 00:26:44 -05:00
Andrew Terris
54c4d7cd47 adds documentation for the automatic nested collection option on models 2012-03-31 16:55:18 -05:00
Samuel Vogel
59b39c43a3 Add router test for urls with encoded characters 2012-03-29 17:17:29 +02:00
Jeremy Ashkenas
fd4df5a810 Merge pull request #1152 from braddunbar/implicit-tojson
toJSON is called implicitly.
2012-03-29 07:49:04 -07:00
brad dunbar
dbdd49d27d Merge pull request #1154 from tombell/patch-1
Update Rakefile - missing '
2012-03-29 07:25:46 -07:00
Tom Bell
e4c7a79dc3 Update Rakefile - missing ' 2012-03-29 16:23:53 +02:00
Brad Dunbar
5d04588ae7 toJSON is called implicitly. 2012-03-29 07:52:16 -04:00
Jeremy Ashkenas
01adb382fe Merge pull request #1144 from bebanjo/fix_add_with_at
Collection add ignores comparator when "at" option is passed
2012-03-26 08:36:43 -07:00
Raúl Naveiras
db4b617697 add ignores comparator when at option is passed 2012-03-26 16:30:26 +02:00
Jeremy Ashkenas
d8de1cac4d Merge pull request #1141 from colevscode/master
Corrected link to address issue #1132 (Broken link in annotated source)
2012-03-26 06:37:58 -07:00
Jeremy Ashkenas
a1dea84b34 touch scrolling the sidebar for ios 2012-03-26 09:29:07 -04:00
Cole Krumbholz
2d9d77cf2f Corrected link to address issue #1132 (Broken link in annotated source) 2012-03-25 15:02:45 -07:00
Jeremy Ashkenas
4d0051de76 Merge branch 'master' of github.com:documentcloud/backbone 2012-03-22 12:03:28 -04:00
Jeremy Ashkenas
af721fbc83 adding a missing typoed comment. 2012-03-22 12:03:18 -04:00
brad dunbar
cb8a12fe16 Merge pull request #1129 from r00k/allow-content-of-0-in-make
Allow make to take falsy arguments for content.
2012-03-21 14:27:10 -07:00