Commit Graph

1054 Commits

Author SHA1 Message Date
Brad Dunbar
af30bcf3ca off is chainable when there are no events. 2012-04-04 05:52:54 -07:00
Jeremy Ashkenas
a2ed079af8 removing reg exp test. 2012-04-02 17:35:26 -04:00
Jeremy Ashkenas
e5aabc6003 Merge branch 'master' of github.com:documentcloud/backbone 2012-04-02 17:25:11 -04:00
Jeremy Ashkenas
34c058e756 Fixes #1155 -- remove erroneous documentation about create() returning an XHR 2012-04-02 17:25:08 -04:00
Jeremy Ashkenas
948d41c290 Merge pull request #1156 from VIISON/master
Router test for urls with encoded characters
2012-04-02 14:22:16 -07:00
Jeremy Ashkenas
d7b8c8cdc4 reworking docs for model.collection 2012-04-02 17:16:46 -04:00
Jeremy Ashkenas
fad38af936 Merge pull request #1163 from aterris/model-collection-docs
Fix #1161: Documentation for model.collection property
2012-04-02 14:11:46 -07:00
Jeremy Ashkenas
da97490f0b Optimizing #1172 2012-04-02 10:13:50 -04:00
Jeremy Ashkenas
bc922ab134 Merge pull request #1172 from wrapp/master
This fixes as bug when have an attribute in a view and specify an ID to the constructor
2012-04-02 07:12:15 -07:00
Nicklas Ansman Giertz
2a1d06353f Make sure the attribute object is clone before extending it 2012-04-02 12:38:27 +02:00
Nicklas Ansman Giertz
d852c729df Add a test case for cloning the attribute object
The problem is that the attribute object isn't cloned so when an ID is
set through the constructor attributes[id] will get set on all
subsequent objects as well.
2012-04-02 12:37:25 +02:00
Andrew Terris
42bb5406e1 fix comment to more accurately reflect its true usage 2012-04-02 00:26:44 -05:00
Andrew Terris
54c4d7cd47 adds documentation for the automatic nested collection option on models 2012-03-31 16:55:18 -05:00
Samuel Vogel
59b39c43a3 Add router test for urls with encoded characters 2012-03-29 17:17:29 +02:00
Jeremy Ashkenas
fd4df5a810 Merge pull request #1152 from braddunbar/implicit-tojson
toJSON is called implicitly.
2012-03-29 07:49:04 -07:00
brad dunbar
dbdd49d27d Merge pull request #1154 from tombell/patch-1
Update Rakefile - missing '
2012-03-29 07:25:46 -07:00
Tom Bell
e4c7a79dc3 Update Rakefile - missing ' 2012-03-29 16:23:53 +02:00
Brad Dunbar
5d04588ae7 toJSON is called implicitly. 2012-03-29 07:52:16 -04:00
Jeremy Ashkenas
01adb382fe Merge pull request #1144 from bebanjo/fix_add_with_at
Collection add ignores comparator when "at" option is passed
2012-03-26 08:36:43 -07:00
Raúl Naveiras
db4b617697 add ignores comparator when at option is passed 2012-03-26 16:30:26 +02:00
Jeremy Ashkenas
d8de1cac4d Merge pull request #1141 from colevscode/master
Corrected link to address issue #1132 (Broken link in annotated source)
2012-03-26 06:37:58 -07:00
Jeremy Ashkenas
a1dea84b34 touch scrolling the sidebar for ios 2012-03-26 09:29:07 -04:00
Cole Krumbholz
2d9d77cf2f Corrected link to address issue #1132 (Broken link in annotated source) 2012-03-25 15:02:45 -07:00
Jeremy Ashkenas
4d0051de76 Merge branch 'master' of github.com:documentcloud/backbone 2012-03-22 12:03:28 -04:00
Jeremy Ashkenas
af721fbc83 adding a missing typoed comment. 2012-03-22 12:03:18 -04:00
brad dunbar
cb8a12fe16 Merge pull request #1129 from r00k/allow-content-of-0-in-make
Allow make to take falsy arguments for content.
2012-03-21 14:27:10 -07:00
Ben Orenstein
c7034b9735 Let make take other falsy values for content. 2012-03-21 17:21:16 -04:00
Ben Orenstein
69d2c50640 Allow make to take an argument of 0. 2012-03-21 17:07:32 -04:00
Jeremy Ashkenas
f784ae3801 adding EDITD as an example app 2012-03-21 16:51:38 -04:00
Jeremy Ashkenas
863814e519 Backbone.js 0.9.2 0.9.2 2012-03-21 14:55:29 -04:00
Jeremy Ashkenas
56e10451d4 more comments, more spacing, more better 2012-03-21 12:21:16 -04:00
Jeremy Ashkenas
4f8d790cda more comments, more better 2012-03-21 12:07:42 -04:00
Jeremy Ashkenas
9899a81775 tweaking addy's todo changes. 2012-03-21 11:40:26 -04:00
Jeremy Ashkenas
561cb7076a Merge branch 'master' of https://github.com/addyosmani/backbone 2012-03-21 11:28:07 -04:00
Jeremy Ashkenas
42ad7a677e fixes #1092 -- use model.get( internally instead of raw access, for easier extension / overriding. 2012-03-21 11:23:02 -04:00
Jeremy Ashkenas
f4a1ebc374 fixes #1030 -- save with wait:true with a synchronous Backbone.sync 2012-03-21 11:18:30 -04:00
Jeremy Ashkenas
e9e1abfe61 model.destroy() returns false if the model.isNew() 2012-03-21 10:40:54 -04:00
Jeremy Ashkenas
a554d6b805 Merge pull request #1111 from braddunbar/sync-docs
Fix #1108 - document return value of `sync`.
2012-03-21 07:31:23 -07:00
Brad Dunbar
0ae16272bf Document jqXHR return values. 2012-03-20 07:24:05 -04:00
Jeremy Ashkenas
7b6dbc8dcd Merge pull request #1021 from ahamid/reset_passes_options
small patch to allow passing options through reset to model initializer
2012-03-19 14:00:58 -07:00
Jeremy Ashkenas
de599c169d Fixes #991. Add Collection#where for simple filters 2012-03-19 16:34:53 -04:00
Jeremy Ashkenas
5f41b88764 Merge pull request #1110 from braddunbar/off
Fix #1105 - Add convenience overloads for `off`.
2012-03-19 09:27:17 -07:00
Jeremy Ashkenas
e2e0a0982b Merge pull request #1114 from braddunbar/save-wait-validate
Fix #1057 - Save with wait validates model.
2012-03-19 08:35:12 -07:00
Jeremy Ashkenas
315d67b602 Merge pull request #1119 from braddunbar/collection-model
Fix #1112 - options.model sets collection.model.
2012-03-19 08:07:25 -07:00
Brad Dunbar
9ffc84c9fe Fix #1112 - options.model sets collection.model. 2012-03-18 22:28:08 -04:00
Brad Dunbar
6948b59e61 Fix #1057 - Save with wait validates model. 2012-03-18 08:59:23 -04:00
Brad Dunbar
84a7e359c7 Fix #1108 - document return value of sync. 2012-03-17 13:46:48 -04:00
Brad Dunbar
fb27097835 Fix #1105 - Add convenience overloads for off. 2012-03-17 09:02:23 -04:00
Jeremy Ashkenas
01fb4149e1 editing airbnb mobile 2012-03-16 16:47:10 -04:00
Harry Shoff
ec8dc945c8 Fix typo 2012-03-16 16:44:07 -04:00