Commit Graph

1776 Commits

Author SHA1 Message Date
Jeremy Ashkenas
d63fe9e61f Merge pull request #2019 from tgriesser/nocontext
Removing context from listenTo/stoplistening
2012-12-27 18:29:56 -08:00
Jeremy Ashkenas
678bdd0c85 Tweak #2017 ... isObject instead of typeof 2012-12-27 18:21:42 -08:00
brad dunbar
afa294e9e2 Merge pull request #2033 from taka84u9/collection-drop
Forgot to import _.drop?
2012-12-27 03:38:32 -08:00
Yuku Takahashi
c013a60e5c Import _.drop 2012-12-27 18:34:20 +09:00
Tim Griesser
03f1de06d1 removing unnecessary options check 2012-12-27 01:28:11 -05:00
Tim Griesser
e12e1d8d45 fixing validation & internal change flag order 2012-12-27 01:16:08 -05:00
Tim Griesser
61021d31e2 removing model.change from docs 2012-12-26 18:11:15 -05:00
Brad Dunbar
1e8c79dd99 Use single quotes and drop self closing slash. 2012-12-26 17:23:07 -05:00
Tim Branyen
14d124a577 updated View#make to use Backbone.$ exclusively 2012-12-26 14:17:37 -05:00
Tim Griesser
323d216f76 Merge pull request #2022 from adriaanlabusc/remove_nested
Changed the model's set function so that the 'nested' variable isn't req...
2012-12-26 11:01:22 -08:00
Tim Griesser
047d0d6bf4 using typeof rather than _.isObject for model.save 2012-12-26 13:07:36 -05:00
Tim Griesser
3283442550 Merge pull request #2021 from Ore4444/patch-3
Minor Typo in the Docs
2012-12-26 09:27:57 -08:00
Brad Dunbar
54fe48f8e3 Fix #2023 - Change log mentions ignored search parameters in routes. 2012-12-26 10:14:22 -05:00
Brad Dunbar
7fe4138b65 Use _.isObject instead of typeof. 2012-12-26 09:30:24 -05:00
Tim Griesser
c396adb2dd save with non-model success 2012-12-26 01:54:49 -05:00
Adriaan Labuschagne
4f1cb85977 Changed the model's set function so that the 'nested' variable isn't required
Signed-off-by: Adriaan Labuschagne <adriaanlabuschagne@gmail.com>
2012-12-25 22:34:34 -05:00
Ore Landau
1a754a2892 Update index.html
Minor minor typo
2012-12-25 16:02:47 +02:00
Tim Griesser
4b2ce42180 removing context from listenTo/stoplistening 2012-12-24 15:00:50 -05:00
Brad Dunbar
a24544bdc4 jquery-* -> jquery.js 2012-12-23 11:11:15 -05:00
Tim Griesser
16bcd429c8 bumping jquery to 1.7+ 2012-12-22 15:39:28 -05:00
Casey Foster
e16c762ec5 Remove unused declarations in add, noglobals for phantomjs 2012-12-21 15:06:09 -08:00
Casey Foster
6868457ff5 Match comparator string checks in sort and add 2012-12-21 13:29:10 -08:00
Jeremy Ashkenas
2abe2850e5 Merge pull request #2004 from elasticsales/master
Adding test for change event only firing if setting an object with a different value
2012-12-21 12:39:18 -08:00
Casey Foster
320347d94a Merge pull request #2005 from braddunbar/success-args
Fix #2003 - success callback arguments.
2012-12-21 11:55:19 -08:00
Brad Dunbar
0aff3f2b62 Use collection in Collection#fetch. 2012-12-21 14:45:34 -05:00
Brad Dunbar
6023be49e1 Remove unused arguments. 2012-12-21 14:14:32 -05:00
Brad Dunbar
6d589bad78 Fix #2003 - success callback arguments. 2012-12-21 14:06:45 -05:00
Phil Freo
e2bcc8c6ea Adding test for change event only firing if setting an object with a different value 2012-12-21 13:54:10 -05:00
Casey Foster
ef0db237ca Revert set/save argument juggling 2012-12-21 10:47:30 -08:00
Casey Foster
b6ca71c594 Simplify argument juggling for set/save 2012-12-21 09:51:09 -08:00
Jeremy Ashkenas
1357ecd413 tricky merge with master ... 2012-12-21 12:25:45 -05:00
Jeremy Ashkenas
40b7419e48 Merge pull request #2002 from braddunbar/named-optional
Fix #1980 - Named and optional params.
2012-12-21 09:19:33 -08:00
Casey Foster
1c131daef6 Clear up comments in last test 2012-12-21 08:19:38 -08:00
Casey Foster
09bd7fe8a8 Fix test case 2012-12-21 08:18:15 -08:00
Jeremy Ashkenas
812a8465de failing test case 2012-12-21 11:13:09 -05:00
Casey Foster
d0af33646c Even smarter sort-reduction 2012-12-21 08:07:55 -08:00
Jeremy Ashkenas
0e20e93b81 fixed leaking global 2012-12-21 10:58:46 -05:00
Jeremy Ashkenas
45b3870136 Merge branch 'simple' of github.com:documentcloud/backbone into simple 2012-12-21 10:56:57 -05:00
Jeremy Ashkenas
5ac783bd2d complete test suite passing. 2012-12-21 10:56:57 -05:00
Tim Griesser
b3c06874ae Merge pull request #2001 from braddunbar/simple
Ensure toJSON receives the correct attributes.
2012-12-21 07:53:33 -08:00
Jeremy Ashkenas
2eab0fe3b8 hasChanged shouldn't be true after the constructor. 2012-12-21 10:51:02 -05:00
Jeremy Ashkenas
3ffcce8cb8 trying new hasChanged() semantics 2012-12-21 10:46:02 -05:00
Jeremy Ashkenas
e5c30a396a merged with simple 2012-12-21 10:24:19 -05:00
Jeremy Ashkenas
34f852803a revisited tests with simple silent 2012-12-21 10:23:16 -05:00
Casey Foster
e658535bd0 Add test for smart add-sorting 2012-12-21 06:46:23 -08:00
Brad Dunbar
1c4a1e3bc5 Fix #1980 - Named and optional params. 2012-12-21 09:39:54 -05:00
Casey Foster
5debd9d363 Perf tweaks, see http://jsperf.com/testing-equals-versus-strict-equals/3, http://jsperf.com/conditional-assignment-vs-reassignment 2012-12-21 06:36:39 -08:00
brad dunbar
c9b025fd86 Merge pull request #1996 from caseywebdev/sort
Only sort when a model is changed or added
2012-12-21 06:04:12 -08:00
Brad Dunbar
5350dc9dea Ensure toJSON receives the correct attributes. 2012-12-21 08:53:12 -05:00
Tim Griesser
4089bf0e42 sync tests passing, tweaking save validation rules 2012-12-20 23:28:49 -05:00