28 Commits

Author SHA1 Message Date
Satadru Pramanik, DO, MPH, MEng
334df68e67 Ruby => 4.0.0 (#13989)
* Adjust package for Ruby 4.0.0

Signed-off-by: Satadru Pramanik <satadru@gmail.com>

* Fix ruby gem filelist generation.

Signed-off-by: Satadru Pramanik <satadru@gmail.com>

* Add ruby builds.

Signed-off-by: Satadru Pramanik <satadru@gmail.com>

* lint

Signed-off-by: Satadru Pramanik <satadru@gmail.com>

* ruby4: Package File Update Run on linux/386 container.

* ruby4: Package File Update Run on linux/amd64 container.

* Ruby 4 Adjustments.

Signed-off-by: Satadru Pramanik <satadru@gmail.com>

---------

Signed-off-by: Satadru Pramanik <satadru@gmail.com>
Co-authored-by: satmandu <satmandu@users.noreply.github.com>
2025-12-27 15:09:43 +00:00
Max Downey Twiss
d026a4184e cleanup lib/fixup.rb (#13598) 2025-11-23 14:48:51 +00:00
chromebrew-actions[bot]
261a043520 Adjust workflows. — py3_pyyaml → 6.0.3 (#12980)
* Adjust workflows.

Signed-off-by: Satadru Pramanik <satadru@gmail.com>

* Only upload binaries, do not update branches during Build workflow.

Signed-off-by: Satadru Pramanik <satadru@gmail.com>

* Adjust commit log.

Signed-off-by: Satadru Pramanik <satadru@gmail.com>

* Change merge variable to indicate rebase.

Signed-off-by: Satadru Pramanik <satadru@gmail.com>

* Fix getrealdeps.rb file copy. Fix rubocop Naming patch exclusion. Adjust Package Changes determinations in workflow.

Signed-off-by: Satadru Pramanik <satadru@gmail.com>

* Add back libyaml dep.

Signed-off-by: Satadru Pramanik <satadru@gmail.com>

* lint

Signed-off-by: Satadru Pramanik <satadru@gmail.com>

---------

Signed-off-by: Satadru Pramanik <satadru@gmail.com>
Co-authored-by: Satadru Pramanik <satadru@gmail.com>
2025-09-28 02:40:56 +00:00
Maximilian Downey Twiss
75bc603418 Run rubocop 1.76.0 on tree (#11998) 2025-06-06 11:04:01 +00:00
Maximilian Downey Twiss
0c86288d24 Clean up rubocop configuration pt.1 (#11566) 2025-03-17 22:42:05 +00:00
github-actions[bot]
0fdf0cffde Ruby 3.4.1 => 3.4.2 (#11329)
Add built packages for linux/386 to update-ruby

Add built packages for linux/amd64 to update-ruby

Add built packages for linux/arm/v7 to update-ruby

Bump versions in workflow files

Lint Rubocop.yml

Co-authored-by: Ed Reel <edreel@gmail.com>
2025-02-16 00:56:19 +00:00
Maximilian Downey Twiss
a4bd2f417a Enable rubocop-chromebrew extension (#10000) 2025-02-03 12:07:38 +00:00
Satadru Pramanik, DO, MPH, MEng
386f42ff6e Fix for require issues with highline and glibc 2.37 refactor (#10363)
* Adjust highline requires.

Signed-off-by: Satadru Pramanik <satadru@gmail.com>

* Refactor glibc_build237.

Signed-off-by: Satadru Pramanik <satadru@gmail.com>

* Adjust cmake logic for cmake_build_relative_dir.

Signed-off-by: Satadru Pramanik <satadru@gmail.com>

* Update buildsystems...

Signed-off-by: Satadru Pramanik <satadru@gmail.com>

* Rebuild glibc 2.37 packages.

Signed-off-by: Satadru Pramanik <satadru@gmail.com>

* Adjust fixup for case of loading from much older crew.

Signed-off-by: Satadru Pramanik <satadru@gmail.com>

* Try to handle loading fixup on older crew update.

Signed-off-by: Satadru Pramanik <satadru@gmail.com>

* Handle older crew setups.

Signed-off-by: Satadru Pramanik <satadru@gmail.com>

* Use rubocop exclusion for only const.rb and fixup.rb.

Signed-off-by: Satadru Pramanik <satadru@gmail.com>

* Remove attr_accessor from buildsystems.

Signed-off-by: Satadru Pramanik <satadru@gmail.com>

* Force update compatible if coming from an older crew.

Signed-off-by: Satadru Pramanik <satadru@gmail.com>

* remove require_gem from package.rb

Signed-off-by: Satadru Pramanik <satadru@gmail.com>

* Add fallback for remove.rb

Signed-off-by: Satadru Pramanik <satadru@gmail.com>

* const tweaks...

Signed-off-by: Satadru Pramanik <satadru@gmail.com>

* Adjust const.rb & fixup.rb to remove error messages on load after require.

Signed-off-by: Satadru Pramanik <satadru@gmail.com>

* Make remove run crew update compatible if being run on a newer underlying chromebrew.

Signed-off-by: Satadru Pramanik <satadru@gmail.com>

* lint

Signed-off-by: Satadru Pramanik <satadru@gmail.com>

* Adjust fixup to be more resilient to being loaded in an older crew.

Signed-off-by: Satadru Pramanik <satadru@gmail.com>

* Switch from symbolized json import.

Signed-off-by: Satadru Pramanik <satadru@gmail.com>

* fixup

Signed-off-by: Satadru Pramanik <satadru@gmail.com>

* fixup

Signed-off-by: Satadru Pramanik <satadru@gmail.com>

* fixup

Signed-off-by: Satadru Pramanik <satadru@gmail.com>

* fixup

Signed-off-by: Satadru Pramanik <satadru@gmail.com>

* Revert most changes.

Signed-off-by: Satadru Pramanik <satadru@gmail.com>

* Adjust essential deps handling in fixup.

Signed-off-by: Satadru Pramanik <satadru@gmail.com>

* Cleanup save_json in fixup.

Signed-off-by: Satadru Pramanik <satadru@gmail.com>

* update highline

Signed-off-by: Satadru Pramanik <satadru@gmail.com>

* save json more.

Signed-off-by: Satadru Pramanik <satadru@gmail.com>

* save json more.

Signed-off-by: Satadru Pramanik <satadru@gmail.com>

* test remove changes

Signed-off-by: Satadru Pramanik <satadru@gmail.com>

* Add more remove debug code.

Signed-off-by: Satadru Pramanik <satadru@gmail.com>

* Add more remove debug code.

Signed-off-by: Satadru Pramanik <satadru@gmail.com>

* add debug to fixup

Signed-off-by: Satadru Pramanik <satadru@gmail.com>

* add debug to fixup

Signed-off-by: Satadru Pramanik <satadru@gmail.com>

* add debug to fixup

Signed-off-by: Satadru Pramanik <satadru@gmail.com>

* fixup

Signed-off-by: Satadru Pramanik <satadru@gmail.com>

* Refresh crew json when calling crew functions or exiting fixup.

Signed-off-by: Satadru Pramanik <satadru@gmail.com>

* Refresh crew json when calling crew functions or exiting fixup.

Signed-off-by: Satadru Pramanik <satadru@gmail.com>

* fixup

Signed-off-by: Satadru Pramanik <satadru@gmail.com>

* fix json string usage in remove

Signed-off-by: Satadru Pramanik <satadru@gmail.com>

* essential package debugging

Signed-off-by: Satadru Pramanik <satadru@gmail.com>

* fixup

Signed-off-by: Satadru Pramanik <satadru@gmail.com>

* fixup

Signed-off-by: Satadru Pramanik <satadru@gmail.com>

* Adjust remove debugging...

Signed-off-by: Satadru Pramanik <satadru@gmail.com>

* more remove debugging

Signed-off-by: Satadru Pramanik <satadru@gmail.com>

* Remove debugging code from commands/remove.rb

Signed-off-by: Satadru Pramanik <satadru@gmail.com>

* Remove more debugging code from lib/fixup.

Signed-off-by: Satadru Pramanik <satadru@gmail.com>

* Adjust remove test to test both remove with and without debug argument.

Signed-off-by: Satadru Pramanik <satadru@gmail.com>

* Update const.rb to not set x86 constants when not on x86.

Signed-off-by: Satadru Pramanik <satadru@gmail.com>

* Set x86 constants to nil when not on x86.

Signed-off-by: Satadru Pramanik <satadru@gmail.com>

* Bump crew version.

Signed-off-by: Satadru Pramanik <satadru@gmail.com>

---------

Signed-off-by: Satadru Pramanik <satadru@gmail.com>
2024-08-31 14:06:18 -05:00
Satadru Pramanik, DO, MPH, MEng
8dbc3925d2 icu4c => 75.1 + updates (#10246)
* Update icu4c, libxml2

Signed-off-by: Satadru Pramanik <satadru@gmail.com>

* update libxml2

Signed-off-by: Satadru Pramanik <satadru@gmail.com>

* update binaries

Signed-off-by: Satadru Pramanik <satadru@gmail.com>

* adjust deps

Signed-off-by: Satadru Pramanik <satadru@gmail.com>

* libxslt rebuild

Signed-off-by: Satadru Pramanik <satadru@gmail.com>

* updates and rebuilds for harfbuzz, freetype, fontconfig, cairo, pango

Signed-off-by: Satadru Pramanik <satadru@gmail.com>

* rebuild libxslt with new version

Signed-off-by: Satadru Pramanik <satadru@gmail.com>

* add icu version to libarchive

Signed-off-by: Satadru Pramanik <satadru@gmail.com>

* adjust xmlto deps

Signed-off-by: Satadru Pramanik <satadru@gmail.com>

* adjust xmlto deps

Signed-off-by: Satadru Pramanik <satadru@gmail.com>

* adjust xmlto deps

Signed-off-by: Satadru Pramanik <satadru@gmail.com>

* icu version shared_mime_info

Signed-off-by: Satadru Pramanik <satadru@gmail.com>

* add js115 py deps

Signed-off-by: Satadru Pramanik <satadru@gmail.com>

* fixup

Signed-off-by: Satadru Pramanik <satadru@gmail.com>

* fixup

Signed-off-by: Satadru Pramanik <satadru@gmail.com>

* python updates

Signed-off-by: Satadru Pramanik <satadru@gmail.com>

* update binutils to master

Signed-off-by: Satadru Pramanik <satadru@gmail.com>

* more test changes for js115

Signed-off-by: Satadru Pramanik <satadru@gmail.com>

* update py3_pyicu

Signed-off-by: Satadru Pramanik <satadru@gmail.com>

* rebuild wayland

Signed-off-by: Satadru Pramanik <satadru@gmail.com>

* update librsvg

Signed-off-by: Satadru Pramanik <satadru@gmail.com>

* rebuild xfsprogs

Signed-off-by: Satadru Pramanik <satadru@gmail.com>

* rebuild bind

Signed-off-by: Satadru Pramanik <satadru@gmail.com>

* boost rebuild

Signed-off-by: Satadru Pramanik <satadru@gmail.com>

* add libabigail, update sphinx and deps

Signed-off-by: Satadru Pramanik <satadru@gmail.com>

* rebuild yelp

Signed-off-by: Satadru Pramanik <satadru@gmail.com>

* update gspell

Signed-off-by: Satadru Pramanik <satadru@gmail.com>

* update imlib2

Signed-off-by: Satadru Pramanik <satadru@gmail.com>

* update libgsf

Signed-off-by: Satadru Pramanik <satadru@gmail.com>

* rebuild libcdr, update libical

Signed-off-by: Satadru Pramanik <satadru@gmail.com>

* rebuild libmetalink, update libvisio

Signed-off-by: Satadru Pramanik <satadru@gmail.com>

* rebuild caja

Signed-off-by: Satadru Pramanik <satadru@gmail.com>

* update gtk3

Signed-off-by: Satadru Pramanik <satadru@gmail.com>

* update glib

Signed-off-by: Satadru Pramanik <satadru@gmail.com>

* update gobject_introspection

Signed-off-by: Satadru Pramanik <satadru@gmail.com>

* update gnome_docking_library package

Signed-off-by: Satadru Pramanik <satadru@gmail.com>

* more gnome updates

Signed-off-by: Satadru Pramanik <satadru@gmail.com>

* fixup nautilus

Signed-off-by: Satadru Pramanik <satadru@gmail.com>

* update vte, revert js115 changes to allow installs, add arm builds for tinysparql, localsearch, nautilus

Signed-off-by: Satadru Pramanik <satadru@gmail.com>

* glibc testing upload

Signed-off-by: Satadru Pramanik <satadru@gmail.com>

* update r

Signed-off-by: Satadru Pramanik <satadru@gmail.com>

* suggested changes to add detection for -icu??.?

Signed-off-by: Satadru Pramanik <satadru@gmail.com>

* rebuild geany_plugins

Signed-off-by: Satadru Pramanik <satadru@gmail.com>

* add dehtml, rework glibc_build237

Signed-off-by: Satadru Pramanik <satadru@gmail.com>

* update py3_pyyaml

Signed-off-by: Satadru Pramanik <satadru@gmail.com>

* update libdbusmenu_gtk3

Signed-off-by: Satadru Pramanik <satadru@gmail.com>

* update gtksourceview_5, cleanup sass packages

Signed-off-by: Satadru Pramanik <satadru@gmail.com>

* update sass packages, add binaries

Signed-off-by: Satadru Pramanik <satadru@gmail.com>

* update graphicsmagick, refactor glibc_build237

Signed-off-by: Satadru Pramanik <satadru@gmail.com>

* add x86_84 binaries for tinysparql, localsearch, nautilus

Signed-off-by: Satadru Pramanik <satadru@gmail.com>

* update evolution_data_server

Signed-off-by: Satadru Pramanik <satadru@gmail.com>

* iterate

Signed-off-by: Satadru Pramanik <satadru@gmail.com>

* xwayland => 24.1.2

Signed-off-by: Satadru Pramanik <satadru@gmail.com>

* update glibc_build237 binaries

Signed-off-by: Satadru Pramanik <satadru@gmail.com>

* sync glibc packages

Signed-off-by: Satadru Pramanik <satadru@gmail.com>

* remove instance variables

Signed-off-by: Satadru Pramanik <satadru@gmail.com>

* more pkg updates, update mold

Signed-off-by: Satadru Pramanik <satadru@gmail.com>

* fix webkitgtk_6 pkg

Signed-off-by: Satadru Pramanik <satadru@gmail.com>

* sync glibc changes

Signed-off-by: Satadru Pramanik <satadru@gmail.com>

* adjust mysql deps

Signed-off-by: Satadru Pramanik <satadru@gmail.com>

* add new packages to packages.yaml

Signed-off-by: Satadru Pramanik <satadru@gmail.com>

* update package file for webkitgtk_6

Signed-off-by: Satadru Pramanik <satadru@gmail.com>

* python => 3.12.5

Signed-off-by: Satadru Pramanik <satadru@gmail.com>

* adjust build options for js115

Signed-off-by: Satadru Pramanik <satadru@gmail.com>

* update js115

Signed-off-by: Satadru Pramanik <satadru@gmail.com>

* update more packages

Signed-off-by: Satadru Pramanik <satadru@gmail.com>

* add updates

Signed-off-by: Satadru Pramanik <satadru@gmail.com>

* add i686 build

Signed-off-by: Satadru Pramanik <satadru@gmail.com>

* add builds for uriparser

Signed-off-by: Satadru Pramanik <satadru@gmail.com>

* adjust force flag

Signed-off-by: Satadru Pramanik <satadru@gmail.com>

* fix downloader force

Signed-off-by: Satadru Pramanik <satadru@gmail.com>

* fixup download pkg_name usage

Signed-off-by: Satadru Pramanik <satadru@gmail.com>

* update smbclient package

Signed-off-by: Satadru Pramanik <satadru@gmail.com>

* update tesseract package

Signed-off-by: Satadru Pramanik <satadru@gmail.com>

* package updates

Signed-off-by: Satadru Pramanik <satadru@gmail.com>

* update tesseract, add time check for builds to crew

Signed-off-by: Satadru Pramanik <satadru@gmail.com>

* update some samba packages

Signed-off-by: Satadru Pramanik <satadru@gmail.com>

* update tepl packages

Signed-off-by: Satadru Pramanik <satadru@gmail.com>

* add ruby_pry_byebug

Signed-off-by: Satadru Pramanik <satadru@gmail.com>

* update smbclient

Signed-off-by: Satadru Pramanik <satadru@gmail.com>

* tepl updates

Signed-off-by: Satadru Pramanik <satadru@gmail.com>

* update smbclient

Signed-off-by: Satadru Pramanik <satadru@gmail.com>

* update imagemagick7

Signed-off-by: Satadru Pramanik <satadru@gmail.com>

* add postgresql binaries

Signed-off-by: Satadru Pramanik <satadru@gmail.com>

* fix yaml

Signed-off-by: Satadru Pramanik <satadru@gmail.com>

* adjust build_elapsed time code, add verbose build to unit test

Signed-off-by: Satadru Pramanik <satadru@gmail.com>

* Add CREW_DEBUG to help debug issues with crew (invoke with crew <command> --debug).

Signed-off-by: Satadru Pramanik <satadru@gmail.com>

* update crew_profile_base

Signed-off-by: Satadru Pramanik <satadru@gmail.com>

* some python package cleanups

Signed-off-by: Satadru Pramanik <satadru@gmail.com>

* add print_source_bashrc to docbook_xsl

Signed-off-by: Satadru Pramanik <satadru@gmail.com>

* add debugging info message

Signed-off-by: Satadru Pramanik <satadru@gmail.com>

* fixup

Signed-off-by: Satadru Pramanik <satadru@gmail.com>

* bump version

Signed-off-by: Satadru Pramanik <satadru@gmail.com>

* suggested changes and install updates

Signed-off-by: Satadru Pramanik <satadru@gmail.com>

* add crew_sudo binaries

Signed-off-by: Satadru Pramanik <satadru@gmail.com>

* rubocop fixes

Signed-off-by: Satadru Pramanik <satadru@gmail.com>

* Fixes: #10291

Signed-off-by: Satadru Pramanik <satadru@gmail.com>

* refactor crew upload

Signed-off-by: Satadru Pramanik <satadru@gmail.com>

* abort when a file is already uploaded

Signed-off-by: Satadru Pramanik <satadru@gmail.com>

* use highline for crew upload prompt

Signed-off-by: Satadru Pramanik <satadru@gmail.com>

* add highline to buildessential

Signed-off-by: Satadru Pramanik <satadru@gmail.com>

* adjust highline update speed in packages.yaml

Signed-off-by: Satadru Pramanik <satadru@gmail.com>

---------

Signed-off-by: Satadru Pramanik <satadru@gmail.com>
2024-08-11 03:19:59 -05:00
SupeChicken666
f9738c639d buildsystem: Use native ruby block in install_extras (#10110)
* buildsystem: Use native ruby block in `install_extras`

Signed-off-by: supechicken <me@supechicken666.dev>

* Make rubocop happy, disable `Security/Eval` cop

Signed-off-by: supechicken <me@supechicken666.dev>

---------

Signed-off-by: supechicken <me@supechicken666.dev>
2024-07-09 08:56:03 -05:00
Maximilian Downey Twiss
33901368d7 Enable more rubocop cops (#9980)
* Remove self.check in python3.rb as tests were not actuallly being run

* Enable Lint/ImplicitStringConcatenation cop

* Enable Layout/CommentIndentation cop

* Remove unnecessary configuration of Layout/IndentationStyle to EnforcedStyle: spaces, as this is already the default

* Enable Layout/LeadingCommentSpace cop

* Enable Layout/SpaceInsideBlockBraces cop

* Enable Layout/SpaceInsideParens cop

* Enable Layout/TrailingEmptyLines cop

* Enable Lint/LiteralAsCondition cop

* Document the current issue stopping us from enabling Style/OptionalBooleanParameter

* Stop downloading our rubocop config when installing ruby_rubocop
2024-06-17 16:19:11 -04:00
Maximilian Downey Twiss
eddca7e0e8 Enable additional temporarily disabled cops (#9394) 2024-03-01 12:24:31 -05:00
Maximilian Downey Twiss
b1c6e33094 Update rubocop target ruby version to 3.3 (#9152) 2024-01-06 20:02:23 +08:00
Maximilian Downey Twiss
86a7814bda Convert workflows to use reviewdog, run rubocop on tree (#8939) 2023-11-13 02:46:43 -05:00
SupeChicken666
9f77502974 Reimplementing #8890 (lib/const: Simplify + cleanup) (#8901)
* lib/const: Simplify + cleanup

* Fix nil issue

* Update const.rb

* Always convert result to boolean

* Always convert result to boolean

* Use File.join to prevent duplicate slashes

* rubocop: Disable `Lint/RedundantSafeNavigation` rule

* ruby_rubocop: Update checksum

* Fix logic

* Change `CREW_DLL_PREFIX` to `CREW_WINE_PREFIX`

* Use `&&` to concatenate commands

* Update const.rb

* Remove redundant `nil`

* Bump version

* Align + more cleanup

* Don't use ENV.fetch when default value is not needed

---------

Co-authored-by: Satadru Pramanik, DO, MPH, MEng <satadru@gmail.com>
2023-11-08 10:24:46 -05:00
Ed Reel
21f11675dd Revert "lib/const: Simplify + cleanup (#8890)" (#8895)
This reverts commit f3a58c9492.

Fixes `crew install vim` and `crew install cantarell_fonts`.
2023-11-05 17:49:42 -05:00
SupeChicken666
f3a58c9492 lib/const: Simplify + cleanup (#8890)
* lib/const: Simplify + cleanup

* Fix nil issue

* Update const.rb

* Always convert result to boolean

* Always convert result to boolean

* Use File.join to prevent duplicate slashes

* rubocop: Disable `Lint/RedundantSafeNavigation` rule

* ruby_rubocop: Update checksum

* Fix logic

* Change `CREW_DLL_PREFIX` to `CREW_WINE_PREFIX`

* Use `&&` to concatenate commands

* Update const.rb

* Remove redundant `nil`

* Bump version

* Align + more cleanup

* Don't use ENV.fetch when default value is not needed
2023-11-05 10:12:41 -06:00
Satadru Pramanik, DO, MPH, MEng
2f578f414c Adjust linter rule... (#8860)
* chdir before using git

* fix rubocop complaint

* adjust lint rule

* expand logic of path env.d check

* bump
2023-10-31 21:16:27 -05:00
Maximilian Downey Twiss
2f42ff39cc Run Rubocop on tree, again (#8704) 2023-09-29 07:51:08 -04:00
Maximilian Downey Twiss
41a708c1c5 Refactor workflow files (#8355)
* Refactor workflow files

* Fix YAMLlint errors
2023-06-13 23:42:56 -04:00
Satadru Pramanik, DO, MPH, MEng
006250d9e7 fix linecontinuation issue (#8160) 2023-04-06 13:30:52 -05:00
Satadru Pramanik
90cbf8e85e rubocop: allow CapitalW (#7499) 2022-10-15 20:06:38 -05:00
supechicken
ce3f25aa40 rubocop: Disable some cops (#7494)
* Update .rubocop.yml

* rubocop: Disable some cops
2022-10-14 10:55:24 -05:00
supechicken
0c0db3c649 rubocop: Disable Layout/SpaceInsideParens cop (#7465) 2022-10-08 09:47:42 -04:00
Maximilian Downey Twiss
b5e4cedb0d Re-enable And/Or cop, lint tree (#7457) 2022-10-05 20:16:53 -05:00
supechicken
db5a2c68e6 Disable And/Or check, re-enable trailing space check (#7456) 2022-10-04 09:16:08 -04:00
Maximilian Downey Twiss
de24923ee8 Add Rubocop CI (#7083)
* Rename IgnoredPatterns to AllowedPatterns.

* Exclude docopt.rb (not our code) from Rubocop

* Disable Style/RedundantReturn

* Disable Style/MutableConstant

* Disable Style/NumericLiterals

* Set Layout/IndentationStyle to spaces

* Temporarily disable various cops.

* Add Rubocop CI via Octocop

* Lint tree with rubocop -A -c .rubocop.yml

Co-authored-by: Satadru Pramanik <satadru@gmail.com>
2022-08-22 13:31:25 -04:00
Satadru Pramanik
1e2068af78 Default Rubocop linter config for Chromebrew Take 2.5 (#6266)
* Default Rubocop linter config for Chromebrew

* Add package

* remove gem in self.remove, add xdg_base dep

* refactor

* rebuild and fixup typos

* refactor to use gem installer

* run linter on package file

* suggested changes
2022-03-31 21:57:10 -05:00