github/chromebrew
1
1
Fork 0
mirror of https://github.com/chromebrew/chromebrew.git synced 2026-01-09 23:48:01 -05:00
Code Issues Packages Projects Releases Wiki Activity
10,704 Commits 89 Branches 10 Tags
33901368d7f4f4ff393699e3fd63c5ff44a10f35
Commit Graph

18 Commits

Author SHA1 Message Date
Maximilian Downey Twiss
33901368d7 Enable more rubocop cops (#9980) 
* Remove self.check in python3.rb as tests were not actuallly being run

* Enable Lint/ImplicitStringConcatenation cop

* Enable Layout/CommentIndentation cop

* Remove unnecessary configuration of Layout/IndentationStyle to EnforcedStyle: spaces, as this is already the default

* Enable Layout/LeadingCommentSpace cop

* Enable Layout/SpaceInsideBlockBraces cop

* Enable Layout/SpaceInsideParens cop

* Enable Layout/TrailingEmptyLines cop

* Enable Lint/LiteralAsCondition cop

* Document the current issue stopping us from enabling Style/OptionalBooleanParameter

* Stop downloading our rubocop config when installing ruby_rubocop
 2024-06-17 16:19:11 -04:00
Maximilian Downey Twiss
eddca7e0e8 Enable additional temporarily disabled cops (#9394) 2024-03-01 12:24:31 -05:00
Maximilian Downey Twiss
b1c6e33094 Update rubocop target ruby version to 3.3 (#9152) 2024-01-06 20:02:23 +08:00
Maximilian Downey Twiss
86a7814bda Convert workflows to use reviewdog, run rubocop on tree (#8939) 2023-11-13 02:46:43 -05:00
SupeChicken666
9f77502974 Reimplementing #8890 (lib/const: Simplify + cleanup) (#8901) 
* lib/const: Simplify + cleanup

* Fix nil issue

* Update const.rb

* Always convert result to boolean

* Always convert result to boolean

* Use File.join to prevent duplicate slashes

* rubocop: Disable `Lint/RedundantSafeNavigation` rule

* ruby_rubocop: Update checksum

* Fix logic

* Change `CREW_DLL_PREFIX` to `CREW_WINE_PREFIX`

* Use `&&` to concatenate commands

* Update const.rb

* Remove redundant `nil`

* Bump version

* Align + more cleanup

* Don't use ENV.fetch when default value is not needed

---------

Co-authored-by: Satadru Pramanik, DO, MPH, MEng <satadru@gmail.com>
 2023-11-08 10:24:46 -05:00
Ed Reel
21f11675dd Revert "lib/const: Simplify + cleanup (#8890)" (#8895) 
This reverts commit f3a58c9492.

Fixes `crew install vim` and `crew install cantarell_fonts`.
 2023-11-05 17:49:42 -05:00
SupeChicken666
f3a58c9492 lib/const: Simplify + cleanup (#8890) 
* lib/const: Simplify + cleanup

* Fix nil issue

* Update const.rb

* Always convert result to boolean

* Always convert result to boolean

* Use File.join to prevent duplicate slashes

* rubocop: Disable `Lint/RedundantSafeNavigation` rule

* ruby_rubocop: Update checksum

* Fix logic

* Change `CREW_DLL_PREFIX` to `CREW_WINE_PREFIX`

* Use `&&` to concatenate commands

* Update const.rb

* Remove redundant `nil`

* Bump version

* Align + more cleanup

* Don't use ENV.fetch when default value is not needed
 2023-11-05 10:12:41 -06:00
Satadru Pramanik, DO, MPH, MEng
2f578f414c Adjust linter rule... (#8860) 
* chdir before using git

* fix rubocop complaint

* adjust lint rule

* expand logic of path env.d check

* bump
 2023-10-31 21:16:27 -05:00
Maximilian Downey Twiss
2f42ff39cc Run Rubocop on tree, again (#8704) 2023-09-29 07:51:08 -04:00
Maximilian Downey Twiss
41a708c1c5 Refactor workflow files (#8355) 
* Refactor workflow files

* Fix YAMLlint errors
 2023-06-13 23:42:56 -04:00
Satadru Pramanik, DO, MPH, MEng
006250d9e7 fix linecontinuation issue (#8160) 2023-04-06 13:30:52 -05:00
Satadru Pramanik
90cbf8e85e rubocop: allow CapitalW (#7499) 2022-10-15 20:06:38 -05:00
supechicken
ce3f25aa40 rubocop: Disable some cops (#7494) 
* Update .rubocop.yml

* rubocop: Disable some cops
 2022-10-14 10:55:24 -05:00
supechicken
0c0db3c649 rubocop: Disable Layout/SpaceInsideParens cop (#7465) 2022-10-08 09:47:42 -04:00
Maximilian Downey Twiss
b5e4cedb0d Re-enable And/Or cop, lint tree (#7457) 2022-10-05 20:16:53 -05:00
supechicken
db5a2c68e6 Disable And/Or check, re-enable trailing space check (#7456) 2022-10-04 09:16:08 -04:00
Maximilian Downey Twiss
de24923ee8 Add Rubocop CI (#7083) 
* Rename IgnoredPatterns to AllowedPatterns.

* Exclude docopt.rb (not our code) from Rubocop

* Disable Style/RedundantReturn

* Disable Style/MutableConstant

* Disable Style/NumericLiterals

* Set Layout/IndentationStyle to spaces

* Temporarily disable various cops.

* Add Rubocop CI via Octocop

* Lint tree with rubocop -A -c .rubocop.yml

Co-authored-by: Satadru Pramanik <satadru@gmail.com>
 2022-08-22 13:31:25 -04:00
Satadru Pramanik
1e2068af78 Default Rubocop linter config for Chromebrew Take 2.5 (#6266) 
* Default Rubocop linter config for Chromebrew

* Add package

* remove gem in self.remove, add xdg_base dep

* refactor

* rebuild and fixup typos

* refactor to use gem installer

* run linter on package file

* suggested changes
 2022-03-31 21:57:10 -05:00