github/directus
1
0
Fork 0
mirror of https://github.com/directus/directus.git synced 2026-01-25 12:07:56 -05:00
Code Issues Packages Projects Releases Wiki Activity

Silence prefer builtins and circular dependency warnings when building extensions (#18366)

Browse Source 
* Silence prefer builtins warning

* Silence circular dependency warning if only external files are involved

* Add changeset
This commit is contained in:
Nicola Krumschmidt
2023-04-28 21:07:51 +02:00
committed by GitHub
parent 76ae228c53
commit 3ff71cc34a
2 changed files with 11 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
.changeset/chilly-pugs-pay.md Normal file
View File

@@ -0,0 +1,5 @@
---
'@directus/extensions-sdk': patch
---
Silenced prefer builtins and circular dependency warnings when building extensions

7
packages/extensions-sdk/src/cli/commands/build.ts
View File

@@ -591,7 +591,7 @@ function getRollupOptions({
languages.includes('typescript') ? esbuild({ include: /\.tsx?$/, sourceMap: sourcemap }) : null,
mode === 'browser' ? styles() : null,
...plugins,
nodeResolve({ browser: mode === 'browser' }),
nodeResolve({ browser: mode === 'browser', preferBuiltins: mode === 'node' }),
commonjs({ esmExternals: mode === 'browser', sourceMap: sourcemap }),
json(),
replace({
@@ -602,6 +602,11 @@ function getRollupOptions({
}),
minify ? terser() : null,
],
onwarn(warning, warn) {
if (warning.code === 'CIRCULAR_DEPENDENCY' && warning.ids?.every((id) => /\bnode_modules\b/.test(id))) return;
warn(warning);
},
};
}