github/directus
1
0
Fork 0
mirror of https://github.com/directus/directus.git synced 2026-01-28 18:18:10 -05:00
Code Issues Packages Projects Releases Wiki Activity

Prevent empty title attribute in WYSIWYG links (#14322)

Browse Source
This commit is contained in:
Azri Kahar
2022-07-08 20:38:08 +08:00
committed by GitHub
parent 398839be6e
commit c87eb8141f
1 changed files with 4 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
app/src/interfaces/input-rich-text-html/useLink.ts
View File

@@ -110,9 +110,9 @@ export default function useLink(editor: Ref<any>): UsableLink {
const link = linkSelection.value;
if (link.url === null) return;
const linkHtml = `<a href="${link.url}" title="${link.title || ''}" target="${link.newTab ? '_blank' : '_self'}" >${
link.displayText || link.url
}</a>`;
const linkHtml = `<a href="${link.url}" ${link.title ? `title="${link.title}"` : ''} target="${
link.newTab ? '_blank' : '_self'
}" >${link.displayText || link.url}</a>`;
// New anchor tag or current selection node is an anchor tag
if (!linkNode.value || currentSelectionNode.value === linkNode.value) {
@@ -123,7 +123,7 @@ export default function useLink(editor: Ref<any>): UsableLink {
currentSelectionNode.value.innerHTML = link.displayText || link.url;
linkNode.value.setAttribute('data-mce-href', link.url); // Required for tinymce to update changes
linkNode.value.setAttribute('href', link.url);
linkNode.value.setAttribute('title', link.title || '');
if (link.title) linkNode.value.setAttribute('title', link.title);
linkNode.value.setAttribute('target', link.newTab ? '_blank' : '_self');
editor.value.selection.select(linkNode.value);
editor.value.selection.setNode(linkNode.value);