Update BaseStorage (#9985)

* Update BaseStorage

remove dublicate strings into variables

* Apply suggestions from code review

Co-authored-by: Rijk van Zanten <rijkvanzanten@me.com>

* Use enum types in keys

Co-authored-by: Rijk van Zanten <rijkvanzanten@me.com>
This commit is contained in:
NilsBaumgartner1994
2021-12-01 21:20:27 +01:00
committed by GitHub
parent 5bd41bcabb
commit fd93b850e0

View File

@@ -4,23 +4,29 @@ export type StorageOptions = {
prefix?: string;
};
enum Keys {
AuthToken = 'auth_token',
RefreshToken = 'auth_refresh_token',
Expires = 'auth_expires',
}
export abstract class BaseStorage extends IStorage {
protected prefix: string;
get auth_token(): string | null {
return this.get('auth_token');
return this.get(Keys.AuthToken);
}
set auth_token(value: string | null) {
if (value === null) {
this.delete('auth_token');
this.delete(Keys.AuthToken);
} else {
this.set('auth_token', value);
this.set(Keys.AuthToken, value);
}
}
get auth_expires(): number | null {
const value = this.get('auth_expires');
const value = this.get(Keys.Expires);
if (value === null) {
return null;
}
@@ -29,21 +35,21 @@ export abstract class BaseStorage extends IStorage {
set auth_expires(value: number | null) {
if (value === null) {
this.delete('auth_expires');
this.delete(Keys.Expires);
} else {
this.set('auth_expires', value!.toString());
this.set(Keys.Expires, value!.toString());
}
}
get auth_refresh_token(): string | null {
return this.get('auth_refresh_token');
return this.get(Keys.RefreshToken);
}
set auth_refresh_token(value: string | null) {
if (value === null) {
this.delete('auth_refresh_token');
this.delete(Keys.RefreshToken);
} else {
this.set('auth_refresh_token', value);
this.set(Keys.RefreshToken, value);
}
}