github/electron
1
1
Fork 0
mirror of https://github.com/electron/electron.git synced 2026-01-25 15:28:11 -05:00
Code Issues Packages Projects Releases Wiki Activity

Don't resolve empty src/preload attribute values

Browse Source
This commit is contained in:
Kevin Sawicki
2016-09-08 16:48:30 -07:00
parent ea069805d1
commit 1dbaf4987e
2 changed files with 9 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
lib/renderer/web-view/web-view-attributes.js
View File

@@ -9,6 +9,7 @@ const remote = require('electron').remote
var a = document.createElement('a')
var resolveURL = function (url) {
if (url === '') return ''
a.href = url
return a.href
}

8
spec/webview-spec.js
View File

@@ -80,6 +80,10 @@ describe('<webview> tag', function () {
assert.equal(webview.src, '')
webview.src = ''
assert.equal(webview.src, '')
webview.src = null
assert.equal(webview.src, '')
webview.src = undefined
assert.equal(webview.src, '')
})
})
@@ -209,6 +213,10 @@ describe('<webview> tag', function () {
assert.equal(webview.preload, '')
webview.preload = ''
assert.equal(webview.preload, '')
webview.preload = null
assert.equal(webview.preload, '')
webview.preload = undefined
assert.equal(webview.preload, '')
})
})