github/electron
1
1
Fork 0
mirror of https://github.com/electron/electron.git synced 2026-01-28 00:38:35 -05:00
Code Issues Packages Projects Releases Wiki Activity

Fix test BrowserWindow.addTabbedWindow() (#11795)

Browse Source 
* Fix test BrowserWindow.addTabbedWindow()

* Address review comments
This commit is contained in:
Nitish Sakhawalkar
2018-02-02 18:31:02 -08:00
committed by Charles Kerr
parent bd06abd523
commit 62d2a3472f
1 changed files with 8 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
spec/api-browser-window-spec.js
View File

@@ -703,8 +703,7 @@ describe('BrowserWindow module', () => {
})
})
// FIXME(alexeykuzmin): Fails on Mac.
xdescribe('BrowserWindow.addTabbedWindow()', () => {
describe('BrowserWindow.addTabbedWindow()', () => {
before(function () {
if (process.platform !== 'darwin') {
this.skip()
@@ -716,7 +715,13 @@ describe('BrowserWindow module', () => {
assert.doesNotThrow(() => {
w.addTabbedWindow(tabbedWindow)
})
closeWindow(tabbedWindow).then(done)
assert.equal(BrowserWindow.getAllWindows().length, 3) // Test window + w + tabbedWindow
closeWindow(tabbedWindow, {assertSingleWindow: false}).then(() => {
assert.equal(BrowserWindow.getAllWindows().length, 2) // Test window + w
done()
})
})
})