github/electron
1
1
Fork 0
mirror of https://github.com/electron/electron.git synced 2026-01-28 00:38:35 -05:00
Code Issues Packages Projects Releases Wiki Activity

chore: disable clang-format and cpplint for impl of HandleExternalProtocol

Browse Source 
NOLINT disables the linting error that we can't fix because its just
implementing a content API.

We also disable clang-format because it tries to format the // NOLINT
onto a new line which doesn't exactly work
This commit is contained in:
Samuel Attard
2019-03-21 21:02:40 -07:00
parent 126639875d
commit b429e6e2df
2 changed files with 7 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
atom/browser/atom_browser_client.cc
View File

@@ -832,7 +832,9 @@ bool AtomBrowserClient::HandleExternalProtocol(
const std::string& method,
const net::HttpRequestHeaders& headers,
network::mojom::URLLoaderFactoryRequest* factory_request,
network::mojom::URLLoaderFactory*& out_factory) {
// clang-format off
network::mojom::URLLoaderFactory*& out_factory) { // NOLINT
// clang-format on
base::PostTaskWithTraits(
FROM_HERE, {BrowserThread::UI},
base::BindOnce(&HandleExternalProtocolInUI, url, web_contents_getter,

5
atom/browser/atom_browser_client.h
View File

@@ -174,7 +174,10 @@ class AtomBrowserClient : public content::ContentBrowserClient,
const std::string& method,
const net::HttpRequestHeaders& headers,
network::mojom::URLLoaderFactoryRequest* factory_request,
network::mojom::URLLoaderFactory*& out_factory) override;
// clang-format off
network::mojom::URLLoaderFactory*& out_factory) // NOLINT
// clang-format on
override;
private:
struct ProcessPreferences {