Merge pull request #11256 from electron/fix-11244

Enable "<webview> tag found-in-page event emits when a request is made"
This commit is contained in:
Zeke Sikelianos
2017-11-30 10:48:00 -08:00
committed by GitHub

View File

@@ -936,9 +936,7 @@ describe('<webview> tag', function () {
})
})
// TODO(alexeykuzmin): Disabled during Chromium 61 upgrade.
// Fix it and enable.
xdescribe('found-in-page event', () => {
describe('found-in-page event', () => {
it('emits when a request is made', (done) => {
let requestId = null
let activeMatchOrdinal = []
@@ -961,6 +959,11 @@ describe('<webview> tag', function () {
webview.addEventListener('did-finish-load', listener2)
webview.src = `file://${fixtures}/pages/content.html`
document.body.appendChild(webview)
// TODO(deepak1556): With https://codereview.chromium.org/2836973002
// focus of the webContents is required when triggering the api.
// Remove this workaround after determining the cause for
// incorrect focus.
webview.focus()
})
})