mirror of
https://github.com/electron/electron.git
synced 2026-01-24 14:57:58 -05:00
🎨 Log a warning if an extension's manifest cannot be parsed
Also logs a clean warning if an extension's manifest is incomplete, missing, or can otherwise not be parsed.
This commit is contained in:
@@ -20,7 +20,15 @@ const generateExtensionIdFromName = function (name) {
|
||||
|
||||
// Create or get manifest object from |srcDirectory|.
|
||||
const getManifestFromPath = function (srcDirectory) {
|
||||
const manifest = JSON.parse(fs.readFileSync(path.join(srcDirectory, 'manifest.json')))
|
||||
let manifest
|
||||
|
||||
try {
|
||||
manifest = JSON.parse(fs.readFileSync(path.join(srcDirectory, 'manifest.json')))
|
||||
} catch (err) {
|
||||
console.warn(`Attempted to load extension from ${srcDirectory}, but parsing the manifest failed.`)
|
||||
console.warn('Error encountered:', err)
|
||||
}
|
||||
|
||||
if (!manifestNameMap[manifest.name]) {
|
||||
const extensionId = generateExtensionIdFromName(manifest.name)
|
||||
console.log(extensionId)
|
||||
|
||||
Reference in New Issue
Block a user